Skip to contentSkip to conversation

net/nfp: remove unneeded header inclusion

PATCH Applied David Marchand 3 participants 3 messages Apr 8, 2022 – May 4, 2022 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/nfp: remove unneeded header inclusion

Looking at this driver history, there was never a need for including execinfo.h.

---
 drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c +0 -3
index bad80a5a1c..08bc4e8ef2 100644
@@ -16,9 +16,6 @@
 
 #include <assert.h>
 #include <stdio.h>
-#if defined(RTE_BACKTRACE)
-#include <execinfo.h>
-#endif
 #include <stdlib.h>
 #include <unistd.h>
 #include <stdint.h>
Signature · 1 line
2.23.0
Reviewed-by on v1 1/1
#1 lore raw

Hi David,

Thanks for your work.

Quoted 4 lines · David Marchand

Looking at this driver history, there was never a need for including execinfo.h.

Quoted 21 lines
---
 drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c +0 -3
index bad80a5a1c..08bc4e8ef2 100644
@@ -16,9 +16,6 @@
 
 #include <assert.h>
 #include <stdio.h>
-#if defined(RTE_BACKTRACE)
-#include <execinfo.h>
-#endif
 #include <stdlib.h>
 #include <unistd.h>
 #include <stdint.h>
Signature · 1 line
2.23.0
Signature · 2 lines
Kind Regards,
Niklas Söderlund