RDMA/rxe: Remove reliable datagram support
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 RDMA/rxe: Remove reliable datagram support
-------- Forwarded Message --------
Subject: [PATCH for-next] RDMA/rxe: Remove reliable datagram support
Date: Thu, 7 Apr 2022 14:05:23 -0500
From: Bob Pearson <[email protected]>
To: [email protected], [email protected], [email protected]
CC: Bob Pearson <[email protected]>
The rdma_rxe driver does not actually support the reliable datagram transport but contains two references to RD opcodes in driver code.
This commit removes these references to RD transport opcodes which are never used.
--- drivers/infiniband/sw/rxe/rxe_req.c | 3 +-- drivers/infiniband/sw/rxe/rxe_resp.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)
drivers/infiniband/sw/rxe/rxe_req.c +1 -2
@@ -413,8 +413,7 @@ static struct sk_buff *init_req_packet(struct rxe_qp *qp,if (pkt->mask &RXE_ATMETH_MASK ) {atmeth_set_va (pkt, wqe->iova); -if (opcode ==IB_OPCODE_RC_COMPARE_SWAP || - opcode ==IB_OPCODE_RD_COMPARE_SWAP ) { +if (opcode ==IB_OPCODE_RC_COMPARE_SWAP ) {atmeth_set_swap_add (pkt, ibwr->wr.atomic.swap);atmeth_set_comp (pkt, ibwr->wr.atomic.compare_add); }else {
drivers/infiniband/sw/rxe/rxe_resp.c +1 -2
@@ -576,8 +576,7 @@ static enum resp_states process_atomic(struct rxe_qp *qp, qp->resp.atomic_orig = *vaddr; -if (pkt->opcode ==IB_OPCODE_RC_COMPARE_SWAP || - pkt->opcode ==IB_OPCODE_RD_COMPARE_SWAP ) { +if (pkt->opcode ==IB_OPCODE_RC_COMPARE_SWAP ) {if (*vaddr ==atmeth_comp (pkt)) *vaddr =atmeth_swap_add (pkt); }else {
Signature · 1 line
2.32.0
Quoted 10 lines · Bob Pearson
-------- Forwarded Message --------
Subject: [PATCH for-next] RDMA/rxe: Remove reliable datagram support
Date: Thu, 7 Apr 2022 14:05:23 -0500
From: Bob Pearson <[email protected]>
To: [email protected], [email protected], [email protected]
CC: Bob Pearson <[email protected]>
Quoted 4 lines
The
rdma_rxedriver does not actually support the reliable datagram transport but contains two references to RD opcodes in driver code.
This commit removes these references to RD transport opcodes which are never used.
Hi Bob,
Agreed. It looks good to me. ^_^
Best Regards,
Xiao Yang
Quoted 35 lines
Signed-off-by Bob Pearson <[email protected]>--- drivers/infiniband/sw/rxe/rxe_req.c | 3 +-- drivers/infiniband/sw/rxe/rxe_resp.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)drivers/infiniband/sw/rxe/rxe_req.c +1
-2@@ -413,8 +413,7 @@ static struct sk_buff *init_req_packet(struct rxe_qp *qp,if (pkt->mask &RXE_ATMETH_MASK ) {atmeth_set_va (pkt, wqe->iova); -if (opcode ==IB_OPCODE_RC_COMPARE_SWAP || - opcode ==IB_OPCODE_RD_COMPARE_SWAP ) { +if (opcode ==IB_OPCODE_RC_COMPARE_SWAP ) {atmeth_set_swap_add (pkt, ibwr->wr.atomic.swap);atmeth_set_comp (pkt, ibwr->wr.atomic.compare_add); }else {drivers/infiniband/sw/rxe/rxe_resp.c +1
-2@@ -576,8 +576,7 @@ static enum resp_states process_atomic(struct rxe_qp *qp, qp->resp.atomic_orig = *vaddr; -if (pkt->opcode ==IB_OPCODE_RC_COMPARE_SWAP || - pkt->opcode ==IB_OPCODE_RD_COMPARE_SWAP ) { +if (pkt->opcode ==IB_OPCODE_RC_COMPARE_SWAP ) {if (*vaddr ==atmeth_comp (pkt)) *vaddr =atmeth_swap_add (pkt); }else {
Quoted 10 lines · Bob Pearson
The
rdma_rxedriver does not actually support the reliable datagram transport but contains two references to RD opcodes in driver code.
This commit removes these references to RD transport opcodes which are never used.Signed-off-by Bob Pearson <[email protected]>--- drivers/infiniband/sw/rxe/rxe_req.c | 3 +-- drivers/infiniband/sw/rxe/rxe_resp.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)
Applied to for-next, thanks
Jason