Skip to contentSkip to conversation

drm/gma500: select framebuffer dependency

PATCH In review James Hilliard 2 participants 2 messages Apr 9, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/gma500: select framebuffer dependency

This appears to be needed for video output to function correctly.

---
 drivers/gpu/drm/gma500/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/gma500/Kconfig +2 -0
index 0cff20265f97..ff8c7b6e87f5 100644
@@ -7,6 +7,8 @@ config DRM_GMA500
 	select ACPI_VIDEO if ACPI
 	select BACKLIGHT_CLASS_DEVICE if ACPI
 	select INPUT if ACPI
+	select FB
+	select FB_EFI if EFI
 	help
 	  Say yes for an experimental 2D KMS framebuffer driver for the
 	  Intel GMA500 (Poulsbo), Intel GMA600 (Moorestown/Oak Trail) and
Signature · 1 line
2.25.1
#1 lore raw

Hi,

Quoted 1 line · James Hilliard

This appears to be needed for video output to function correctly.

More proof/justification?

Quoted 10 lines
---
 drivers/gpu/drm/gma500/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/gma500/Kconfig +0 -0
index 0cff20265f97..ff8c7b6e87f5 100644

drivers/gpu/drm/gma500/Kconfig config DRM_GMA500 · line 10

Quoted 4 lines
drivers/gpu/drm/gma500/Kconfig +1 -0
@@ -7,6 +7,8 @@ config DRM_GMA500
 	select ACPI_VIDEO if ACPI
 	select BACKLIGHT_CLASS_DEVICE if ACPI
 	select INPUT if ACPI
+	select FB

Preferably
depends on FB

There are a few instances of an arch (or board) selecting FB, which makes some sense, but other drivers shouldn't be doing that IMO.

drivers/gpu/drm/gma500/Kconfig config DRM_GMA500 · line 14

Quoted 4 lines
drivers/gpu/drm/gma500/Kconfig +1 -0
+	select FB_EFI if EFI
 	help
 	  Say yes for an experimental 2D KMS framebuffer driver for the
 	  Intel GMA500 (Poulsbo), Intel GMA600 (Moorestown/Oak Trail) and

thanks.

Signature · 1 line
~Randy