Skip to contentSkip to conversation

drm/gma500: depend on framebuffer

PATCH Superseded James Hilliard 2 participants 2 messages Apr 9, 2022

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/gma500: depend on framebuffer

This appears to be needed for video output to function correctly.

---
Changes v1 -> v2:
- use depends instead of select

---
 drivers/gpu/drm/gma500/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/gma500/Kconfig +2 -0
index 0cff20265f97..8ea87bfa95f5 100644
@@ -2,6 +2,8 @@
 config DRM_GMA500
 	tristate "Intel GMA500/600/3600/3650 KMS Framebuffer"
 	depends on DRM && PCI && X86 && MMU
+	depends on FB
+	depends on FB_EFI || !EFI
 	select DRM_KMS_HELPER
 	# GMA500 depends on ACPI_VIDEO when ACPI is enabled, just like i915
 	select ACPI_VIDEO if ACPI
Signature · 1 line
2.25.1
#1 lore raw
Quoted 6 lines · James Hilliard

This appears to be needed for video output to function correctly.

---
Changes v1 -> v2:
- use depends instead of select

Thanks.

Quoted 9 lines
---
 drivers/gpu/drm/gma500/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/gma500/Kconfig +0 -0
index 0cff20265f97..8ea87bfa95f5 100644

drivers/gpu/drm/gma500/Kconfig line 6

Quoted 5 lines
drivers/gpu/drm/gma500/Kconfig +2 -0
@@ -2,6 +2,8 @@
 config DRM_GMA500
 	tristate "Intel GMA500/600/3600/3650 KMS Framebuffer"
 	depends on DRM && PCI && X86 && MMU
+	depends on FB
+	depends on FB_EFI || !EFI

I'm OK with the second line of the first patch:

+ select FB_EFI if EFI

It's just that a single driver shouldn't enable an entire subsystem (like FB) on its own. But once FB is set (depends on in this patch), selecting FB_EFI would be OK IMO.

Quoted 3 lines
drivers/gpu/drm/gma500/Kconfig +0 -0
 	select DRM_KMS_HELPER
 	# GMA500 depends on ACPI_VIDEO when ACPI is enabled, just like i915
 	select ACPI_VIDEO if ACPI
Signature · 1 line
~Randy