Skip to contentSkip to conversation

mtd: nand: separate ecc-mxic from nandcore

PATCH New Chuanhong Guo 2 participants 2 messages Apr 9, 2022

Subsystems (2)
Memory technology devices (MTD) NAND flash
lore
Share & tools
lore

Chuanhong Guo

author
#0 lore raw

PATCH 1/1 mtd: nand: separate ecc-mxic from nandcore

ecc-mxic contains its own MODULE_* macros. It should get a separated obj- entry in Makefile instead of being built as a part of nandcore.o

Fixes 48e6633a9fa2 ("mtd: nand: mxic-ecc: Add Macronix external ECC engine support")
Signed-off-by Chuanhong Guo <[email protected]>
---
 drivers/mtd/nand/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/nand/Makefile +1 -1
index a4e6b7ae0614..dbc62bc7b2f9 100644
@@ -2,6 +2,7 @@
 
 nandcore-objs := core.o bbt.o
 obj-$(CONFIG_MTD_NAND_CORE) += nandcore.o
+obj-$(CONFIG_MTD_NAND_ECC_MXIC) += ecc-mxic.o
 
 obj-y	+= onenand/
 obj-y	+= raw/

@@ -10,4 +11,3 @@ obj-y	+= spi/
 nandcore-$(CONFIG_MTD_NAND_ECC) += ecc.o
 nandcore-$(CONFIG_MTD_NAND_ECC_SW_HAMMING) += ecc-sw-hamming.o
 nandcore-$(CONFIG_MTD_NAND_ECC_SW_BCH) += ecc-sw-bch.o
-nandcore-$(CONFIG_MTD_NAND_ECC_MXIC) += ecc-mxic.o
Signature · 1 line
2.35.1
build bot
#1 lore raw
Thank you for the patch! Yet something to improve:

Hi Chuanhong,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mtd/nand/next]
[also build test ERROR on v5.18-rc1 next-20220408]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Chuanhong-Guo/mtd-nand-separate-ecc-mxic-from-nandcore/20220409-132331
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next
config: sh-randconfig-r013-20220408 (https://download.01.org/0day-ci/archive/20220409/[email protected]/config)
compiler: sh4-linux-gcc (GCC) 11.2.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/a96780fbe6f7bc76d07fd5a4ccc390e7fedcc8b5
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Chuanhong-Guo/mtd-nand-separate-ecc-mxic-from-nandcore/20220409-132331 git checkout a96780fbe6f7bc76d07fd5a4ccc390e7fedcc8b5
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate

Reported-by kernel test robot <[email protected]>

All errors (new ones prefixed by >>, old ones prefixed by <<):

>> ERROR: modpost: "mxic_ecc_process_data_pipelined" [drivers/spi/spi-mxic.ko] undefined!
>> ERROR: modpost: "mxic_ecc_get_pipelined_engine" [drivers/spi/spi-mxic.ko] undefined!
>> ERROR: modpost: "mxic_ecc_get_pipelined_ops" [drivers/spi/spi-mxic.ko] undefined!
>> ERROR: modpost: "mxic_ecc_put_pipelined_engine" [drivers/spi/spi-mxic.ko] undefined!
Signature · 2 lines
0-DAY CI Kernel Test Service
https://01.org/lkp