rtw89: pci: reversed conditions in rtw89_write16_mdio_mask()
Subsystems (2)
PATCH 1/1 rtw89: pci: reversed conditions in rtw89_write16_mdio_mask()
These if conditions are reversed so it will just return success without writing.
Fixes 740c431c22fe ("rtw89: pci: add register definition to rtw89_pci_info to generalize pci code")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/net/wireless/realtek/rtw89/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/realtek/rtw89/pci.c +2 -2
@@ -1522,7 +1522,7 @@ rtw89_write16_mdio_mask(struct rtw89_dev *rtwdev, u8 addr, u16 mask, u16 data, uu16 val; ret =rtw89_read16_mdio (rtwdev, addr, speed, &val); -if (!ret) +if (ret)return ret; shift =__ffs (mask);
@@ -1530,7 +1530,7 @@ rtw89_write16_mdio_mask(struct rtw89_dev *rtwdev, u8 addr, u16 mask, u16 data, u val |= ((data << shift) & mask); ret =rtw89_write16_mdio (rtwdev, addr, val, speed); -if (!ret) +if (ret)return ret;return 0 ;
Signature · 1 line
2.20.1
Pkshih
maintainerQuoted 26 lines · Dan Carpenter
These if conditions are reversed so it will just return success without writing.
Fixes 740c431c22fe ("rtw89: pci: add register definition to rtw89_pci_info to generalize pcicode")
Signed-off-by Dan Carpenter <[email protected]>--- drivers/net/wireless/realtek/rtw89/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/net/wireless/realtek/rtw89/pci.c +0
-0@@ -1522,7 +1522,7 @@ rtw89_write16_mdio_mask(struct rtw89_dev *rtwdev, u8 addr, u16 mask, u16data, u
drivers/net/wireless/realtek/rtw89/pci.c +1
-1u16 val; ret =rtw89_read16_mdio (rtwdev, addr, speed, &val); -if (!ret) +if (ret)return ret; shift =__ffs (mask);@@ -1530,7 +1530,7 @@ rtw89_write16_mdio_mask(struct rtw89_dev *rtwdev, u8 addr, u16 mask, u16data, u
drivers/net/wireless/realtek/rtw89/pci.c rtw89_write16_mdio_mask(struct rtw89_dev *rtwdev, u8 addr, u16 mask, u16 data, u · line 1536
Quoted 8 lines
drivers/net/wireless/realtek/rtw89/pci.c +1
-1val |= ((data << shift) & mask); ret =rtw89_write16_mdio (rtwdev, addr, val, speed); -if (!ret) +if (ret)return ret;return 0 ;
I have found and sent a patch to fix this:
https://lore.kernel.org/linux-wireless/[email protected]/T/#u
Thank you
Ping-Ke