net/mlx5: add support for set promiscuous modes in Windows
PATCH 1/2 net/mlx5: add support for set promiscuous modes in Windows
Support of the set promiscuous modes by calling the new API In Mlx5DevX Lib.
Added new glue API for Windows which will be used to communicate with Windows driver to enable/disable PROMISC or ALLMC.
Signed-off-by Adham Masarwah <[email protected]>
Tested-by Idan Hackmon <[email protected]>
Acked-by Matan Azard <[email protected]>
--- drivers/common/mlx5/windows/mlx5_glue.c | 31 +++++++++++++++++++++++++++++++ drivers/common/mlx5/windows/mlx5_glue.h | 6 ++++++ drivers/net/mlx5/windows/mlx5_os.c | 15 ++++++--------- 3 files changed, 43 insertions(+), 9 deletions(-)
drivers/common/mlx5/windows/mlx5_glue.c +31 -0
@@ -328,6 +328,36 @@ mlx5_glue_devx_init_showdown_event(void *ctx)return 0 ; } +static int +mlx5_glue_devx_set_promisc_vport (void *ctx,uint32_t promisc_type,uint8_t f_enable) +{ +#ifdef HAVE_DEVX_SET_PROMISC_SUPPORT +int devx_promisc_type =MLX5_DEVX_SET_PROMISC_VPORT_PROMISC_MODE ; +struct mlx5_context *mlx5_ctx; +int err; + +if (!ctx) { + errno =EINVAL ; +return errno; + } + mlx5_ctx = (struct mlx5_context *)ctx; +if (promisc_type ==MC_PROMISC ) + devx_promisc_type =MLX5_DEVX_SET_PROMISC_VPORT_ALL_MULTICAST ; + err =devx_set_promisc_vport (mlx5_ctx->devx_ctx, devx_promisc_type, f_enable); +if (err) { + errno = err; +return errno; + } +return 0 ; +#else + (void )promisc_type; + (void )f_enable; + (void )ctx; +DRV_LOG (WARNING ,"%s: is not supported" , __func__); +return -ENOTSUP ; +#endif +} + alignas(RTE_CACHE_LINE_SIZE )const struct mlx5_glue *mlx5_glue = &(const struct mlx5_glue ){ .version =MLX5_GLUE_VERSION ,
@@ -351,4 +381,5 @@ const struct mlx5_glue *mlx5_glue = &(const struct mlx5_glue){ .devx_query_eqn = mlx5_glue_devx_query_eqn, .query_rt_values = mlx5_glue_query_rt_values, .devx_init_showdown_event = mlx5_glue_devx_init_showdown_event, + .devx_set_promisc_vport = mlx5_glue_devx_set_promisc_vport, };
drivers/common/mlx5/windows/mlx5_glue.h +6 -0
@@ -49,6 +49,11 @@ struct mlx5dv_dr_action_dest_attr { };#endif +enum { +ALL_PROMISC , +MC_PROMISC , +}; +/* LIB_GLUE_VERSION must be updated every time this structure is modified. */ struct mlx5_glue {const char *version;
@@ -87,6 +92,7 @@ struct mlx5_glue {int (*devx_query_eqn)(void *context,uint32_t cpus,uint32_t *eqn);int (*query_rt_values)(void *ctx,void *devx_clock);int (*devx_init_showdown_event)(void *ctx); +int (*devx_set_promisc_vport)(void *ctx,uint32_t promisc_type,uint8_t f_enable); };extern const struct mlx5_glue *mlx5_glue;
drivers/net/mlx5/windows/mlx5_os.c +6 -9
@@ -729,7 +729,6 @@ mlx5_os_vf_mac_addr_modify(struct mlx5_priv *priv,/** * Set device promiscuous mode -* Currently it has no support under Windows. * * @param dev * Pointer to Ethernet device structure.
@@ -742,10 +741,9 @@ mlx5_os_vf_mac_addr_modify(struct mlx5_priv *priv,int mlx5_os_set_promisc (struct rte_eth_dev *dev,int enable) { - (void )dev; - (void )enable; -DRV_LOG (WARNING ,"%s: is not supported" , __func__); -return -ENOTSUP ; +struct mlx5_priv *priv = dev->data->dev_private; + +return mlx5_glue->devx_set_promisc_vport (priv->sh->cdev->ctx,ALL_PROMISC , enable); }/**
@@ -762,10 +760,9 @@ mlx5_os_set_promisc(struct rte_eth_dev *dev, int enable)int mlx5_os_set_allmulti (struct rte_eth_dev *dev,int enable) { - (void )dev; - (void )enable; -DRV_LOG (WARNING ,"%s: is not supported" , __func__); -return -ENOTSUP ; +struct mlx5_priv *priv = dev->data->dev_private; + +return mlx5_glue->devx_set_promisc_vport (priv->sh->cdev->ctx,MC_PROMISC , enable); }/**
Signature · 1 line
2.16.1.windows.4
PATCH 2/2 net/mlx5: add support for set and get MTU in Windows
Mlx5Devx library has new API's for setting and getting MTU. Added new glue functions that wrap the new mlx5devx lib API's. Implemented the os_ethdev callbacks to use the new glue functions in Windows.
Signed-off-by Adham Masarwah <[email protected]>
Tested-by Idan Hackmon <[email protected]>
Acked-by Matan Azard <[email protected]>
--- drivers/common/mlx5/windows/mlx5_glue.c | 55 +++++++++++++++++++++++++++++++ drivers/common/mlx5/windows/mlx5_glue.h | 2 ++ drivers/net/mlx5/windows/mlx5_ethdev_os.c | 31 ++++++++++++++--- 3 files changed, 84 insertions(+), 4 deletions(-)
drivers/common/mlx5/windows/mlx5_glue.c +55 -0
@@ -358,6 +358,59 @@ mlx5_glue_devx_set_promisc_vport(void *ctx, uint32_t promisc_type, uint8_t f_ena#endif } +static int +mlx5_glue_devx_get_mtu (void *ctx,uint32_t *mtu) +{ +int err =0 ; +struct mlx5_context *mlx5_ctx; + +if (!ctx) { + errno =EINVAL ; +return errno; + } + mlx5_ctx = (struct mlx5_context *)ctx; +#ifdef HAVE_DEVX_SET_GET_MTU_SUPPORT + err =devx_get_mtu (mlx5_ctx->devx_ctx, mtu); +if (err) { + errno = err; +return errno; + } +#else + *mtu = mlx5_ctx->mlx5_dev.mtu_bytes; +#endif + +return err; +} + +static int +mlx5_glue_devx_set_mtu (void *ctx,uint32_t mtu) +{ +#ifdef HAVE_DEVX_SET_GET_MTU_SUPPORT +struct mlx5_context *mlx5_ctx; +int err; + +if (!ctx) { + errno =EINVAL ; +return errno; + } + mlx5_ctx = (struct mlx5_context *)ctx; + err =devx_set_mtu (mlx5_ctx->devx_ctx, mtu); +if (err) { + errno = err; +return errno; + } +return 0 ; +#else + (void )mtu; + (void )ctx; +DRV_LOG (WARNING ,"%s: is not supported" , __func__); +return -ENOTSUP ; +#endif + +} + + + alignas(RTE_CACHE_LINE_SIZE )const struct mlx5_glue *mlx5_glue = &(const struct mlx5_glue ){ .version =MLX5_GLUE_VERSION ,
@@ -382,4 +435,6 @@ const struct mlx5_glue *mlx5_glue = &(const struct mlx5_glue){ .query_rt_values = mlx5_glue_query_rt_values, .devx_init_showdown_event = mlx5_glue_devx_init_showdown_event, .devx_set_promisc_vport = mlx5_glue_devx_set_promisc_vport, + .devx_get_mtu = mlx5_glue_devx_get_mtu, + .devx_set_mtu = mlx5_glue_devx_set_mtu, };
drivers/common/mlx5/windows/mlx5_glue.h +2 -0
@@ -93,6 +93,8 @@ struct mlx5_glue {int (*query_rt_values)(void *ctx,void *devx_clock);int (*devx_init_showdown_event)(void *ctx);int (*devx_set_promisc_vport)(void *ctx,uint32_t promisc_type,uint8_t f_enable); +int (*devx_get_mtu)(void *ctx,uint32_t *mtu); +int (*devx_set_mtu)(void *ctx,uint32_t mtu); };extern const struct mlx5_glue *mlx5_glue;
drivers/net/mlx5/windows/mlx5_ethdev_os.c +27 -4
@@ -85,6 +85,8 @@ mlx5_get_ifname(const struct rte_eth_dev *dev, char (*ifname)[MLX5_NAMESIZE])int mlx5_get_mtu (struct rte_eth_dev *dev,uint16_t *mtu) { +int err; +uint32_t curr_mtu;struct mlx5_priv *priv;mlx5_context_st *context_obj;
@@ -94,7 +96,14 @@ mlx5_get_mtu(struct rte_eth_dev *dev, uint16_t *mtu) } priv = dev->data->dev_private; context_obj = (mlx5_context_st *)priv->sh->cdev->ctx; - *mtu = context_obj->mlx5_dev.mtu_bytes; + + err = mlx5_glue->devx_get_mtu (context_obj, &curr_mtu); +if (err !=0 ) { +DRV_LOG (WARNING ,"Could not get the MTU!" ); +return err; + } + *mtu = (uint16_t )curr_mtu; +return 0 ; }
@@ -112,9 +121,23 @@ mlx5_get_mtu(struct rte_eth_dev *dev, uint16_t *mtu)int mlx5_set_mtu (struct rte_eth_dev *dev,uint16_t mtu) { -RTE_SET_USED (dev); -RTE_SET_USED (mtu); -return -ENOTSUP ; +int err; +struct mlx5_priv *priv; +mlx5_context_st *context_obj; + +if (!dev) { + rte_errno =EINVAL ; +return -rte_errno; + } + priv = dev->data->dev_private; + context_obj = (mlx5_context_st *)priv->sh->cdev->ctx; + + err = mlx5_glue->devx_set_mtu (context_obj, mtu); +if (err !=0 ) { +DRV_LOG (WARNING ,"Could not set the MTU!" ); +return err; + } +return 0 ; }/*
Signature · 1 line
2.16.1.windows.4