Skip to contentSkip to conversation

fbdev: i740fb: use memset_io() to clear screen

PATCH Applied Ondrej Zary 2 participants 2 messages Apr 10, 2022 – Apr 11, 2022 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fbdev: i740fb: use memset_io() to clear screen

sparse complains that using memset() on __iomem pointer is wrong:
incorrect type in argument 1 (different address spaces)

Use memset_io() to clear screen instead.

Tested on real i740 cards.

---
 drivers/video/fbdev/i740fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/i740fb.c +1 -1
index 52cce0db8bd3..dd45ea8203be 100644
@@ -740,7 +740,7 @@ static int i740fb_set_par(struct fb_info *info)
 	if (i)
 		return i;
 
-	memset(info->screen_base, 0, info->screen_size);
+	memset_io(info->screen_base, 0, info->screen_size);
 
 	vga_protect(par);
 
Signature · 1 line
Ondrej Zary
maintainer Applied
#1 lore raw
Quoted 8 lines · Ondrej Zary

sparse complains that using memset() on __iomem pointer is wrong:
incorrect type in argument 1 (different address spaces)

Use memset_io() to clear screen instead.

Tested on real i740 cards.

applied.
Thanks!

Helge

Quoted 17 lines
---
 drivers/video/fbdev/i740fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/i740fb.c +1 -1
index 52cce0db8bd3..dd45ea8203be 100644
@@ -740,7 +740,7 @@ static int i740fb_set_par(struct fb_info *info)
 	if (i)
 		return i;
 
-	memset(info->screen_base, 0, info->screen_size);
+	memset_io(info->screen_base, 0, info->screen_size);
 
 	vga_protect(par);