Skip to contentSkip to conversation

libvirt: package all sysctl conf files for libvirtd

PATCH In review Chen Qi 2 participants 2 messages Apr 11, 2022

lore
Share & tools
lore

Chen Qi

author
#0 lore raw

PATCH 1/1 libvirt: package all sysctl conf files for libvirtd

The libvirtd package has already packaged ${sysconfdir}/sysctl.d, and also the /usr/lib/sysctl.d/60-libvirtd.conf, it would be reasonable for it to package other sysctl conf files, otherwise we will meet the following error in case of multilib.

QA Issue: libvirt: Files/directories were installed but not shipped in any package:
/usr/lib/sysctl.d/60-qemu-postcopy-migration.conf

---
 recipes-extended/libvirt/libvirt_8.1.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-extended/libvirt/libvirt_8.1.0.bb +1 -1
index b90fb704..433601c6 100644
@@ -62,7 +62,7 @@ FILES:${PN}-libvirtd = " \
 	${sysconfdir}/sysctl.d \
 	${sysconfdir}/logrotate.d \
 	${sysconfdir}/libvirt/libvirtd.conf \
-        /usr/lib/sysctl.d/60-libvirtd.conf \
+        /usr/lib/sysctl.d/ \
 	${sbindir}/libvirtd \
 	${systemd_system_unitdir} \
 	${@bb.utils.contains('DISTRO_FEATURES', 'sysvinit', '', '${libexecdir}/libvirt-guests.sh', d)} \
Signature · 1 line
2.33.0
#1 lore raw
Quoted 9 lines · Chen Qi

The libvirtd package has already packaged ${sysconfdir}/sysctl.d, and also the /usr/lib/sysctl.d/60-libvirtd.conf, it would be reasonable for it to package other sysctl conf files, otherwise we will meet the following error in case of multilib.

QA Issue: libvirt: Files/directories were installed but not shipped in
any package:
/usr/lib/sysctl.d/60-qemu-postcopy-migration.conf

See the patch that I sent as well.

There's no reason to have /usr/lib anywhere in the packaging at all. We should just rely on ${libdir}, if libvirt is installing outside of the definition of ${libdir}, then we can patch ilbvirt, versus hardcoding /usr/lib in the FILES variables.

Bruce

Quoted 36 lines
---
 recipes-extended/libvirt/libvirt_8.1.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-extended/libvirt/libvirt_8.1.0.bb +1 -1
index b90fb704..433601c6 100644
@@ -62,7 +62,7 @@ FILES:${PN}-libvirtd = " \
        ${sysconfdir}/sysctl.d \
        ${sysconfdir}/logrotate.d \
        ${sysconfdir}/libvirt/libvirtd.conf \
-        /usr/lib/sysctl.d/60-libvirtd.conf \
+        /usr/lib/sysctl.d/ \
        ${sbindir}/libvirtd \
        ${systemd_system_unitdir} \
        ${@bb.utils.contains('DISTRO_FEATURES', 'sysvinit', '',

'${libexecdir}/libvirt-guests.sh', d)} \
--
2.33.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#7155):
https://lists.yoctoproject.org/g/meta-virtualization/message/7155
Mute This Topic: https://lists.yoctoproject.org/mt/90394721/1050810
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II