cpu/hotplug: Fix cpuhp_cpu_state used before init
v3 cover cpu/hotplug: Fix cpuhp_cpu_state used before init
Currently it's possible to trigger a case where the cpuhp_cpu_state::cpu member is used before it has been initialised. This can cause CPU 0 to be erroneously marked as dying and trigger a scheduler panic (full details in v1[1]).
The two patches here fix the root cause by removing the 'cpu' member altogether and to prevent similar confusion in the future ensure that the cpuhp_cpu_state structures are initialised before any hotplugging occurs.
Changes since v2[2]:
* Remove the cpu member altogether (first patch)
* Move the initialisation of cpuhp_cpu_state as suggested by tglx (second patch)
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
Steven Price (2):
cpu/hotplug: Remove the 'cpu' member of cpuhp_cpu_state cpu/hotplug: Initialise all cpuhp_cpu_state structs earlier
kernel/cpu.c | 58 ++++++++++++++++++++++++++++------------------------ 1 file changed, 31 insertions(+), 27 deletions(-)
Signature · 1 line
2.25.1
PATCH v3 1/2 cpu/hotplug: Remove the 'cpu' member of cpuhp_cpu_state
Currently the setting of the 'cpu' member of struct cpuhp_cpu_state in cpuhp_create() is too late as it is used earlier in _cpu_up(). If the kzalloc_node() in __smpboot_create_thread() fails then the rollback will be done with st->cpu==0 causing CPU0 to be erroneously set to be dying, causing the scheduler to get mightily confused and throw its toys out of the pram.
However the cpu number is actually available directly, so simply remove the 'cpu' member and avoid the problem in the first place.
--- kernel/cpu.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-)
kernel/cpu.c +18 -18
@@ -70,7 +70,6 @@ struct cpuhp_cpu_state {bool rollback;bool single;bool bringup; -int cpu;struct hlist_node *node;struct hlist_node *last;enum cpuhp_state cb_state;
@@ -474,7 +473,7 @@ static inline bool cpu_smt_allowed(unsigned int cpu) { return true; }#endif static inline enum cpuhp_state -cpuhp_set_state (struct cpuhp_cpu_state *st,enum cpuhp_state target) +cpuhp_set_state (int cpu,struct cpuhp_cpu_state *st,enum cpuhp_state target) {enum cpuhp_state prev_state = st->state;bool bringup = st->state < target;
@@ -485,14 +484,15 @@ cpuhp_set_state(struct cpuhp_cpu_state *st, enum cpuhp_state target) st->target = target; st->single = false; st->bringup = bringup; -if (cpu_dying (st->cpu) != !bringup) -set_cpu_dying (st->cpu, !bringup); +if (cpu_dying (cpu) != !bringup) +set_cpu_dying (cpu, !bringup);return prev_state; }static inline void -cpuhp_reset_state (struct cpuhp_cpu_state *st,enum cpuhp_state prev_state) +cpuhp_reset_state (int cpu,struct cpuhp_cpu_state *st, +enum cpuhp_state prev_state) {bool bringup = !st->bringup;
@@ -519,8 +519,8 @@ cpuhp_reset_state(struct cpuhp_cpu_state *st, enum cpuhp_state prev_state) } st->bringup = bringup; -if (cpu_dying (st->cpu) != !bringup) -set_cpu_dying (st->cpu, !bringup); +if (cpu_dying (cpu) != !bringup) +set_cpu_dying (cpu, !bringup); }/* Regular hotplug invocation of the AP hotplug thread */
@@ -540,15 +540,16 @@ static void __cpuhp_kick_ap(struct cpuhp_cpu_state *st)wait_for_ap_thread (st, st->bringup); } -static int cpuhp_kick_ap (struct cpuhp_cpu_state *st,enum cpuhp_state target) +static int cpuhp_kick_ap (int cpu,struct cpuhp_cpu_state *st, +enum cpuhp_state target) {enum cpuhp_state prev_state;int ret; - prev_state =cpuhp_set_state (st, target); + prev_state =cpuhp_set_state (cpu, st, target);__cpuhp_kick_ap (st);if ((ret = st->result)) { -cpuhp_reset_state (st, prev_state); +cpuhp_reset_state (cpu, st, prev_state);__cpuhp_kick_ap (st); }
@@ -580,7 +581,7 @@ static int bringup_wait_for_ap(unsigned int cpu)if (st->target <=CPUHP_AP_ONLINE_IDLE )return 0 ; -return cpuhp_kick_ap (st, st->target); +return cpuhp_kick_ap (cpu, st, st->target); }static int bringup_cpu (unsigned int cpu)
@@ -703,7 +704,7 @@ static int cpuhp_up_callbacks(unsigned int cpu, struct cpuhp_cpu_state *st, ret, cpu,cpuhp_get_step (st->state)->name, st->state); -cpuhp_reset_state (st, prev_state); +cpuhp_reset_state (cpu, st, prev_state);if (can_rollback_cpu (st))WARN_ON (cpuhp_invoke_callback_range (false, cpu, st, prev_state));
@@ -720,7 +721,6 @@ static void cpuhp_create(unsigned int cpu)init_completion (&st->done_up);init_completion (&st->done_down); - st->cpu = cpu; }static int cpuhp_should_run (unsigned int cpu)
@@ -874,7 +874,7 @@ static int cpuhp_kick_ap_work(unsigned int cpu)cpuhp_lock_release (true);trace_cpuhp_enter (cpu, st->target, prev_state, cpuhp_kick_ap_work); - ret =cpuhp_kick_ap (st, st->target); + ret =cpuhp_kick_ap (cpu, st, st->target);trace_cpuhp_exit (cpu, st->state, prev_state, ret);return ret;
@@ -1106,7 +1106,7 @@ static int cpuhp_down_callbacks(unsigned int cpu, struct cpuhp_cpu_state *st, ret, cpu,cpuhp_get_step (st->state)->name, st->state); -cpuhp_reset_state (st, prev_state); +cpuhp_reset_state (cpu, st, prev_state);if (st->state < prev_state) WARN_ON(cpuhp_invoke_callback_range(true, cpu, st,
@@ -1133,7 +1133,7 @@ static int __ref _cpu_down(unsigned int cpu, int tasks_frozen, cpuhp_tasks_frozen = tasks_frozen; - prev_state =cpuhp_set_state (st, target); + prev_state =cpuhp_set_state (cpu, st, target);/* * If the current CPU state is in the range of the AP hotplug thread, * then we need to kick the thread.
@@ -1164,7 +1164,7 @@ static int __ref _cpu_down(unsigned int cpu, int tasks_frozen, ret =cpuhp_down_callbacks (cpu, st, target);if (ret && st->state < prev_state) {if (st->state ==CPUHP_TEARDOWN_CPU ) { -cpuhp_reset_state (st, prev_state); +cpuhp_reset_state (cpu, st, prev_state);__cpuhp_kick_ap (st); }else {WARN (1 ,"DEAD callback error for CPU%d" , cpu);
@@ -1351,7 +1351,7 @@ static int _cpu_up(unsigned int cpu, int tasks_frozen, enum cpuhp_state target) cpuhp_tasks_frozen = tasks_frozen; -cpuhp_set_state (st, target); +cpuhp_set_state (cpu, st, target);/* * If the current CPU state is in the range of the AP hotplug thread, * then we need to kick the thread once more.
Signature · 1 line
2.25.1
[tip: smp/urgent] cpu/hotplug: Remove the 'cpu' member of cpuhp_cpu_state
The following commit has been merged into the smp/urgent branch of tip:
The following commit has been merged into the smp/urgent branch of tip:
Commit-ID: acd508a1f8ab96e76ab4ec0e5679b60be0999cd2 Gitweb: https://git.kernel.org/tip/acd508a1f8ab96e76ab4ec0e5679b60be0999cd2 Author: Steven Price <[email protected]> AuthorDate: Mon, 11 Apr 2022 16:22:32 +01:00 Committer: Thomas Gleixner <[email protected]> CommitterDate: Wed, 13 Apr 2022 21:22:08 +02:00
cpu/hotplug: Remove the 'cpu' member of cpuhp_cpu_state
Currently the setting of the 'cpu' member of struct cpuhp_cpu_state in cpuhp_create() is too late as it is used earlier in _cpu_up().
If kzalloc_node() in __smpboot_create_thread() fails then the rollback will be done with st->cpu==0 causing CPU0 to be erroneously set to be dying, causing the scheduler to get mightily confused and throw its toys out of the pram.
However the cpu number is actually available directly, so simply remove the 'cpu' member and avoid the problem in the first place.
--- kernel/cpu.c | 35 ++++++++++++++++++----------------- 1 file changed, 18 insertions(+), 17 deletions(-)
kernel/cpu.c +18 -17
@@ -71,7 +71,6 @@ struct cpuhp_cpu_state {bool rollback;bool single;bool bringup; -int cpu;struct hlist_node *node;struct hlist_node *last;enum cpuhp_state cb_state;
@@ -475,7 +474,7 @@ static inline bool cpu_smt_allowed(unsigned int cpu) { return true; }#endif static inline enum cpuhp_state -cpuhp_set_state (struct cpuhp_cpu_state *st,enum cpuhp_state target) +cpuhp_set_state (int cpu,struct cpuhp_cpu_state *st,enum cpuhp_state target) {enum cpuhp_state prev_state = st->state;bool bringup = st->state < target;
@@ -486,14 +485,15 @@ cpuhp_set_state(struct cpuhp_cpu_state *st, enum cpuhp_state target) st->target = target; st->single = false; st->bringup = bringup; -if (cpu_dying (st->cpu) != !bringup) -set_cpu_dying (st->cpu, !bringup); +if (cpu_dying (cpu) != !bringup) +set_cpu_dying (cpu, !bringup);return prev_state; }static inline void -cpuhp_reset_state (struct cpuhp_cpu_state *st,enum cpuhp_state prev_state) +cpuhp_reset_state (int cpu,struct cpuhp_cpu_state *st, +enum cpuhp_state prev_state) {bool bringup = !st->bringup;
@@ -520,8 +520,8 @@ cpuhp_reset_state(struct cpuhp_cpu_state *st, enum cpuhp_state prev_state) } st->bringup = bringup; -if (cpu_dying (st->cpu) != !bringup) -set_cpu_dying (st->cpu, !bringup); +if (cpu_dying (cpu) != !bringup) +set_cpu_dying (cpu, !bringup); }/* Regular hotplug invocation of the AP hotplug thread */
@@ -541,15 +541,16 @@ static void __cpuhp_kick_ap(struct cpuhp_cpu_state *st)wait_for_ap_thread (st, st->bringup); } -static int cpuhp_kick_ap (struct cpuhp_cpu_state *st,enum cpuhp_state target) +static int cpuhp_kick_ap (int cpu,struct cpuhp_cpu_state *st, +enum cpuhp_state target) {enum cpuhp_state prev_state;int ret; - prev_state =cpuhp_set_state (st, target); + prev_state =cpuhp_set_state (cpu, st, target);__cpuhp_kick_ap (st);if ((ret = st->result)) { -cpuhp_reset_state (st, prev_state); +cpuhp_reset_state (cpu, st, prev_state);__cpuhp_kick_ap (st); }
@@ -581,7 +582,7 @@ static int bringup_wait_for_ap(unsigned int cpu)if (st->target <=CPUHP_AP_ONLINE_IDLE )return 0 ; -return cpuhp_kick_ap (st, st->target); +return cpuhp_kick_ap (cpu, st, st->target); }static int bringup_cpu (unsigned int cpu)
@@ -704,7 +705,7 @@ static int cpuhp_up_callbacks(unsigned int cpu, struct cpuhp_cpu_state *st, ret, cpu,cpuhp_get_step (st->state)->name, st->state); -cpuhp_reset_state (st, prev_state); +cpuhp_reset_state (cpu, st, prev_state);if (can_rollback_cpu (st))WARN_ON (cpuhp_invoke_callback_range (false, cpu, st, prev_state));
@@ -875,7 +876,7 @@ static int cpuhp_kick_ap_work(unsigned int cpu)cpuhp_lock_release (true);trace_cpuhp_enter (cpu, st->target, prev_state, cpuhp_kick_ap_work); - ret =cpuhp_kick_ap (st, st->target); + ret =cpuhp_kick_ap (cpu, st, st->target);trace_cpuhp_exit (cpu, st->state, prev_state, ret);return ret;
@@ -1107,7 +1108,7 @@ static int cpuhp_down_callbacks(unsigned int cpu, struct cpuhp_cpu_state *st, ret, cpu,cpuhp_get_step (st->state)->name, st->state); -cpuhp_reset_state (st, prev_state); +cpuhp_reset_state (cpu, st, prev_state);if (st->state < prev_state) WARN_ON(cpuhp_invoke_callback_range(true, cpu, st,
@@ -1134,7 +1135,7 @@ static int __ref _cpu_down(unsigned int cpu, int tasks_frozen, cpuhp_tasks_frozen = tasks_frozen; - prev_state =cpuhp_set_state (st, target); + prev_state =cpuhp_set_state (cpu, st, target);/* * If the current CPU state is in the range of the AP hotplug thread, * then we need to kick the thread.
@@ -1165,7 +1166,7 @@ static int __ref _cpu_down(unsigned int cpu, int tasks_frozen, ret =cpuhp_down_callbacks (cpu, st, target);if (ret && st->state < prev_state) {if (st->state ==CPUHP_TEARDOWN_CPU ) { -cpuhp_reset_state (st, prev_state); +cpuhp_reset_state (cpu, st, prev_state);__cpuhp_kick_ap (st); }else {WARN (1 ,"DEAD callback error for CPU%d" , cpu);
@@ -1352,7 +1353,7 @@ static int _cpu_up(unsigned int cpu, int tasks_frozen, enum cpuhp_state target) cpuhp_tasks_frozen = tasks_frozen; -cpuhp_set_state (st, target); +cpuhp_set_state (cpu, st, target);/* * If the current CPU state is in the range of the AP hotplug thread, * then we need to kick the thread once more.
[tip: smp/core] cpu/hotplug: Remove the 'cpu' member of cpuhp_cpu_state
In reply to Steven PriceThe following commit has been merged into the smp/core branch of tip:
The following commit has been merged into the smp/core branch of tip:
Commit-ID: b7ba6d8dc3569e49800ef0136799f26f43e237e8 Gitweb: https://git.kernel.org/tip/b7ba6d8dc3569e49800ef0136799f26f43e237e8 Author: Steven Price <[email protected]> AuthorDate: Mon, 11 Apr 2022 16:22:32 +01:00 Committer: Thomas Gleixner <[email protected]> CommitterDate: Wed, 13 Apr 2022 21:25:40 +02:00
cpu/hotplug: Remove the 'cpu' member of cpuhp_cpu_state
Currently the setting of the 'cpu' member of struct cpuhp_cpu_state in cpuhp_create() is too late as it is used earlier in _cpu_up().
If kzalloc_node() in __smpboot_create_thread() fails then the rollback will be done with st->cpu==0 causing CPU0 to be erroneously set to be dying, causing the scheduler to get mightily confused and throw its toys out of the pram.
However the cpu number is actually available directly, so simply remove the 'cpu' member and avoid the problem in the first place.
--- kernel/cpu.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-)
kernel/cpu.c +18 -18
@@ -71,7 +71,6 @@ struct cpuhp_cpu_state {bool rollback;bool single;bool bringup; -int cpu;struct hlist_node *node;struct hlist_node *last;enum cpuhp_state cb_state;
@@ -475,7 +474,7 @@ static inline bool cpu_smt_allowed(unsigned int cpu) { return true; }#endif static inline enum cpuhp_state -cpuhp_set_state (struct cpuhp_cpu_state *st,enum cpuhp_state target) +cpuhp_set_state (int cpu,struct cpuhp_cpu_state *st,enum cpuhp_state target) {enum cpuhp_state prev_state = st->state;bool bringup = st->state < target;
@@ -486,14 +485,15 @@ cpuhp_set_state(struct cpuhp_cpu_state *st, enum cpuhp_state target) st->target = target; st->single = false; st->bringup = bringup; -if (cpu_dying (st->cpu) != !bringup) -set_cpu_dying (st->cpu, !bringup); +if (cpu_dying (cpu) != !bringup) +set_cpu_dying (cpu, !bringup);return prev_state; }static inline void -cpuhp_reset_state (struct cpuhp_cpu_state *st,enum cpuhp_state prev_state) +cpuhp_reset_state (int cpu,struct cpuhp_cpu_state *st, +enum cpuhp_state prev_state) {bool bringup = !st->bringup;
@@ -520,8 +520,8 @@ cpuhp_reset_state(struct cpuhp_cpu_state *st, enum cpuhp_state prev_state) } st->bringup = bringup; -if (cpu_dying (st->cpu) != !bringup) -set_cpu_dying (st->cpu, !bringup); +if (cpu_dying (cpu) != !bringup) +set_cpu_dying (cpu, !bringup); }/* Regular hotplug invocation of the AP hotplug thread */
@@ -541,15 +541,16 @@ static void __cpuhp_kick_ap(struct cpuhp_cpu_state *st)wait_for_ap_thread (st, st->bringup); } -static int cpuhp_kick_ap (struct cpuhp_cpu_state *st,enum cpuhp_state target) +static int cpuhp_kick_ap (int cpu,struct cpuhp_cpu_state *st, +enum cpuhp_state target) {enum cpuhp_state prev_state;int ret; - prev_state =cpuhp_set_state (st, target); + prev_state =cpuhp_set_state (cpu, st, target);__cpuhp_kick_ap (st);if ((ret = st->result)) { -cpuhp_reset_state (st, prev_state); +cpuhp_reset_state (cpu, st, prev_state);__cpuhp_kick_ap (st); }
@@ -581,7 +582,7 @@ static int bringup_wait_for_ap(unsigned int cpu)if (st->target <=CPUHP_AP_ONLINE_IDLE )return 0 ; -return cpuhp_kick_ap (st, st->target); +return cpuhp_kick_ap (cpu, st, st->target); }static int bringup_cpu (unsigned int cpu)
@@ -704,7 +705,7 @@ static int cpuhp_up_callbacks(unsigned int cpu, struct cpuhp_cpu_state *st, ret, cpu,cpuhp_get_step (st->state)->name, st->state); -cpuhp_reset_state (st, prev_state); +cpuhp_reset_state (cpu, st, prev_state);if (can_rollback_cpu (st))WARN_ON (cpuhp_invoke_callback_range (false, cpu, st, prev_state));
@@ -721,7 +722,6 @@ static void cpuhp_create(unsigned int cpu)init_completion (&st->done_up);init_completion (&st->done_down); - st->cpu = cpu; }static int cpuhp_should_run (unsigned int cpu)
@@ -875,7 +875,7 @@ static int cpuhp_kick_ap_work(unsigned int cpu)cpuhp_lock_release (true);trace_cpuhp_enter (cpu, st->target, prev_state, cpuhp_kick_ap_work); - ret =cpuhp_kick_ap (st, st->target); + ret =cpuhp_kick_ap (cpu, st, st->target);trace_cpuhp_exit (cpu, st->state, prev_state, ret);return ret;
@@ -1107,7 +1107,7 @@ static int cpuhp_down_callbacks(unsigned int cpu, struct cpuhp_cpu_state *st, ret, cpu,cpuhp_get_step (st->state)->name, st->state); -cpuhp_reset_state (st, prev_state); +cpuhp_reset_state (cpu, st, prev_state);if (st->state < prev_state) WARN_ON(cpuhp_invoke_callback_range(true, cpu, st,
@@ -1134,7 +1134,7 @@ static int __ref _cpu_down(unsigned int cpu, int tasks_frozen, cpuhp_tasks_frozen = tasks_frozen; - prev_state =cpuhp_set_state (st, target); + prev_state =cpuhp_set_state (cpu, st, target);/* * If the current CPU state is in the range of the AP hotplug thread, * then we need to kick the thread.
@@ -1165,7 +1165,7 @@ static int __ref _cpu_down(unsigned int cpu, int tasks_frozen, ret =cpuhp_down_callbacks (cpu, st, target);if (ret && st->state < prev_state) {if (st->state ==CPUHP_TEARDOWN_CPU ) { -cpuhp_reset_state (st, prev_state); +cpuhp_reset_state (cpu, st, prev_state);__cpuhp_kick_ap (st); }else {WARN (1 ,"DEAD callback error for CPU%d" , cpu);
@@ -1352,7 +1352,7 @@ static int _cpu_up(unsigned int cpu, int tasks_frozen, enum cpuhp_state target) cpuhp_tasks_frozen = tasks_frozen; -cpuhp_set_state (st, target); +cpuhp_set_state (cpu, st, target);/* * If the current CPU state is in the range of the AP hotplug thread, * then we need to kick the thread once more.
PATCH v3 2/2 cpu/hotplug: Initialise all cpuhp_cpu_state structs earlier
In reply to Steven PriceRather than waiting until a CPU is first brought online, do the initialisation of the cpuhp_cpu_state structure for each CPU during the __init phase. This saves a (small) amount of non-__init memory and avoids potential confusion about when the cpuhp_cpu_state struct is valid.
--- kernel/cpu.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-)
kernel/cpu.c +13 -9
@@ -715,14 +715,6 @@ static int cpuhp_up_callbacks(unsigned int cpu, struct cpuhp_cpu_state *st,/* * The cpu hotplug threads manage the bringup and teardown of the cpus */ -static void cpuhp_create (unsigned int cpu) -{ -struct cpuhp_cpu_state *st =per_cpu_ptr (&cpuhp_state, cpu); - -init_completion (&st->done_up); -init_completion (&st->done_down); -} -static int cpuhp_should_run (unsigned int cpu) {struct cpuhp_cpu_state *st =this_cpu_ptr (&cpuhp_state);
@@ -882,15 +874,27 @@ static int cpuhp_kick_ap_work(unsigned int cpu)static struct smp_hotplug_thread cpuhp_threads = { .store = &cpuhp_state.thread, - .create = &cpuhp_create, .thread_should_run = cpuhp_should_run, .thread_fn = cpuhp_thread_fun, .thread_comm ="cpuhp/%u" , .selfparking = true, }; +static __init void cpuhp_init_state (void ) +{ +struct cpuhp_cpu_state *st; +int cpu; + +for_each_possible_cpu (cpu) { + st =per_cpu_ptr (&cpuhp_state, cpu); +init_completion (&st->done_up); +init_completion (&st->done_down); + } +} +void __init cpuhp_threads_init (void ) { +cpuhp_init_state ();BUG_ON (smpboot_register_percpu_thread (&cpuhp_threads));kthread_unpark (this_cpu_read (cpuhp_state.thread)); }
Signature · 1 line
2.25.1
[tip: smp/core] cpu/hotplug: Initialise all cpuhp_cpu_state structs earlier
The following commit has been merged into the smp/core branch of tip:
The following commit has been merged into the smp/core branch of tip:
Commit-ID: d308077e5e4dc8c93f97f5ebc70274e7c7a92d49 Gitweb: https://git.kernel.org/tip/d308077e5e4dc8c93f97f5ebc70274e7c7a92d49 Author: Steven Price <[email protected]> AuthorDate: Mon, 11 Apr 2022 16:22:33 +01:00 Committer: Thomas Gleixner <[email protected]> CommitterDate: Wed, 13 Apr 2022 21:27:41 +02:00
cpu/hotplug: Initialise all cpuhp_cpu_state structs earlier
Rather than waiting until a CPU is first brought online, do the initialisation of the cpuhp_cpu_state structure for each CPU during the __init phase. This saves a (small) amount of non-__init memory and avoids potential confusion about when the cpuhp_cpu_state struct is valid.
--- kernel/cpu.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-)
kernel/cpu.c +13 -9
@@ -716,14 +716,6 @@ static int cpuhp_up_callbacks(unsigned int cpu, struct cpuhp_cpu_state *st,/* * The cpu hotplug threads manage the bringup and teardown of the cpus */ -static void cpuhp_create (unsigned int cpu) -{ -struct cpuhp_cpu_state *st =per_cpu_ptr (&cpuhp_state, cpu); - -init_completion (&st->done_up); -init_completion (&st->done_down); -} -static int cpuhp_should_run (unsigned int cpu) {struct cpuhp_cpu_state *st =this_cpu_ptr (&cpuhp_state);
@@ -883,15 +875,27 @@ static int cpuhp_kick_ap_work(unsigned int cpu)static struct smp_hotplug_thread cpuhp_threads = { .store = &cpuhp_state.thread, - .create = &cpuhp_create, .thread_should_run = cpuhp_should_run, .thread_fn = cpuhp_thread_fun, .thread_comm ="cpuhp/%u" , .selfparking = true, }; +static __init void cpuhp_init_state (void ) +{ +struct cpuhp_cpu_state *st; +int cpu; + +for_each_possible_cpu (cpu) { + st =per_cpu_ptr (&cpuhp_state, cpu); +init_completion (&st->done_up); +init_completion (&st->done_down); + } +} +void __init cpuhp_threads_init (void ) { +cpuhp_init_state ();BUG_ON (smpboot_register_percpu_thread (&cpuhp_threads));kthread_unpark (this_cpu_read (cpuhp_state.thread)); }