net: ftgmac100: access hardware register after clock ready
Subsystems (2)
PATCH 1/1 net: ftgmac100: access hardware register after clock ready
AST2600 MAC register 0x58 is writable only when the MAC clock is enabled. Usually, the MAC clock is enabled by the bootloader so register 0x58 is set normally when the bootloader is involved. To make ast2600 ftgmac100 work without the bootloader, postpone the register write until the clock is ready.
--- drivers/net/ethernet/faraday/ftgmac100.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/net/ethernet/faraday/ftgmac100.c +5 -5
@@ -1835,11 +1835,6 @@ static int ftgmac100_probe(struct platform_device *pdev) priv->rxdes0_edorr_mask =BIT (30 ); priv->txdes0_edotr_mask =BIT (30 ); priv->is_aspeed = true; -/* Disable ast2600 problematic HW arbitration */ -if (of_device_is_compatible (np,"aspeed,ast2600-mac" )) { -iowrite32 (FTGMAC100_TM_DEFAULT , - priv->base +FTGMAC100_OFFSET_TM ); - } }else { priv->rxdes0_edorr_mask =BIT (15 ); priv->txdes0_edotr_mask =BIT (15 );
@@ -1911,6 +1906,11 @@ static int ftgmac100_probe(struct platform_device *pdev) err =ftgmac100_setup_clk (priv);if (err) goto err_phy_connect; + +/* Disable ast2600 problematic HW arbitration */ +if (of_device_is_compatible (np,"aspeed,ast2600-mac" )) +iowrite32 (FTGMAC100_TM_DEFAULT , + priv->base +FTGMAC100_OFFSET_TM ); }/* Default ring sizes */
Signature · 1 line
2.25.1
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:
Quoted 10 lines · On Tue, 12 Apr 2022 19:48:59 +0800 you wrote:
AST2600 MAC register
0x58is writable only when the MAC clock is enabled. Usually, the MAC clock is enabled by the bootloader so register0x58is set normally when the bootloader is involved. To make ast2600 ftgmac100 work without the bootloader, postpone the register write until the clock is ready.Fixes 137d23cea1c0 ("net: ftgmac100: Fix Aspeed ast2600 TX hang issue")Signed-off-by Dylan Hung <[email protected]>[...]
Here is the summary with links:
- net: ftgmac100: access hardware register after clock ready
https://git.kernel.org/netdev/net/c/3d2504524531
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html