Skip to contentSkip to conversation

ARM: dts: net: dwc_eth_qos: Fix i.MX8MP compatible string

PATCH In review Marek Vasut 5 participants 5 messages Feb 26, 2022 – Apr 12, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: net: dwc_eth_qos: Fix i.MX8MP compatible string

The correct compatible string for i.MX8MP variant of DWC EQoS MAC is "nxp,imx8mp-dwmac-eqos", use it. Drop the two current users of the current wrong compatible string to avoid breaking them.

Cc Fabio Estevam <[email protected]>
Cc Marcel Ziswiler <[email protected]>
Cc Peng Fan <[email protected]>
Cc Stefano Babic <[email protected]>
---
 arch/arm/dts/imx8mp-evk-u-boot.dtsi    | 1 -
 arch/arm/dts/imx8mp-verdin-u-boot.dtsi | 1 -
 drivers/net/dwc_eth_qos.c              | 2 +-
 3 files changed, 1 insertion(+), 3 deletions(-)
arch/arm/dts/imx8mp-evk-u-boot.dtsi +0 -1
index ab849ebaaca..7c3789273da 100644
@@ -112,7 +112,6 @@
 };
 
 &eqos {
-	compatible = "fsl,imx-eqos";
 	/delete-property/ assigned-clocks;
 	/delete-property/ assigned-clock-parents;
 	/delete-property/ assigned-clock-rates;
arch/arm/dts/imx8mp-verdin-u-boot.dtsi +0 -1
index a57ad45ed63..26140a79ebe 100644
@@ -30,7 +30,6 @@
 };
 
 &eqos {
-	compatible = "fsl,imx-eqos";
 	/delete-property/ assigned-clocks;
 	/delete-property/ assigned-clock-parents;
 	/delete-property/ assigned-clock-rates;
drivers/net/dwc_eth_qos.c +1 -1
index 22dad5b2030..ea0c2cfa5b2 100644
@@ -2032,7 +2032,7 @@ static const struct udevice_id eqos_ids[] = {
 #endif
 #if IS_ENABLED(CONFIG_DWC_ETH_QOS_IMX)
 	{
-		.compatible = "fsl,imx-eqos",
+		.compatible = "nxp,imx8mp-dwmac-eqos",
 		.data = (ulong)&eqos_imx_config
 	},
 #endif
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw

Hi Marek,

Quoted 3 lines · Marek Vasut

The correct compatible string for i.MX8MP variant of DWC EQoS MAC is "nxp,imx8mp-dwmac-eqos", use it. Drop the two current users of the current wrong compatible string to avoid breaking them.

Yes, "nxp,imx8mp-dwmac-eqos" is the documented property in the upstream kernel:

Tested-by on v1 1/1
#2 lore raw
In reply to Marek Vasut
Quoted 3 lines · Marek Vasut

The correct compatible string for i.MX8MP variant of DWC EQoS MAC is "nxp,imx8mp-dwmac-eqos", use it. Drop the two current users of the current wrong compatible string to avoid breaking them.

Thanks, Marek, for fixing this.

Quoted 1 line
Quoted 47 lines
Cc Fabio Estevam <[email protected]>
Cc Marcel Ziswiler <[email protected]>
Cc Peng Fan <[email protected]>
Cc Stefano Babic <[email protected]>

---
 arch/arm/dts/imx8mp-evk-u-boot.dtsi    | 1 -
 arch/arm/dts/imx8mp-verdin-u-boot.dtsi | 1 -
 drivers/net/dwc_eth_qos.c              | 2 +-

 3 files changed, 1 insertion(+), 3 deletions(-)
arch/arm/dts/imx8mp-evk-u-boot.dtsi +0 -0
index ab849ebaaca..7c3789273da 100644
@@ -112,7 +112,6 @@
  };


 &eqos {
-       compatible = "fsl,imx-eqos";
        /delete-property/ assigned-clocks;
        /delete-property/ assigned-clock-parents;
        /delete-property/ assigned-clock-rates;

arch/arm/dts/imx8mp-verdin-u-boot.dtsi +0 -0
index a57ad45ed63..26140a79ebe 100644
@@ -30,7 +30,6 @@
  };


 &eqos {
-       compatible = "fsl,imx-eqos";
        /delete-property/ assigned-clocks;
        /delete-property/ assigned-clock-parents;
        /delete-property/ assigned-clock-rates;

drivers/net/dwc_eth_qos.c +1 -1
index 22dad5b2030..ea0c2cfa5b2 100644
@@ -2032,7 +2032,7 @@ static const struct udevice_id eqos_ids[] = {
  #endif
  #if IS_ENABLED(CONFIG_DWC_ETH_QOS_IMX)
         {
-               .compatible = "fsl,imx-eqos",
+               .compatible = "nxp,imx8mp-dwmac-eqos",

                .data = (ulong)&eqos_imx_config
        },
 #endif

Reviewed-by
#3 lore raw
Quoted 51 lines · Marcel Ziswiler
Quoted 3 lines · Marek Vasut

The correct compatible string for i.MX8MP variant of DWC EQoS MAC is "nxp,imx8mp-dwmac-eqos", use it. Drop the two current users of the current wrong compatible string to avoid breaking them.

Thanks, Marek, for fixing this.

Quoted 1 line
Quoted 39 lines
Cc Fabio Estevam <[email protected]>
Cc Marcel Ziswiler <[email protected]>
Cc Peng Fan <[email protected]>
Cc Stefano Babic <[email protected]>
---
 arch/arm/dts/imx8mp-evk-u-boot.dtsi    | 1 -
 arch/arm/dts/imx8mp-verdin-u-boot.dtsi | 1 -
 drivers/net/dwc_eth_qos.c              | 2 +-
 3 files changed, 1 insertion(+), 3 deletions(-)
arch/arm/dts/imx8mp-evk-u-boot.dtsi +0 -1
index ab849ebaaca..7c3789273da 100644
@@ -112,7 +112,6 @@
 };
 
 &eqos {
-       compatible = "fsl,imx-eqos";
        /delete-property/ assigned-clocks;
        /delete-property/ assigned-clock-parents;
        /delete-property/ assigned-clock-rates;
arch/arm/dts/imx8mp-verdin-u-boot.dtsi +0 -1
index a57ad45ed63..26140a79ebe 100644
@@ -30,7 +30,6 @@
 };
 
 &eqos {
-       compatible = "fsl,imx-eqos";
        /delete-property/ assigned-clocks;
        /delete-property/ assigned-clock-parents;
        /delete-property/ assigned-clock-rates;
drivers/net/dwc_eth_qos.c +0 -0
index 22dad5b2030..ea0c2cfa5b2 100644
@@ -2032,7 +2032,7 @@ static const struct udevice_id eqos_ids[] = {
Quoted 8 lines

drivers/net/dwc_eth_qos.c static const struct udevice_id eqos_ids[] = { · line 2038

Quoted 8 lines
drivers/net/dwc_eth_qos.c +1 -1
 #endif
 #if IS_ENABLED(CONFIG_DWC_ETH_QOS_IMX)
        {
-               .compatible = "fsl,imx-eqos",
+               .compatible = "nxp,imx8mp-dwmac-eqos",
                .data = (ulong)&eqos_imx_config
        },
 #endif
#4 lore raw

PATCH 1/1 ARM: dts: net: dwc_eth_qos: Fix i.MX8MP compatible string

In reply to Marek Vasut
Quoted 11 lines

The correct compatible string for i.MX8MP variant of DWC EQoS MAC is "nxp,imx8mp-dwmac-eqos", use it. Drop the two current users of the current wrong compatible string to avoid breaking them.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================