Skip to contentSkip to conversation

arm: imx: imx8mm_beacon: Remove unnecessary configs

PATCH In review Adam Ford 3 participants 6 messages Mar 19, 2022 – Apr 12, 2022 Arm i.MX and Layerscape

lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/2 arm: imx: imx8mm_beacon: Remove unnecessary configs

Because the Beacon imx8mm board uses device tree for MMC/SD and Ethernet, there is no need to have some of the config options. It's handled by the device tree.

include/configs/imx8mm_beacon.h +0 -10
index e4805951fa..7c17f14964 100644
@@ -99,14 +99,4 @@
 #define CONFIG_SYS_BARGSIZE		CONFIG_SYS_CBSIZE
 #define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + \
 					sizeof(CONFIG_SYS_PROMPT) + 16)
-
-/* USDHC */
-#define CONFIG_SYS_FSL_USDHC_NUM	2
-#define CONFIG_SYS_FSL_ESDHC_ADDR	0
-
-/* FEC*/
-#define CONFIG_FEC_MXC_PHYADDR          0
-#define FEC_QUIRK_ENET_MAC
-#define IMX_FEC_BASE			0x30BE0000
-
 #endif
Signature · 1 line
2.34.1
author
#1 lore raw

PATCH 2/2 arm: imx: imx8mn_beacon: Remove unnecessary configs

Because the Beacon imx8mn board uses device tree for MMC/SD and Ethernet, there is no need to have some of the config options. It's handled by the device tree.

include/configs/imx8mn_beacon.h +0 -12
index 7fed9a38c1..41ce3c1c8c 100644
@@ -115,16 +115,4 @@
 #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
 #define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + \
 					sizeof(CONFIG_SYS_PROMPT) + 16)
-
-/* USDHC */
-#define CONFIG_SYS_FSL_USDHC_NUM	2
-#define CONFIG_SYS_FSL_ESDHC_ADDR	0
-
-/* ENET Config */
-#if defined(CONFIG_FEC_MXC)
-#define CONFIG_FEC_MXC_PHYADDR	0
-#define FEC_QUIRK_ENET_MAC
-#define IMX_FEC_BASE			0x30BE0000
-#endif /* CONFIG_FEC_MXC */
-
 #endif
Signature · 1 line
2.34.1
#3 lore raw

PATCH 2/2 arm: imx: imx8mn_beacon: Remove unnecessary configs

In reply to Adam Ford
Quoted 16 lines

Because the Beacon imx8mn board uses device tree for MMC/SD and Ethernet, there is no need to have some of the config options. It's handled by the device tree.

include/configs/imx8mn_beacon.h +0 -3
index 7fed9a38c1..41ce3c1c8c 100644
@@ -115,16 +115,4 @@
 #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
 #define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + \
 					sizeof(CONFIG_SYS_PROMPT) + 16)
-
-/* USDHC */
-#define CONFIG_SYS_FSL_USDHC_NUM	2

include/configs/imx8mn_beacon.h line 118

Quoted 10 lines
include/configs/imx8mn_beacon.h +0 -9
-#define CONFIG_SYS_FSL_ESDHC_ADDR	0
-
-/* ENET Config */
-#if defined(CONFIG_FEC_MXC)
-#define CONFIG_FEC_MXC_PHYADDR	0
-#define FEC_QUIRK_ENET_MAC
-#define IMX_FEC_BASE			0x30BE0000
-#endif /* CONFIG_FEC_MXC */
-
 #endif

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
#5 lore raw

PATCH 1/2 arm: imx: imx8mm_beacon: Remove unnecessary configs

In reply to Adam Ford
Quoted 14 lines

Because the Beacon imx8mm board uses device tree for MMC/SD and Ethernet, there is no need to have some of the config options. It's handled by the device tree.

include/configs/imx8mm_beacon.h +0 -1
index e4805951fa..7c17f14964 100644
@@ -99,14 +99,4 @@
 #define CONFIG_SYS_BARGSIZE		CONFIG_SYS_CBSIZE
 #define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + \
 					sizeof(CONFIG_SYS_PROMPT) + 16)
-

include/configs/imx8mm_beacon.h line 102

Quoted 10 lines
include/configs/imx8mm_beacon.h +0 -9
-/* USDHC */
-#define CONFIG_SYS_FSL_USDHC_NUM	2
-#define CONFIG_SYS_FSL_ESDHC_ADDR	0
-
-/* FEC*/
-#define CONFIG_FEC_MXC_PHYADDR          0
-#define FEC_QUIRK_ENET_MAC
-#define IMX_FEC_BASE			0x30BE0000
-
 #endif

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================