include: configs: *imx8*: remove IMX_FEC_BASE
PATCH 1/1 include: configs: *imx8*: remove IMX_FEC_BASE
The IMX_FEC_BASE value is not used when CONFIG_DM_ETH is configured. So this value can be removed.
--- include/configs/imx8mm-cl-iot-gate.h | 2 -- include/configs/imx8mm_beacon.h | 1 - include/configs/imx8mm_evk.h | 2 -- include/configs/imx8mm_venice.h | 1 - include/configs/imx8mn_beacon.h | 1 - include/configs/imx8mq_evk.h | 2 -- include/configs/imx8mq_phanbell.h | 2 -- include/configs/imx8ulp_evk.h | 2 -- include/configs/kontron_pitx_imx8m.h | 1 - include/configs/pico-imx8mq.h | 2 -- include/configs/verdin-imx8mm.h | 1 - 11 files changed, 17 deletions(-)
include/configs/imx8mm-cl-iot-gate.h +0 -2
@@ -157,8 +157,6 @@#define CONFIG_FEC_MXC_PHYADDR 0#define FEC_QUIRK_ENET_MAC -#define IMX_FEC_BASE 0x30BE0000 -/* USB Configs */ #define CONFIG_EHCI_HCD_INIT_AFTER_RESET #define CONFIG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW)
include/configs/imx8mm_beacon.h +0 -1
@@ -109,6 +109,5 @@#define CONFIG_FEC_XCV_TYPE RGMII#define CONFIG_FEC_MXC_PHYADDR 0#define FEC_QUIRK_ENET_MAC -#define IMX_FEC_BASE 0x30BE0000#endif
include/configs/imx8mm_evk.h +0 -2
@@ -89,6 +89,4 @@#define CONFIG_FEC_MXC_PHYADDR 0#define FEC_QUIRK_ENET_MAC -#define IMX_FEC_BASE 0x30BE0000 -#endif
include/configs/imx8mm_venice.h +0 -1
@@ -109,6 +109,5 @@#define CONFIG_FEC_XCV_TYPE RGMII#define CONFIG_FEC_MXC_PHYADDR 0#define FEC_QUIRK_ENET_MAC -#define IMX_FEC_BASE 0x30BE0000#endif
include/configs/imx8mn_beacon.h +0 -1
@@ -126,7 +126,6 @@#define CONFIG_FEC_XCV_TYPE RGMII#define CONFIG_FEC_MXC_PHYADDR 0#define FEC_QUIRK_ENET_MAC -#define IMX_FEC_BASE 0x30BE0000#endif /* CONFIG_FEC_MXC */ #endif
include/configs/imx8mq_evk.h +0 -2
@@ -43,8 +43,6 @@#define CONFIG_FEC_XCV_TYPE RGMII#define CONFIG_FEC_MXC_PHYADDR 0#define FEC_QUIRK_ENET_MAC - -#define IMX_FEC_BASE 0x30BE0000#endif #ifndef CONFIG_SPL_BUILD
include/configs/imx8mq_phanbell.h +0 -2
@@ -37,8 +37,6 @@#define CONFIG_FEC_XCV_TYPE RGMII#define CONFIG_FEC_MXC_PHYADDR 0#define FEC_QUIRK_ENET_MAC - -#define IMX_FEC_BASE 0x30BE0000#endif #define CONFIG_MFG_ENV_SETTINGS \
include/configs/imx8ulp_evk.h +0 -2
@@ -34,8 +34,6 @@#define CONFIG_FEC_XCV_TYPE RMII#define CONFIG_FEC_MXC_PHYADDR 1 - -#define IMX_FEC_BASE 0x29950000#endif #ifdef CONFIG_DISTRO_DEFAULTS
include/configs/kontron_pitx_imx8m.h +0 -1
@@ -43,7 +43,6 @@#define CONFIG_FEC_MXC_PHYADDR 0#define FEC_QUIRK_ENET_MAC -#define IMX_FEC_BASE 0x30BE0000#define PHY_ANEG_TIMEOUT 20000#endif
include/configs/pico-imx8mq.h +0 -2
@@ -37,8 +37,6 @@#define CONFIG_FEC_XCV_TYPE RGMII#define CONFIG_FEC_MXC_PHYADDR 1#define FEC_QUIRK_ENET_MAC - -#define IMX_FEC_BASE 0x30BE0000#endif /* Initial environment variables */
include/configs/verdin-imx8mm.h +0 -1
@@ -107,7 +107,6 @@#define CONFIG_FEC_XCV_TYPE RGMII#define CONFIG_FEC_MXC_PHYADDR 7#define FEC_QUIRK_ENET_MAC -#define IMX_FEC_BASE 0x30BE0000/* USB Configs */ #define CONFIG_EHCI_HCD_INIT_AFTER_RESET
Signature · 1 line
2.20.1
Quoted 154 lines · Heiko Thiery
The
IMX_FEC_BASEvalue is not used whenCONFIG_DM_ETHis configured. So this value can be removed.Signed-off-by Heiko Thiery <[email protected]>--- include/configs/imx8mm-cl-iot-gate.h | 2 -- include/configs/imx8mm_beacon.h | 1 - include/configs/imx8mm_evk.h | 2 -- include/configs/imx8mm_venice.h | 1 - include/configs/imx8mn_beacon.h | 1 - include/configs/imx8mq_evk.h | 2 -- include/configs/imx8mq_phanbell.h | 2 -- include/configs/imx8ulp_evk.h | 2 -- include/configs/kontron_pitx_imx8m.h | 1 - include/configs/pico-imx8mq.h | 2 -- include/configs/verdin-imx8mm.h | 1 - 11 files changed, 17 deletions(-)include/configs/imx8mm-cl-iot-gate.h +0
-2@@ -157,8 +157,6 @@#define CONFIG_FEC_MXC_PHYADDR 0#define FEC_QUIRK_ENET_MAC -#define IMX_FEC_BASE 0x30BE0000 -/* USB Configs */ #define CONFIG_EHCI_HCD_INIT_AFTER_RESET #define CONFIG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW)include/configs/imx8mm_beacon.h +0
-1@@ -109,6 +109,5 @@#define CONFIG_FEC_XCV_TYPE RGMII#define CONFIG_FEC_MXC_PHYADDR 0#define FEC_QUIRK_ENET_MAC -#define IMX_FEC_BASE 0x30BE0000#endif include/configs/imx8mm_evk.h +0
-2@@ -89,6 +89,4 @@#define CONFIG_FEC_MXC_PHYADDR 0#define FEC_QUIRK_ENET_MAC -#define IMX_FEC_BASE 0x30BE0000 -#endif include/configs/imx8mm_venice.h +0
-1@@ -109,6 +109,5 @@#define CONFIG_FEC_XCV_TYPE RGMII#define CONFIG_FEC_MXC_PHYADDR 0#define FEC_QUIRK_ENET_MAC -#define IMX_FEC_BASE 0x30BE0000#endif include/configs/imx8mn_beacon.h +0
-1@@ -126,7 +126,6 @@#define CONFIG_FEC_XCV_TYPE RGMII#define CONFIG_FEC_MXC_PHYADDR 0#define FEC_QUIRK_ENET_MAC -#define IMX_FEC_BASE 0x30BE0000#endif /* CONFIG_FEC_MXC */ #endif include/configs/imx8mq_evk.h +0
-2@@ -43,8 +43,6 @@#define CONFIG_FEC_XCV_TYPE RGMII#define CONFIG_FEC_MXC_PHYADDR 0#define FEC_QUIRK_ENET_MAC - -#define IMX_FEC_BASE 0x30BE0000#endif #ifndef CONFIG_SPL_BUILD include/configs/imx8mq_phanbell.h +0
-2@@ -37,8 +37,6 @@#define CONFIG_FEC_XCV_TYPE RGMII#define CONFIG_FEC_MXC_PHYADDR 0#define FEC_QUIRK_ENET_MAC - -#define IMX_FEC_BASE 0x30BE0000#endif #define CONFIG_MFG_ENV_SETTINGS \include/configs/imx8ulp_evk.h +0
-2@@ -34,8 +34,6 @@#define CONFIG_FEC_XCV_TYPE RMII#define CONFIG_FEC_MXC_PHYADDR 1 - -#define IMX_FEC_BASE 0x29950000#endif #ifdef CONFIG_DISTRO_DEFAULTS include/configs/kontron_pitx_imx8m.h +0
-1@@ -43,7 +43,6 @@#define CONFIG_FEC_MXC_PHYADDR 0#define FEC_QUIRK_ENET_MAC -#define IMX_FEC_BASE 0x30BE0000#define PHY_ANEG_TIMEOUT 20000#endif include/configs/pico-imx8mq.h +0
-2@@ -37,8 +37,6 @@#define CONFIG_FEC_XCV_TYPE RGMII#define CONFIG_FEC_MXC_PHYADDR 1#define FEC_QUIRK_ENET_MAC - -#define IMX_FEC_BASE 0x30BE0000#endif /* Initial environment variables */ include/configs/verdin-imx8mm.h +0
-2@@ -107,7 +107,6 @@#define CONFIG_FEC_XCV_TYPE RGMII#define CONFIG_FEC_MXC_PHYADDR 7#define FEC_QUIRK_ENET_MAC -#define IMX_FEC_BASE 0x30BE0000/* USB Configs */ #define CONFIG_EHCI_HCD_INIT_AFTER_RESET --
Quoted 2 lines
2.20.1
Heiko,
Thanks for the cleanup!
Best Regards,
Tim
Hi Heiko,
Quoted 5 lines · Heiko Thiery
The
IMX_FEC_BASEvalue is not used whenCONFIG_DM_ETHis configured. So this value can be removed.Signed-off-by Heiko Thiery <[email protected]>
Thanks for doing this:
Quoted 9 lines · Heiko Thiery
The
IMX_FEC_BASEvalue is not used whenCONFIG_DM_ETHis configured. So this value can be removed.Signed-off-by Heiko Thiery <[email protected]>---
include/configs/imx8mm-cl-iot-gate.h | 2 --
include/configs/imx8mm_beacon.h | 1 -
include/configs/imx8mm_evk.h | 2 --
include/configs/imx8mm_venice.h | 1 -
Looks good. However, Tim already did this for the venice [1] which is why it no longer applies cleanly.
With that fixed.
[1] https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
Quoted 143 lines
include/configs/imx8mn_beacon.h | 1 -
include/configs/imx8mq_evk.h | 2 --
include/configs/imx8mq_phanbell.h | 2 --
include/configs/imx8ulp_evk.h | 2 --
include/configs/kontron_pitx_imx8m.h | 1 -
include/configs/pico-imx8mq.h | 2 --
include/configs/verdin-imx8mm.h | 1 -11 files changed, 17 deletions(-)include/configs/imx8mm-cl-iot-gate.h +0
-0@@ -157,8 +157,6 @@ #define CONFIG_FEC_MXC_PHYADDR 0 #define FEC_QUIRK_ENET_MACinclude/configs/imx8mm-cl-iot-gate.h +0
-2-#define IMX_FEC_BASE 0x30BE0000 -/* USB Configs */
#defineCONFIG_EHCI_HCD_INIT_AFTER_RESET
#define CONFIG_MXC_USB_PORTSC (PORT_PTS_UTMI |PORT_PTS_PTW)include/configs/imx8mm_beacon.h +0
-1@@ -109,6 +109,5 @@ #define CONFIG_FEC_XCV_TYPE RGMII #define CONFIG_FEC_MXC_PHYADDR 0 #define FEC_QUIRK_ENET_MAC -#define IMX_FEC_BASE 0x30BE0000
#endifinclude/configs/imx8mm_evk.h +0
-0@@ -89,6 +89,4 @@ #define CONFIG_FEC_MXC_PHYADDR 0 #define FEC_QUIRK_ENET_MACinclude/configs/imx8mm_evk.h +0
-2-#define IMX_FEC_BASE 0x30BE0000 -#endif
include/configs/imx8mm_venice.h +0
-1@@ -109,6 +109,5 @@ #define CONFIG_FEC_XCV_TYPE RGMII #define CONFIG_FEC_MXC_PHYADDR 0 #define FEC_QUIRK_ENET_MAC -#define IMX_FEC_BASE 0x30BE0000
#endifinclude/configs/imx8mn_beacon.h +0
-1@@ -126,7 +126,6 @@ #define CONFIG_FEC_XCV_TYPE RGMII #define CONFIG_FEC_MXC_PHYADDR 0 #define FEC_QUIRK_ENET_MAC -#define IMX_FEC_BASE 0x30BE0000 #endif /* CONFIG_FEC_MXC */
#endifinclude/configs/imx8mq_evk.h +0
-2@@ -43,8 +43,6 @@ #define CONFIG_FEC_XCV_TYPE RGMII #define CONFIG_FEC_MXC_PHYADDR 0 #define FEC_QUIRK_ENET_MAC - -#define IMX_FEC_BASE 0x30BE0000 #endif
#ifndefCONFIG_SPL_BUILDinclude/configs/imx8mq_phanbell.h +0
-2@@ -37,8 +37,6 @@ #define CONFIG_FEC_XCV_TYPE RGMII #define CONFIG_FEC_MXC_PHYADDR 0 #define FEC_QUIRK_ENET_MAC - -#define IMX_FEC_BASE 0x30BE0000 #endif
#defineCONFIG_MFG_ENV_SETTINGS\include/configs/imx8ulp_evk.h +0
-0@@ -34,8 +34,6 @@
#define CONFIG_FEC_XCV_TYPE RMII
#define CONFIG_FEC_MXC_PHYADDR 1include/configs/imx8ulp_evk.h +0
-2- -#define IMX_FEC_BASE 0x29950000#endif
#ifdefCONFIG_DISTRO_DEFAULTSinclude/configs/kontron_pitx_imx8m.h +0
-0@@ -43,7 +43,6 @@ #define CONFIG_FEC_MXC_PHYADDR 0 #define FEC_QUIRK_ENET_MAC
-#define IMX_FEC_BASE 0x30BE0000 #define PHY_ANEG_TIMEOUT 20000
#endifinclude/configs/pico-imx8mq.h +0
-2@@ -37,8 +37,6 @@ #define CONFIG_FEC_XCV_TYPE RGMII #define CONFIG_FEC_MXC_PHYADDR 1 #define FEC_QUIRK_ENET_MAC - -#define IMX_FEC_BASE 0x30BE0000 #endif
/* Initial environment variables */include/configs/verdin-imx8mm.h +0
-1@@ -107,7 +107,6 @@ #define CONFIG_FEC_XCV_TYPE RGMII #define CONFIG_FEC_MXC_PHYADDR 7 #define FEC_QUIRK_ENET_MAC -#define IMX_FEC_BASE 0x30BE0000
/* USB Configs */
#defineCONFIG_EHCI_HCD_INIT_AFTER_RESET
PATCH 1/1 include: configs: *imx8*: remove IMX_FEC_BASE
In reply to Heiko ThieryQuoted 6 lines
The
IMX_FEC_BASEvalue is not used whenCONFIG_DM_ETHis configured. So this value can be removed.Signed-off-by Heiko Thiery <[email protected]>Reviewed-by Tim Harvey <[email protected]>Reviewed-by Fabio Estevam <[email protected]>Tested-by Marcel Ziswiler <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================