Asynchronous shutdown interface and example implementation
Subsystems (3)
v2 cover Asynchronous shutdown interface and example implementation
Problem:
Some of our machines are configured with many NVMe devices and are validated for strict shutdown time requirements. Each NVMe device plugged into the system, typicaly takes about 4.5 secs to shutdown. A system with 16 such NVMe devices will takes approximately 80 secs to shutdown and go through reboot.
The current shutdown APIs as defined at bus level is defined to be synchronous. Therefore, more devices are in the system the greater the time it takes to shutdown. This shutdown time significantly contributes the machine reboot time.
Solution:
This patch set proposes an asynchronous shutdown interface at bus level, modifies the core driver, device shutdown routine to exploit the new interface while maintaining backward compatibility with synchronous implementation already existing (Patch 1 of 3) and exploits new interface to enable all PCI-E based devices to use asynchronous interface semantics if necessary (Patch 2 of 3). The implementation at PCI-E level also works in a backward compatible way, to allow exiting device implementation to work with current synchronous semantics. Only show cases an example implementation for NVMe device to exploit this asynchronous shutdown interface. (Patch 3 of 3).
Changelog:
v2: - Replaced the shutdown_pre & shutdown_post entry point names with the
recommended names (async_shutdown_start and asynch_shutdown_end).
- Comment about ordering requirements between bridge shutdown versus leaf/endpoint shutdown was agreed to be different when calling async_shutdown_start and async_shutdown_end. Now this implements the same order of calling both start and end entry points.
Tanjore Suresh (3):
driver core: Support asynchronous driver shutdown
PCI: Support asynchronous shutdown
nvme: Add async shutdown support
drivers/base/core.c | 38 +++++++++++++++++- drivers/nvme/host/core.c | 28 +++++++++---- drivers/nvme/host/nvme.h | 8 ++++ drivers/nvme/host/pci.c | 80 ++++++++++++++++++++++++-------------- drivers/pci/pci-driver.c | 20 ++++++++-- include/linux/device/bus.h | 12 ++++++ include/linux/pci.h | 4 ++ 7 files changed, 149 insertions(+), 41 deletions(-)
Signature · 1 line
2.36.0.rc0.470.gd361397f0d-goog
PATCH v2 1/3 driver core: Support asynchronous driver shutdown
This changes the bus driver interface with additional entry points to enable devices to implement asynchronous shutdown. The existing synchronous interface to shutdown is unmodified and retained for backward compatibility.
This changes the common device shutdown code to enable devices to participate in asynchronous shutdown implementation.
--- drivers/base/core.c | 38 +++++++++++++++++++++++++++++++++++++- include/linux/device/bus.h | 12 ++++++++++++ 2 files changed, 49 insertions(+), 1 deletion(-)
drivers/base/core.c +37 -1
@@ -4479,6 +4479,7 @@ EXPORT_SYMBOL_GPL(device_change_owner);void device_shutdown (void ) {struct device *dev, *parent; +LIST_HEAD (async_shutdown_list);wait_for_device_probe ();device_block_probing ();
@@ -4523,7 +4524,13 @@ void device_shutdown(void)dev_info (dev,"shutdown_pre\n" ); dev->class->shutdown_pre (dev); } -if (dev->bus && dev->bus->shutdown) { +if (dev->bus && dev->bus->async_shutdown_start) { +if (initcall_debug) +dev_info (dev,"async_shutdown_start\n" ); + dev->bus->async_shutdown_start (dev); +list_add_tail (&dev->kobj.entry, + &async_shutdown_list); + }else if (dev->bus && dev->bus->shutdown) {if (initcall_debug)dev_info (dev,"shutdown\n" ); dev->bus->shutdown (dev);
@@ -4543,6 +4550,35 @@ void device_shutdown(void)spin_lock (&devices_kset->list_lock); }spin_unlock (&devices_kset->list_lock); + +/* +* Second pass spin for only devices, that have configured +* Asynchronous shutdown. +*/ +while (!list_empty (&async_shutdown_list)) { + dev = list_entry(async_shutdown_list.next, struct device, + kobj.entry); + parent =get_device (dev->parent); +get_device (dev); +/* +* Make sure the device is off the list +*/ +list_del_init (&dev->kobj.entry); +if (parent) +device_lock (parent); +device_lock (dev); +if (dev->bus && dev->bus->async_shutdown_end) { +if (initcall_debug) +dev_info (dev, +"async_shutdown_end called\n" ); + dev->bus->async_shutdown_end (dev); + } +device_unlock (dev); +if (parent) +device_unlock (parent); +put_device (dev); +put_device (parent); + } }/*
include/linux/device/bus.h +12 -0
@@ -49,6 +49,16 @@ struct fwnode_handle;* will never get called until they do. * @remove: Called when a device removed from this bus. * @shutdown: Called at shut-down time to quiesce the device. +* @async_shutdown_start: Called at the shutdown-time to start +* the shutdown process on the device. +* This entry point will be called only +* when the bus driver has indicated it would +* like to participate in asynchronous shutdown +* completion. +* @async_shutdown_end: Called at shutdown-time to complete the shutdown +* process of the device. This entry point will be called +* only when the bus drive has indicated it would like to +* participate in the asynchronous shutdown completion. * * @online: Called to put the device back online (after offlining it). * @offline: Called to put the device offline for hot-removal. May fail.
@@ -93,6 +103,8 @@ struct bus_type {void (*sync_state)(struct device *dev);void (*remove)(struct device *dev);void (*shutdown)(struct device *dev); +void (*async_shutdown_start)(struct device *dev); +void (*async_shutdown_end)(struct device *dev);int (*online)(struct device *dev);int (*offline)(struct device *dev);
Signature · 1 line
2.36.0.rc0.470.gd361397f0d-goog
PATCH v2 2/3 PCI: Support asynchronous shutdown
Enhances the base PCI driver to add support for asynchronous shutdown.
Assume a device takes n secs to shutdown. If a machine has been populated with M such devices, the total time spent in shutting down all the devices will be M * n secs, if the shutdown is done synchronously. For example, if NVMe PCI Controllers take 5 secs to shutdown and if there are 16 such NVMe controllers in a system, system will spend a total of 80 secs to shutdown all
NVMe devices in that system.
In order to speed up the shutdown time, asynchronous interface to shutdown has been implemented. This will significantly reduce the machine reboot time.
--- drivers/pci/pci-driver.c | 20 ++++++++++++++++---- include/linux/pci.h | 4 ++++ 2 files changed, 20 insertions(+), 4 deletions(-)
drivers/pci/pci-driver.c +16 -4
@@ -501,16 +501,28 @@ static void pci_device_remove(struct device *dev)pci_dev_put (pci_dev); } -static void pci_device_shutdown (struct device *dev) +static void pci_device_async_shutdown_start (struct device *dev) {struct pci_dev *pci_dev =to_pci_dev (dev);struct pci_driver *drv = pci_dev->driver;pm_runtime_resume (dev); -if (drv && drv->shutdown) +if (drv && drv->async_shutdown_start) + drv->async_shutdown_start (pci_dev); +else if (drv && drv->shutdown) drv->shutdown (pci_dev); +} + +static void pci_device_async_shutdown_end (struct device *dev) +{ +struct pci_dev *pci_dev =to_pci_dev (dev); +struct pci_driver *drv = pci_dev->driver; + +if (drv && drv->async_shutdown_end) + drv->async_shutdown_end (pci_dev); +/* * If this is a kexec reboot, turn off Bus Master bit on the * device to tell it to not continue to do DMA. Don't touch
@@ -521,7 +533,6 @@ static void pci_device_shutdown(struct device *dev)if (kexec_in_progress && (pci_dev->current_state <= PCI_D3hot))pci_clear_master (pci_dev); } -#ifdef CONFIG_PM /* Auxiliary functions used for system resume and run-time resume. */
@@ -1625,7 +1636,8 @@ struct bus_type pci_bus_type = { .uevent = pci_uevent, .probe = pci_device_probe, .remove = pci_device_remove, - .shutdown = pci_device_shutdown, + .async_shutdown_start = pci_device_async_shutdown_start, + .async_shutdown_end = pci_device_async_shutdown_end, .dev_groups = pci_dev_groups, .bus_groups = pci_bus_groups, .drv_groups = pci_drv_groups,
include/linux/pci.h +4 -0
@@ -881,6 +881,8 @@ struct module;* Useful for enabling wake-on-lan (NIC) or changing * the power state of a device before reboot. * e.g. drivers/net/e100.c. +* @async_shutdown_start: This starts the asynchronous shutdown +* @async_shutdown_end: This completes the started asynchronous shutdown * @sriov_configure: Optional driver callback to allow configuration of * number of VFs to enable via sysfs "sriov_numvfs" file. * @sriov_set_msix_vec_count: PF Driver callback to change number of MSI-X
@@ -905,6 +907,8 @@ struct pci_driver {int (*suspend)(struct pci_dev *dev,pm_message_t state);/* Device suspended */ int (*resume)(struct pci_dev *dev);/* Device woken up */ void (*shutdown)(struct pci_dev *dev); +void (*async_shutdown_start)(struct pci_dev *dev); +void (*async_shutdown_end)(struct pci_dev *dev);int (*sriov_configure)(struct pci_dev *dev,int num_vfs);/* On PF */ int (*sriov_set_msix_vec_count)(struct pci_dev *vf,int msix_vec_count);/* On PF */ u32 (*sriov_get_vf_total_msix)(struct pci_dev *pf);
Signature · 1 line
2.36.0.rc0.470.gd361397f0d-goog
PATCH v2 3/3 nvme: Add async shutdown support
This works with the asynchronous shutdown mechanism setup for the PCI drivers and participates to provide both pre and post shutdown routines at pci_driver structure level.
The shutdown_pre routine starts the shutdown and does not wait for the shutdown to complete. The shutdown_post routine waits for the shutdown to complete on individual controllers that this driver instance controls. This mechanism optimizes to speed up the shutdown in a system which host many controllers.
--- drivers/nvme/host/core.c | 28 ++++++++++---- drivers/nvme/host/nvme.h | 8 ++++ drivers/nvme/host/pci.c | 80 +++++++++++++++++++++++++--------------- 3 files changed, 80 insertions(+), 36 deletions(-)
drivers/nvme/host/core.c +21 -7
@@ -2173,16 +2173,30 @@ EXPORT_SYMBOL_GPL(nvme_enable_ctrl);int nvme_shutdown_ctrl (struct nvme_ctrl *ctrl) { -unsigned long timeout = jiffies + (ctrl->shutdown_timeout *HZ ); -u32 csts;int ret; + ret =nvme_shutdown_ctrl_start (ctrl); +if (ret) +return ret; +return nvme_wait_for_shutdown_cmpl (ctrl); +} +EXPORT_SYMBOL_GPL (nvme_shutdown_ctrl); + +int nvme_shutdown_ctrl_start (struct nvme_ctrl *ctrl) +{ + ctrl->ctrl_config &= ~NVME_CC_SHN_MASK ; ctrl->ctrl_config |=NVME_CC_SHN_NORMAL ; - ret = ctrl->ops->reg_write32 (ctrl,NVME_REG_CC , ctrl->ctrl_config); -if (ret) -return ret; +return ctrl->ops->reg_write32 (ctrl,NVME_REG_CC , ctrl->ctrl_config); +} +EXPORT_SYMBOL_GPL (nvme_shutdown_ctrl_start); + +int nvme_wait_for_shutdown_cmpl (struct nvme_ctrl *ctrl) +{ +unsigned long deadline = jiffies + (ctrl->shutdown_timeout *HZ ); +u32 csts; +int ret;while ((ret = ctrl->ops->reg_read32 (ctrl,NVME_REG_CSTS , &csts)) ==0 ) {if ((csts &NVME_CSTS_SHST_MASK ) ==NVME_CSTS_SHST_CMPLT )
@@ -2191,7 +2205,7 @@ int nvme_shutdown_ctrl(struct nvme_ctrl *ctrl)msleep (100 );if (fatal_signal_pending (current))return -EINTR ; -if (time_after (jiffies, timeout)) { +if (time_after (jiffies, deadline)) {dev_err (ctrl->device,"Device shutdown incomplete; abort shutdown\n" );return -ENODEV ;
@@ -2200,7 +2214,7 @@ int nvme_shutdown_ctrl(struct nvme_ctrl *ctrl)return ret; } -EXPORT_SYMBOL_GPL (nvme_shutdown_ctrl); +EXPORT_SYMBOL_GPL (nvme_wait_for_shutdown_cmpl);static int nvme_configure_timestamp (struct nvme_ctrl *ctrl) {
drivers/nvme/host/nvme.h +8 -0
@@ -170,6 +170,12 @@ enum { NVME_REQ_USERCMD = (1 << 1), }; +enum shutdown_type { +DO_NOT_SHUTDOWN =0 , +SHUTDOWN_TYPE_SYNC =1 , +SHUTDOWN_TYPE_ASYNC =2 , +}; +static inline struct nvme_request *nvme_req (struct request *req) {return blk_mq_rq_to_pdu (req);
@@ -672,6 +678,8 @@ bool nvme_wait_reset(struct nvme_ctrl *ctrl);int nvme_disable_ctrl (struct nvme_ctrl *ctrl);int nvme_enable_ctrl (struct nvme_ctrl *ctrl);int nvme_shutdown_ctrl (struct nvme_ctrl *ctrl); +int nvme_shutdown_ctrl_start (struct nvme_ctrl *ctrl); +int nvme_wait_for_shutdown_cmpl (struct nvme_ctrl *ctrl);int nvme_init_ctrl (struct nvme_ctrl *ctrl,struct device *dev,const struct nvme_ctrl_ops *ops,unsigned long quirks);void nvme_uninit_ctrl (struct nvme_ctrl *ctrl);
drivers/nvme/host/pci.c +51 -29
216 lines not on this page · raw message
Signature · 1 line
2.36.0.rc0.470.gd361397f0d-goog
Rafael J. Wysocki
maintainerRe: [PATCH v2 1/3] driver core: Support asynchronous driver shutdown
In reply to Tanjore SureshQuoted 10 lines · Tanjore Suresh
This changes the bus driver interface with additional entry points to enable devices to implement asynchronous shutdown. The existing synchronous interface to shutdown is unmodified and retained for backward compatibility.
This changes the common device shutdown code to enable devices to participate in asynchronous shutdown implementation.
Signed-off-by Tanjore Suresh <[email protected]>
Is there any specific reason why you didn't follow the design of, say, dpm_suspend(), where the "async" devices only need to have a flag set and the driver is not required to implement any new callbacks?
IMO having different driver interfaces for asynchronous suspend and shutdown would be quite confusing for driver developers, wouldn't it?
Quoted 101 lines
--- drivers/base/core.c | 38 +++++++++++++++++++++++++++++++++++++- include/linux/device/bus.h | 12 ++++++++++++ 2 files changed, 49 insertions(+), 1 deletion(-)drivers/base/core.c +37
-1@@ -4479,6 +4479,7 @@ EXPORT_SYMBOL_GPL(device_change_owner);void device_shutdown (void ) {struct device *dev, *parent; +LIST_HEAD (async_shutdown_list);wait_for_device_probe ();device_block_probing ();@@ -4523,7 +4524,13 @@ void device_shutdown(void)dev_info (dev,"shutdown_pre\n" ); dev->class->shutdown_pre (dev); } -if (dev->bus && dev->bus->shutdown) { +if (dev->bus && dev->bus->async_shutdown_start) { +if (initcall_debug) +dev_info (dev,"async_shutdown_start\n" ); + dev->bus->async_shutdown_start (dev); +list_add_tail (&dev->kobj.entry, + &async_shutdown_list); + }else if (dev->bus && dev->bus->shutdown) {if (initcall_debug)dev_info (dev,"shutdown\n" ); dev->bus->shutdown (dev);@@ -4543,6 +4550,35 @@ void device_shutdown(void)spin_lock (&devices_kset->list_lock); }spin_unlock (&devices_kset->list_lock); + +/* +* Second pass spin for only devices, that have configured +* Asynchronous shutdown. +*/ +while (!list_empty (&async_shutdown_list)) { + dev = list_entry(async_shutdown_list.next, struct device, + kobj.entry); + parent =get_device (dev->parent); +get_device (dev); +/* +* Make sure the device is off the list +*/ +list_del_init (&dev->kobj.entry); +if (parent) +device_lock (parent); +device_lock (dev); +if (dev->bus && dev->bus->async_shutdown_end) { +if (initcall_debug) +dev_info (dev, +"async_shutdown_end called\n" ); + dev->bus->async_shutdown_end (dev); + } +device_unlock (dev); +if (parent) +device_unlock (parent); +put_device (dev); +put_device (parent); + } }/* include/linux/device/bus.h +12
-1@@ -49,6 +49,16 @@ struct fwnode_handle;* will never get called until they do. * @remove: Called when a device removed from this bus. * @shutdown: Called at shut-down time to quiesce the device. +* @async_shutdown_start: Called at the shutdown-time to start +* the shutdown process on the device. +* This entry point will be called only +* when the bus driver has indicated it would +* like to participate in asynchronous shutdown +* completion. +* @async_shutdown_end: Called at shutdown-time to complete the shutdown +* process of the device. This entry point will be called +* only when the bus drive has indicated it would like to +* participate in the asynchronous shutdown completion. * * @online: Called to put the device back online (after offlining it). * @offline: Called to put the device offline for hot-removal. May fail. @@ -93,6 +103,8 @@ struct bus_type {void (*sync_state)(struct device *dev);void (*remove)(struct device *dev);void (*shutdown)(struct device *dev); +void (*async_shutdown_start)(struct device *dev); +void (*async_shutdown_end)(struct device *dev);int (*online)(struct device *dev);int (*offline)(struct device *dev); --2.36.0.rc0.470.gd361397f0d-goog
Re: [PATCH v2 1/3] driver core: Support asynchronous driver shutdown
Rafael,
That is a good observation, however, many of the use cases in data centers (deployment of devices in data centers) do not exploit device power management. Therefore, I'm not sure that is the right way to design this.
Also if you look into device_shutdown (drivers/base/core.c) generic kernel routine does not exploit the shutdown method suggested by you instead use the generic shutdown methods defined in bus, class, drivers structures. Therefore, adopting to expand on those generic shutdown interfaces is the incremental choice to not confuse driver developers.
Hope this clarifies why this extension is proposed when compared to overloading a generic shutdown entry point with device power management requirements.
Thanks
sureshtk
Quoted 121 lines · Rafael J. Wysocki
Quoted 10 lines · Tanjore Suresh
This changes the bus driver interface with additional entry points to enable devices to implement asynchronous shutdown. The existing synchronous interface to shutdown is unmodified and retained for backward compatibility.
This changes the common device shutdown code to enable devices to participate in asynchronous shutdown implementation.
Signed-off-by Tanjore Suresh <[email protected]>Is there any specific reason why you didn't follow the design of, say,
dpm_suspend(), where the "async" devices only need to have a flag set and the driver is not required to implement any new callbacks?IMO having different driver interfaces for asynchronous suspend and shutdown would be quite confusing for driver developers, wouldn't it?
Quoted 101 lines
--- drivers/base/core.c | 38 +++++++++++++++++++++++++++++++++++++- include/linux/device/bus.h | 12 ++++++++++++ 2 files changed, 49 insertions(+), 1 deletion(-)drivers/base/core.c +37
-1@@ -4479,6 +4479,7 @@ EXPORT_SYMBOL_GPL(device_change_owner);void device_shutdown (void ) {struct device *dev, *parent; +LIST_HEAD (async_shutdown_list);wait_for_device_probe ();device_block_probing ();@@ -4523,7 +4524,13 @@ void device_shutdown(void)dev_info (dev,"shutdown_pre\n" ); dev->class->shutdown_pre (dev); } -if (dev->bus && dev->bus->shutdown) { +if (dev->bus && dev->bus->async_shutdown_start) { +if (initcall_debug) +dev_info (dev,"async_shutdown_start\n" ); + dev->bus->async_shutdown_start (dev); +list_add_tail (&dev->kobj.entry, + &async_shutdown_list); + }else if (dev->bus && dev->bus->shutdown) {if (initcall_debug)dev_info (dev,"shutdown\n" ); dev->bus->shutdown (dev);@@ -4543,6 +4550,35 @@ void device_shutdown(void)spin_lock (&devices_kset->list_lock); }spin_unlock (&devices_kset->list_lock); + +/* +* Second pass spin for only devices, that have configured +* Asynchronous shutdown. +*/ +while (!list_empty (&async_shutdown_list)) { + dev = list_entry(async_shutdown_list.next, struct device, + kobj.entry); + parent =get_device (dev->parent); +get_device (dev); +/* +* Make sure the device is off the list +*/ +list_del_init (&dev->kobj.entry); +if (parent) +device_lock (parent); +device_lock (dev); +if (dev->bus && dev->bus->async_shutdown_end) { +if (initcall_debug) +dev_info (dev, +"async_shutdown_end called\n" ); + dev->bus->async_shutdown_end (dev); + } +device_unlock (dev); +if (parent) +device_unlock (parent); +put_device (dev); +put_device (parent); + } }/* include/linux/device/bus.h +12
-1@@ -49,6 +49,16 @@ struct fwnode_handle;* will never get called until they do. * @remove: Called when a device removed from this bus. * @shutdown: Called at shut-down time to quiesce the device. +* @async_shutdown_start: Called at the shutdown-time to start +* the shutdown process on the device. +* This entry point will be called only +* when the bus driver has indicated it would +* like to participate in asynchronous shutdown +* completion. +* @async_shutdown_end: Called at shutdown-time to complete the shutdown +* process of the device. This entry point will be called +* only when the bus drive has indicated it would like to +* participate in the asynchronous shutdown completion. * * @online: Called to put the device back online (after offlining it). * @offline: Called to put the device offline for hot-removal. May fail. @@ -93,6 +103,8 @@ struct bus_type {void (*sync_state)(struct device *dev);void (*remove)(struct device *dev);void (*shutdown)(struct device *dev); +void (*async_shutdown_start)(struct device *dev); +void (*async_shutdown_end)(struct device *dev);int (*online)(struct device *dev);int (*offline)(struct device *dev); --2.36.0.rc0.470.gd361397f0d-goog
Greg Kroah-Hartman
maintainerRe: [PATCH v2 1/3] driver core: Support asynchronous driver shutdown
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
Quoted 6 lines · Tanjore Suresh
Rafael,
That is a good observation, however, many of the use cases in data centers (deployment of devices in data centers) do not exploit device power management. Therefore, I'm not sure that is the right way to design this.
Yes it is, enable device power management and use that interface please. Devices in data centers should of course be doing the same thing as everyone else, as it actually saves real money in power costs. To not do so is very odd.
thanks,
greg k-h
Re: [PATCH v2 1/3] driver core: Support asynchronous driver shutdown
Quoted 21 lines · Greg Kroah-Hartman
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?A: No.
Q: Should I include quotations after my reply?http://daringfireball.net/2007/07/on_top
Quoted 6 lines · Tanjore Suresh
Rafael,
That is a good observation, however, many of the use cases in data centers (deployment of devices in data centers) do not exploit device power management. Therefore, I'm not sure that is the right way to design this.
Quoted 5 lines
Yes it is, enable device power management and use that interface please. Devices in data centers should of course be doing the same thing as everyone else, as it actually saves real money in power costs. To not do so is very odd.
I guess we are intermixing the terminology of device power management with shutdown.
My second, third reasoning in my previous e-mail, thought it brings out that difference. Maybe not.
I will try one more time, my thought process on this one.
This patch is only for shutdown. The shutdown can be done in a system in various flavors,
(this may include a power being pulled from the system components when all the devices
are quiescent and it can also be soft shutdown, where power is not removed from the system, but system
could be attempting a reboot)
The device power management allows the device to bring down any devices that may be idle to various power states that device may support in a selective manner & based on the transition allowed by the device. Such a transition initiated by
the system can be achieved using the 'dpm' interface for runtime power management (more for extending laptop battery life).
It can also be exploited for system sleep models (suspend and resume - where state is preserved and restarted from where it left off --> More applicable for laptops/desktops). That does not mean data center devices cannot exploit, but they worry about slight latency variation in any
I/O initiated to any device. Such power management could introduce more latency when it transitions from one state to another. Therefore, the use case is more apt for Laptops, in certain cases desktops in my opinion or understanding.
The shutdown entry point has been traditionally different and the semantics is that the whole system is going down to a quiescent state and power may be pulled or may not be, IMO, i am seeing both are independent requirements, in my view. Let me know if I am mistaken. I am not sure why we should break the shutdown semantics as understood by driver developers and overload it with dpm requirements?
Thanks
sureshtk
Quoted 3 lines
thanks,
greg k-h
Re: [PATCH v2 1/3] driver core: Support asynchronous driver shutdown
Greg
Quoted 60 lines · Tanjore Suresh
Quoted 21 lines · Greg Kroah-Hartman
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?A: No.
Q: Should I include quotations after my reply?http://daringfireball.net/2007/07/on_top
Quoted 6 lines · Tanjore Suresh
Rafael,
That is a good observation, however, many of the use cases in data centers (deployment of devices in data centers) do not exploit device power management. Therefore, I'm not sure that is the right way to design this.
Quoted 5 lines
Yes it is, enable device power management and use that interface please. Devices in data centers should of course be doing the same thing as everyone else, as it actually saves real money in power costs. To not do so is very odd.
I guess we are intermixing the terminology of device power management with shutdown.
My second, third reasoning in my previous e-mail, thought it brings out that difference. Maybe not.
I will try one more time, my thought process on this one.This patch is only for shutdown. The shutdown can be done in a system in various flavors,
(this may include a power being pulled from the system components when all the devices
are quiescent and it can also be soft shutdown, where power is not removed from the system, but system
could be attempting a reboot)The device power management allows the device to bring down any devices that may be idle to various power states that device may support in a selective manner & based on the transition allowed by the device. Such a transition initiated by
the system can be achieved using the 'dpm' interface for runtime power management (more for extending laptop battery life).
It can also be exploited for system sleep models (suspend and resume - where state is preserved and restarted from where it left off --> More applicable for laptops/desktops). That does not mean data center devices cannot exploit, but they worry about slight latency variation in any
I/O initiated to any device. Such power management could introduce more latency when it transitions from one state to another. Therefore, the use case is more apt for Laptops, in certain cases desktops in my opinion or understanding.
Quoted 8 lines
The shutdown entry point has been traditionally different and the semantics is that the whole system is going down to a quiescent state and power may be pulled or may not be, IMO, i am seeing both are independent requirements, in my view. Let me know if I am mistaken. I am not sure why we should break the shutdown semantics as understood by driver developers and overload it with dpm requirements?
I have not seen additional comments, I request your help in moving this further, please. If i have missed something, Please let me know.
Thanks
sureshtk
Quoted 7 lines
Thanks
sureshtkQuoted 3 lines
thanks,
greg k-h
Greg Kroah-Hartman
maintainerRe: [PATCH v2 1/3] driver core: Support asynchronous driver shutdown
Quoted 72 lines · Tanjore Suresh
Greg
Quoted 60 lines · Tanjore Suresh
Quoted 21 lines · Greg Kroah-Hartman
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?A: No.
Q: Should I include quotations after my reply?http://daringfireball.net/2007/07/on_top
Quoted 6 lines · Tanjore Suresh
Rafael,
That is a good observation, however, many of the use cases in data centers (deployment of devices in data centers) do not exploit device power management. Therefore, I'm not sure that is the right way to design this.
Quoted 5 lines
Yes it is, enable device power management and use that interface please. Devices in data centers should of course be doing the same thing as everyone else, as it actually saves real money in power costs. To not do so is very odd.
I guess we are intermixing the terminology of device power management with shutdown.
My second, third reasoning in my previous e-mail, thought it brings out that difference. Maybe not.
I will try one more time, my thought process on this one.This patch is only for shutdown. The shutdown can be done in a system in various flavors,
(this may include a power being pulled from the system components when all the devices
are quiescent and it can also be soft shutdown, where power is not removed from the system, but system
could be attempting a reboot)The device power management allows the device to bring down any devices that may be idle to various power states that device may support in a selective manner & based on the transition allowed by the device. Such a transition initiated by
the system can be achieved using the 'dpm' interface for runtime power management (more for extending laptop battery life).
It can also be exploited for system sleep models (suspend and resume - where state is preserved and restarted from where it left off --> More applicable for laptops/desktops). That does not mean data center devices cannot exploit, but they worry about slight latency variation in any
I/O initiated to any device. Such power management could introduce more latency when it transitions from one state to another. Therefore, the use case is more apt for Laptops, in certain cases desktops in my opinion or understanding.Quoted 8 lines
The shutdown entry point has been traditionally different and the semantics is that the whole system is going down to a quiescent state and power may be pulled or may not be, IMO, i am seeing both are independent requirements, in my view. Let me know if I am mistaken. I am not sure why we should break the shutdown semantics as understood by driver developers and overload it with dpm requirements?
Quoted 3 lines
I have not seen additional comments, I request your help in moving this further, please. If i have missed something, Please let me know.
Please rebase and resubmit your series with the extra information you have provided here in the changelog text so we can review it again. The patch series is long gone from my queue, sorry.
thanks,
greg k-h
A message that is not in the archive (sent off-list or not yet received): CALVARr6GNk=LCLaeaW87=UKPz+LtJFnuXbARkH44R+vs3E3S-Q@mail.gmail.com
Greg Kroah-Hartman
maintainerQuoted 1 line · Tanjore Suresh
Hey,
Please never top-post.
Quoted 2 lines
I did not hear any comments on this v2 version. Please help me with your comments and approval so that this can be prepared for checkin.
Relax, it is in my to-review queue...
There is no rush here.
greg k-h
Greg Kroah-Hartman
maintainerQuoted 4 lines · Tanjore Suresh
Hey,
I did not hear any comments on this v2 version. Please help me with your comments and approval so that this can be prepared for checkin.
Wait, there was comments, that you seem to have ignored. Why?
Greg Kroah-Hartman
maintainerQuoted 8 lines · Greg Kroah-Hartman
Quoted 4 lines · Tanjore Suresh
Hey,
I did not hear any comments on this v2 version. Please help me with your comments and approval so that this can be prepared for checkin.
Wait, there was comments, that you seem to have ignored. Why?
Because of that, this patch series is dropped on my end. Please fix up and resubmit a new version if you still want this.
thanks,
greg k-h
A message that is not in the archive (sent off-list or not yet received): CALVARr7Ms7+jL3EyTNNRaOB6co0ycWQtCWCDU+0zVjOnKEuK7g@mail.gmail.com
Greg Kroah-Hartman
maintainerA: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
Quoted 1 line · Tanjore Suresh
Greg,
<snip>
You sent this in html form, which is rejected by our mailing lists. Please fix up your email client and resend and I will be glad to point you at this thread on lore.kernel.org with responses from other developers. Or you can just look it up yourself :)
thanks,
greg k-h