ksmbd: increment reference count of parent fp
Subsystems (2)
Namjae Jeon
maintainerPATCH RESEND 1/1 ksmbd: increment reference count of parent fp
Add missing increment reference count of parent fp in ksmbd_lookup_fd_inode().
Signed-off-by Namjae Jeon <[email protected]>
--- fs/ksmbd/smb2pdu.c | 2 ++ fs/ksmbd/vfs_cache.c | 1 + 2 files changed, 3 insertions(+)
fs/ksmbd/smb2pdu.c +2 -0
@@ -5758,8 +5758,10 @@ static int set_rename_info(struct ksmbd_work *work, struct ksmbd_file *fp,if (parent_fp) {if (parent_fp->daccess &FILE_DELETE_LE ) {pr_err ("parent dir is opened with delete access\n" ); +ksmbd_fd_put (work, parent_fp);return -ESHARE ; } +ksmbd_fd_put (work, parent_fp); } next: return smb2_rename(work, fp, user_ns, rename_info,
fs/ksmbd/vfs_cache.c +1 -0
@@ -496,6 +496,7 @@ struct ksmbd_file *ksmbd_lookup_fd_inode(struct inode *inode)list_for_each_entry (lfp, &ci->m_fp_list, node) {if (inode ==file_inode (lfp->filp)) {atomic_dec (&ci->m_count); + lfp =ksmbd_fp_get (lfp);read_unlock (&ci->m_lock);return lfp; }
Signature · 1 line
2.25.1
2022년 4월 13일 (수) 오전 7:57, Namjae Jeon <[email protected]>님이 작성:
Quoted 6 lines
Add missing increment reference count of parent fp in
ksmbd_lookup_fd_inode().Signed-off-by Namjae Jeon <[email protected]>---
Looks good to me.
Reviewed-by Hyunchul Lee <[email protected]>
Quoted 34 lines
fs/ksmbd/smb2pdu.c | 2 ++ fs/ksmbd/vfs_cache.c | 1 + 2 files changed, 3 insertions(+)fs/ksmbd/smb2pdu.c +2
-0@@ -5758,8 +5758,10 @@ static int set_rename_info(struct ksmbd_work *work, struct ksmbd_file *fp,if (parent_fp) {if (parent_fp->daccess &FILE_DELETE_LE ) {pr_err ("parent dir is opened with delete access\n" ); +ksmbd_fd_put (work, parent_fp);return -ESHARE ; } +ksmbd_fd_put (work, parent_fp); } next: return smb2_rename(work, fp, user_ns, rename_info,fs/ksmbd/vfs_cache.c +1
-1@@ -496,6 +496,7 @@ struct ksmbd_file *ksmbd_lookup_fd_inode(struct inode *inode)list_for_each_entry (lfp, &ci->m_fp_list, node) {if (inode ==file_inode (lfp->filp)) {atomic_dec (&ci->m_count); + lfp =ksmbd_fp_get (lfp);read_unlock (&ci->m_lock);return lfp; } --2.25.1
Signature · 2 lines
Thanks, Hyunchul