dt-bindings: hwmon: ti,tmp421: Fix type for 'ti,n-factor'
Subsystems (2)
Rob Herring
maintainerPATCH 1/1 dt-bindings: hwmon: ti,tmp421: Fix type for 'ti,n-factor'
'ti,n-factor' is read as a 32-bit signed value, so the type and constraints are wrong. The same property is also defined for ti,tmp464 and is correct.
The constraints should also not be under 'items' as this property is not an array.
--- Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml +3 -4
@@ -58,10 +58,9 @@ patternProperties: description: | The value (two's complement) to be programmed in the channel specific N correction register. For remote channels only. - $ref: /schemas/types.yaml#/definitions/uint32 - items: - minimum: 0 - maximum: 255 + $ref: /schemas/types.yaml#/definitions/int32 + minimum: -128 + maximum: 127 required: - reg
Signature · 1 line
2.32.0
Quoted 6 lines · Rob Herring
'ti,n-factor' is read as a 32-bit signed value, so the type and constraints are wrong. The same property is also defined for ti,tmp464 and is correct.
The constraints should also not be under 'items' as this property is not an array.
Best regards,
Krzysztof
Quoted 11 lines · Rob Herring
'ti,n-factor' is read as a 32-bit signed value, so the type and constraints are wrong. The same property is also defined for ti,tmp464 and is correct.
The constraints should also not be under 'items' as this property is not an array.
Cc Jean Delvare <[email protected]>Cc Guenter Roeck <[email protected]>Cc Krzysztof Kozlowski <[email protected]>Signed-off-by Rob Herring <[email protected]>
Applied.
Thanks,
Guenter
Quoted 22 lines
--- Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml +3
-4@@ -58,10 +58,9 @@ patternProperties: description: | The value (two's complement) to be programmed in the channel specific N correction register. For remote channels only. - $ref: /schemas/types.yaml#/definitions/uint32 - items: - minimum: 0 - maximum: 255 + $ref: /schemas/types.yaml#/definitions/int32 + minimum: -128 + maximum: 127 required: - reg