Skip to contentSkip to conversation

slimbus: qcom: Remove unnecessary print function dev_err()

PATCH In review Yang Li 2 participants 2 messages Apr 14, 2022 – Apr 19, 2022

Subsystems (2)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 slimbus: qcom: Remove unnecessary print function dev_err()

The print function dev_err() is redundant because platform_get_irq_byname() already prints an error.

Eliminate the follow coccicheck warning:
./drivers/slimbus/qcom-ctrl.c:514:2-9: line 514 is redundant because platform_get_irq() already prints an error

---
 drivers/slimbus/qcom-ctrl.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/slimbus/qcom-ctrl.c +1 -3
index ec58091fc948..c0c4f895d76e 100644
@@ -510,10 +510,8 @@ static int qcom_slim_probe(struct platform_device *pdev)
 	}
 
 	ctrl->irq = platform_get_irq(pdev, 0);
-	if (ctrl->irq < 0) {
-		dev_err(&pdev->dev, "no slimbus IRQ\n");
+	if (ctrl->irq < 0)
 		return ctrl->irq;
-	}
 
 	sctrl = &ctrl->ctrl;
 	sctrl->dev = &pdev->dev;
Signature · 1 line
2.20.1.7.g153144c
#1 lore raw
Quoted 9 lines · Yang Li

The print function dev_err() is redundant because platform_get_irq_byname() already prints an error.

Eliminate the follow coccicheck warning:
./drivers/slimbus/qcom-ctrl.c:514:2-9: line 514 is redundant because platform_get_irq() already prints an error

Applied thanks,

--srini

Quoted 20 lines
---
  drivers/slimbus/qcom-ctrl.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
drivers/slimbus/qcom-ctrl.c +1 -3
index ec58091fc948..c0c4f895d76e 100644
@@ -510,10 +510,8 @@ static int qcom_slim_probe(struct platform_device *pdev)
  	}
 
  	ctrl->irq = platform_get_irq(pdev, 0);
-	if (ctrl->irq < 0) {
-		dev_err(&pdev->dev, "no slimbus IRQ\n");
+	if (ctrl->irq < 0)
  		return ctrl->irq;
-	}
 
  	sctrl = &ctrl->ctrl;
  	sctrl->dev = &pdev->dev;