Skip to contentSkip to conversation

drivers/hid/hid-lenovo: make read-only array tp10ubkbd_led static const

PATCH New Colin Ian King 1 participant 1 message Apr 14, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/hid/hid-lenovo: make read-only array tp10ubkbd_led static const

Don't populate the read-only array tp10ubkbd_led on the stack but instead make it static const. Also makes the object code a little smaller.

---
 drivers/hid/hid-lenovo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/hid-lenovo.c +1 -1
index 93b1f935e526..c7b25a67ab09 100644
@@ -835,7 +835,7 @@ static int lenovo_led_brightness_set(struct led_classdev *led_cdev,
 	struct device *dev = led_cdev->dev->parent;
 	struct hid_device *hdev = to_hid_device(dev);
 	struct lenovo_drvdata *data_pointer = hid_get_drvdata(hdev);
-	u8 tp10ubkbd_led[] = { TP10UBKBD_MUTE_LED, TP10UBKBD_MICMUTE_LED };
+	static const u8 tp10ubkbd_led[] = { TP10UBKBD_MUTE_LED, TP10UBKBD_MICMUTE_LED };
 	int led_nr = 0;
 	int ret = 0;
 
Signature · 1 line
2.35.1