KVM: selftests: Silence compiler warning in the kvm_page_table_test
PATCH 1/1 KVM: selftests: Silence compiler warning in the kvm_page_table_test
When compiling kvm_page_table_test.c, I get this compiler warning with gcc 11.2:
kvm_page_table_test.c: In function 'pre_init_before_test':../../../../tools/include/linux/kernel.h:44:24: warning: comparison of
distinct pointer types lacks a cast
44 | (void) (&_max1 == &_max2); \
| ^~
kvm_page_table_test.c:281:21: note: in expansion of macro 'max'
281 | alignment = max(0x100000, alignment);
| ^~~
Fix it by adjusting the type of the absolute value.
--- tools/testing/selftests/kvm/kvm_page_table_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/kvm/kvm_page_table_test.c +1 -1
@@ -278,7 +278,7 @@ static struct kvm_vm *pre_init_before_test(enum vm_guest_mode mode, void *arg)else guest_test_phys_mem = p->phys_offset;#ifdef __s390x__ - alignment =max (0x100000 , alignment); + alignment =max (0x100000UL , alignment);#endif guest_test_phys_mem =align_down (guest_test_phys_mem, alignment);
Signature · 1 line
2.27.0
Quoted 12 lines · On Thu, 14 Apr 2022 12:30:31 +0200 Thomas Huth <[email protected]> wrote:
When compiling
kvm_page_table_test.c, I get this compiler warning with gcc 11.2:
kvm_page_table_test.c: In function 'pre_init_before_test':../../../../tools/include/linux/kernel.h:44:24: warning: comparison of
distinct pointer types lacks a cast
44 | (void) (&_max1==&_max2); \
| ^~
kvm_page_table_test.c:281:21: note: in expansion of macro 'max'
281 | alignment =max(0x100000, alignment);
| ^~~
Quoted 3 lines
Fix it by adjusting the type of the absolute value.
Signed-off-by Thomas Huth <[email protected]>
Quoted 17 lines
--- tools/testing/selftests/kvm/kvm_page_table_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/testing/selftests/kvm/kvm_page_table_test.c +1
-1@@ -278,7 +278,7 @@ static struct kvm_vm *pre_init_before_test(enum vm_guest_mode mode, void *arg)else guest_test_phys_mem = p->phys_offset;#ifdef __s390x__ - alignment =max (0x100000 , alignment); + alignment =max (0x100000UL , alignment);#endif guest_test_phys_mem =align_down (guest_test_phys_mem, alignment);
Queued, thanks.
Paolo