ARM: dts: aspeed: add Delta AHE-50DC BMC
PATCH 1/1 ARM: dts: aspeed: add Delta AHE-50DC BMC
The Delta AHE-50DC Open19 power shelf uses a pair of AST1250 BMCs that are mostly compatible with the existing ast2400-evb device tree, with a couple small tweaks for the serial console UART and ethernet MACs.
--- arch/arm/dts/Makefile | 1 + arch/arm/dts/ast2400-ahe-50dc.dts | 34 +++++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+) create mode 100644 arch/arm/dts/ast2400-ahe-50dc.dts
arch/arm/dts/Makefile +1 -0
@@ -676,6 +676,7 @@ dtb-$(CONFIG_ARCH_BCM6858) += \ dtb-$(CONFIG_ARCH_ASPEED) += \ ast2400-evb.dtb \ + ast2400-ahe-50dc.dtb \ ast2500-evb.dtb \ ast2600a0-evb.dtb \ ast2600a1-evb.dtb \
arch/arm/dts/ast2400-ahe-50dc.dts new file +34 -0
@@ -0,0 +1,34 @@ +/dts-v1/; + +#include "ast2400-evb.dts" + +/ { + model = "Delta AHE-50DC BMC"; + compatible = "delta,ahe-50dc-bmc", "aspeed,ast2400-evb", "aspeed,ast2400"; + + chosen { + stdout-path = &uart3; + }; +}; + +&uart5 { + status = "disabled"; +}; + +&uart3 { + u-boot,dm-pre-reloc; + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_txd3_default &pinctrl_rxd3_default>; +}; + +&mac0 { + status = "disabled"; +}; + +&mac1 { + status = "okay"; + phy-mode = "rgmii"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>; +};
Signature · 1 line
2.35.1
Quoted 11 lines · Zev Weiss
The Delta AHE-50DC Open19 power shelf uses a pair of AST1250 BMCs that are mostly compatible with the existing ast2400-evb device tree, with a couple small tweaks for the serial console UART and ethernet MACs.
Signed-off-by Zev Weiss <[email protected]>--- arch/arm/dts/Makefile | 1 + arch/arm/dts/ast2400-ahe-50dc.dts | 34 +++++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+) create mode 100644 arch/arm/dts/ast2400-ahe-50dc.dts
Ping...does this look like a reasonable approach for a board that's mostly-but-not-entirely EVB-compatible? Once the regulator/extcon driver question gets sorted out I'll post a kernel dts, after which I think the necessary pieces will be in place to add an OpenBMC meta-layer for this system.
This patch is also still outstanding as a semi-dependency (not strictly necessary for this, but nice to have for it):
https://lore.kernel.org/openbmc/[email protected]/
Thanks,
Zev
Quoted 14 lines · Zev Weiss
Quoted 11 lines · Zev Weiss
The Delta AHE-50DC Open19 power shelf uses a pair of AST1250 BMCs that are mostly compatible with the existing ast2400-evb device tree, with a couple small tweaks for the serial console UART and ethernet MACs.
Signed-off-by Zev Weiss <[email protected]>--- arch/arm/dts/Makefile | 1 + arch/arm/dts/ast2400-ahe-50dc.dts | 34 +++++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+) create mode 100644 arch/arm/dts/ast2400-ahe-50dc.dts
Quoted 2 lines
Ping...does this look like a reasonable approach for a board that's mostly-but-not-entirely EVB-compatible?
That looks okay. Are you sure you have everything that the evb enables on your board? Dual flashes on both flash controllers, etc?
I wonder if it would be better to put more into ast2400-u-boot.dtsi and use that?
But I don't have strong opinions either way. Your device tree looks fine, and I am happy to merge it.
Quoted 13 lines
Once the regulator/extcon
driver question gets sorted out I'll post a kernel dts, after which I think the necessary pieces will be in place to add an OpenBMC meta-layer for this system.This patch is also still outstanding as a semi-dependency (not strictly necessary for this, but nice to have for it):
https://lore.kernel.org/openbmc/[email protected]/Thanks,
Zev
Quoted 15 lines · Joel Stanley
Quoted 14 lines · Zev Weiss
Quoted 11 lines · Zev Weiss
The Delta AHE-50DC Open19 power shelf uses a pair of AST1250 BMCs that are mostly compatible with the existing ast2400-evb device tree, with a couple small tweaks for the serial console UART and ethernet MACs.
Signed-off-by Zev Weiss <[email protected]>--- arch/arm/dts/Makefile | 1 + arch/arm/dts/ast2400-ahe-50dc.dts | 34 +++++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+) create mode 100644 arch/arm/dts/ast2400-ahe-50dc.dts
Quoted 6 lines
Quoted 2 lines
Ping...does this look like a reasonable approach for a board that's mostly-but-not-entirely EVB-compatible?
That looks okay. Are you sure you have everything that the evb enables on your board? Dual flashes on both flash controllers, etc?
Ah, good point -- while it does have dual flashes on the fmc, I should probably disable spi1.
Quoted 6 lines
I wonder if it would be better to put more into
ast2400-u-boot.dtsiand use that?But I don't have strong opinions either way. Your device tree looks fine, and I am happy to merge it.
Hmm, hadn't considered that possibility...I'm likewise not strongly opinionated, but I guess the current approach of extending the evb dts seems slightly simpler?
Thanks for the review -- I'll send a v2 with spi1 disabled soon.
Zev