doc: remove multi-queue reconnection known issue
PATCH 1/1 doc: remove multi-queue reconnection known issue
From: Xuan Ding <[email protected]>
Since QEMU 5.2.0 fixes the vhost multi-queue reconnection issue in commit f66337bdbfda ("vhost-user: save features of multiqueues if chardev is closed"), this patch removes the previous description from known issue.
--- doc/guides/rel_notes/known_issues.rst | 21 --------------------- 1 file changed, 21 deletions(-)
doc/guides/rel_notes/known_issues.rst +0 -21
@@ -884,24 +884,3 @@ Unsuitable IOVA mode may be picked as the default **Driver/Module**: ALL. - -Vhost multi-queue reconnection failed with QEMU version >= 4.2.0 ----------------------------------------------------------------- - -**Description** - It's a QEMU regression bug (bad commit: c6beefd674ff). QEMU only saves - acked features for one vhost-net when vhost quits. When vhost reconnects - to virtio-net/virtio-pmd in multi-queue situations, the features been - set multiple times are not consistent. - -**Implication** - Vhost cannot reconnect back to virtio-net/virtio-pmd normally. - -**Resolution/Workaround**: - It is possible to filter the incorrect acked features at vhost-user side. - -**Affected Environment/Platform**: - ALL. - -**Driver/Module**: - Virtual Device Poll Mode Driver (PMD).
Signature · 1 line
2.17.1
PATCH v2 1/1 doc: fix vhost multi-queue reconnection
From: Xuan Ding <[email protected]>
Since QEMU 5.2.0 fixes the vhost multi-queue reconnection issue in commit f66337bdbfda ("vhost-user: save features of multiqueues if chardev is closed"), this patch removes the previous description from known issue.
---
v2:
* Add fixes in commit title and log.
--- doc/guides/rel_notes/known_issues.rst | 21 --------------------- 1 file changed, 21 deletions(-)
doc/guides/rel_notes/known_issues.rst +0 -21
@@ -884,24 +884,3 @@ Unsuitable IOVA mode may be picked as the default **Driver/Module**: ALL. - -Vhost multi-queue reconnection failed with QEMU version >= 4.2.0 ----------------------------------------------------------------- - -**Description** - It's a QEMU regression bug (bad commit: c6beefd674ff). QEMU only saves - acked features for one vhost-net when vhost quits. When vhost reconnects - to virtio-net/virtio-pmd in multi-queue situations, the features been - set multiple times are not consistent. - -**Implication** - Vhost cannot reconnect back to virtio-net/virtio-pmd normally. - -**Resolution/Workaround**: - It is possible to filter the incorrect acked features at vhost-user side. - -**Affected Environment/Platform**: - ALL. - -**Driver/Module**: - Virtual Device Poll Mode Driver (PMD).
Signature · 1 line
2.17.1
Re: [PATCH v2] doc: fix vhost multi-queue reconnection
Quoted 37 lines · On 2/24/22 07:28, [email protected] wrote:
From: Xuan Ding <[email protected]>
Since QEMU 5.2.0 fixes the vhost multi-queue reconnection issue in commit
f66337bdbfda("vhost-user: save features of multiqueues if chardev is closed"), this patch removes the previous description from known issue.Fixes b37e95507e1b ("doc: add vhost multi-queue reconnection issue")Signed-off-by Xuan Ding <[email protected]>---
v2:
* Add fixes in commit title and log.--- doc/guides/rel_notes/known_issues.rst | 21 --------------------- 1 file changed, 21 deletions(-)doc/guides/rel_notes/known_issues.rst +0
-11@@ -884,24 +884,3 @@ Unsuitable IOVA mode may be picked as the default **Driver/Module**: ALL. - -Vhost multi-queue reconnection failed with QEMU version >= 4.2.0 ----------------------------------------------------------------- - -**Description** - It's a QEMU regression bug (bad commit: c6beefd674ff). QEMU only saves - acked features for one vhost-net when vhost quits. When vhost reconnects - to virtio-net/virtio-pmd in multi-queue situations, the features been - set multiple times are not consistent. - -**Implication**
doc/guides/rel_notes/known_issues.rst Unsuitable IOVA mode may be picked as the default · line 907
Quoted 10 lines
doc/guides/rel_notes/known_issues.rst +0
-10- Vhost cannot reconnect back to virtio-net/virtio-pmd normally. - -**Resolution/Workaround**: - It is possible to filter the incorrect acked features at vhost-user side. - -**Affected Environment/Platform**: - ALL. - -**Driver/Module**: - Virtual Device Poll Mode Driver (PMD).
Instead of removing this information, I would rather update it to indicate the range of affected QEMU versions.
What do you think?
Thanks,
Maxime
RE: [PATCH v2] doc: fix vhost multi-queue reconnection
Hi Maxime,
Quoted 65 lines
-----Original Message-----
From: Maxime Coquelin <[email protected]>
Sent: Tuesday, March 29, 2022 8:47 PM
To: Ding, Xuan <[email protected]>; Xia, Chenbo <[email protected]>
Cc: [email protected]; Hu, Jiayu <[email protected]>; [email protected]
Subject: Re: [PATCH v2] doc: fix vhost multi-queue reconnectiondoc/guides/rel_notes/known_issues.rst Unsuitable IOVA mode may be picked as the
Quoted 24 lines · On 2/24/22 07:28, [email protected] wrote:
From: Xuan Ding <[email protected]>
Since QEMU 5.2.0 fixes the vhost multi-queue reconnection issue in commit
f66337bdbfda("vhost-user: save features of multiqueues if chardev is closed"), this patch removes the previous description from known issue.Fixes b37e95507e1b ("doc: add vhost multi-queue reconnection issue")Signed-off-by Xuan Ding <[email protected]>---
v2:
* Add fixes in commit title and log.--- doc/guides/rel_notes/known_issues.rst | 21 --------------------- 1 file changed, 21 deletions(-)doc/guides/rel_notes/known_issues.rst +0
-0@@ -884,24 +884,3 @@ Unsuitable IOVA mode may be picked as thedefault
doc/guides/rel_notes/known_issues.rst Unsuitable IOVA mode may be picked as the default
Quoted 9 lines
doc/guides/rel_notes/known_issues.rst +0
-6**Driver/Module**: ALL. - -Vhost multi-queue reconnection failed with QEMU version >= 4.2.0 ----------------------------------------------------------------- - -**Description** - It's a QEMU regression bug (bad commit: c6beefd674ff). QEMU onlysaves
doc/guides/rel_notes/known_issues.rst Unsuitable IOVA mode may be picked as the · line 892
Quoted 1 line
doc/guides/rel_notes/known_issues.rst +0
-1- acked features for one vhost-net when vhost quits. When vhostreconnects
Quoted 4 lines
doc/guides/rel_notes/known_issues.rst +0
-4- to virtio-net/virtio-pmd in multi-queue situations, the features been - set multiple times are not consistent. - -**Implication**doc/guides/rel_notes/known_issues.rst Unsuitable IOVA mode may be picked as the default · line 907
Quoted 10 lines
doc/guides/rel_notes/known_issues.rst +0
-10- Vhost cannot reconnect back to virtio-net/virtio-pmd normally. - -**Resolution/Workaround**: - It is possible to filter the incorrect acked features at vhost-user side. - -**Affected Environment/Platform**: - ALL. - -**Driver/Module**: - Virtual Device Poll Mode Driver (PMD).Instead of removing this information, I would rather update it to indicate the range of affected QEMU versions.
Quoted 1 line
What do you think?
That's a good idea, so that users can know which versions are affected. I will update it in next version.
Thanks,
Xuan
Quoted 3 lines
Thanks,
Maxime
PATCH v3 1/1 doc: fix vhost multi-queue reconnection
In reply to [email protected]From: Xuan Ding <[email protected]>
Since QEMU 5.2.0 fixes the vhost split ring multi-queue reconnection issue in commit f66337bdbfda ("vhost-user: save features of multiqueues if chardev is closed"), this patch updates known issue to indicate the range of affeacted QEMU versions.
---
v3:
* Updated affected QEMU versions.
v2:
* Add fixes in commit title and log.
--- doc/guides/rel_notes/known_issues.rst | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
doc/guides/rel_notes/known_issues.rst +4 -3
@@ -885,14 +885,15 @@ Unsuitable IOVA mode may be picked as the default **Driver/Module**: ALL. -Vhost multi-queue reconnection failed with QEMU version >= 4.2.0 ----------------------------------------------------------------- +Vhost multi-queue reconnection failed with QEMU version 4.2.0 to 5.1.0-rc3 +-------------------------------------------------------------------------- **Description** It's a QEMU regression bug (bad commit: c6beefd674ff). QEMU only saves acked features for one vhost-net when vhost quits. When vhost reconnects to virtio-net/virtio-pmd in multi-queue situations, the features been - set multiple times are not consistent. + set multiple times are not consistent. QEMU-5.2.0 fixes this issue in commit + f66337bdbfda ("vhost-user: save features of multiqueues if chardev is closed"). **Implication** Vhost cannot reconnect back to virtio-net/virtio-pmd normally.
Signature · 1 line
2.17.1
RE: [PATCH v3] doc: fix vhost multi-queue reconnection
Quoted 41 lines
-----Original Message-----
From: Ding, Xuan <[email protected]>
Sent: Friday, April 15, 2022 10:08 AM
To: [email protected]; Xia, Chenbo <[email protected]>
Cc: [email protected]; Hu, Jiayu <[email protected]>; Ding, Xuan <[email protected]>; [email protected]
Subject: [PATCH v3] doc: fix vhost multi-queue reconnectionFrom: Xuan Ding <[email protected]>
Since QEMU 5.2.0 fixes the vhost split ring multi-queue reconnection issue in commit
f66337bdbfda("vhost-user: save features of multiqueues if chardev is closed"), this patch updates known issue to indicate the range of affeacted QEMU versions.Fixes b37e95507e1b ("doc: add vhost multi-queue reconnection issue")Signed-off-by Xuan Ding <[email protected]>---
v3:
* Updated affected QEMU versions.v2:
* Add fixes in commit title and log.--- doc/guides/rel_notes/known_issues.rst | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)doc/guides/rel_notes/known_issues.rst +1
-2@@ -885,14 +885,15 @@ Unsuitable IOVA mode may be picked as the default **Driver/Module**: ALL. -Vhost multi-queue reconnection failed with QEMU version >= 4.2.0 ----------------------------------------------------------------- +Vhost multi-queue reconnection failed with QEMU version 4.2.0 to 5.1.0-
Quoted 1 line
rc3
So 5.1.0 fixes the problem or not? As 5.1.0 is later than 5.1.0-rc3 but you said from 5.2.0 it's fixed. And I think we should just mention formal release, not any rc, qemu users should not use any rc for formal usage.
Thanks,
Chenbo
Quoted 18 lines
+-------------------------------------------------------------------------
-**Description**
It's a QEMU regression bug (bad commit:c6beefd674ff). QEMU only saves acked features for one vhost-net when vhost quits. When vhost
reconnects
to virtio-net/virtio-pmd in multi-queue situations, the features beendoc/guides/rel_notes/known_issues.rst +1
-1- set multiple times are not consistent. + set multiple times are not consistent. QEMU-5.2.0 fixes this issue incommit
+f66337bdbfda("vhost-user: save features of multiqueues if chardev is
closed").**Implication**
Vhost cannot reconnect back to virtio-net/virtio-pmd normally.
--
2.17.1
RE: [PATCH v3] doc: fix vhost multi-queue reconnection
Hi Chenbo,
Quoted 46 lines
-----Original Message-----
From: Xia, Chenbo <[email protected]>
Sent: Friday, May 6, 2022 4:41 PM
To: Ding, Xuan <[email protected]>; [email protected]
Cc: [email protected]; Hu, Jiayu <[email protected]>; [email protected]
Subject: RE: [PATCH v3] doc: fix vhost multi-queue reconnectionQuoted 39 lines
-----Original Message-----
From: Ding, Xuan <[email protected]>
Sent: Friday, April 15, 2022 10:08 AM
To: [email protected]; Xia, Chenbo <[email protected]>
Cc: [email protected]; Hu, Jiayu <[email protected]>; Ding, Xuan <[email protected]>; [email protected]
Subject: [PATCH v3] doc: fix vhost multi-queue reconnectionFrom: Xuan Ding <[email protected]>
Since QEMU 5.2.0 fixes the vhost split ring multi-queue reconnection issue in commit
f66337bdbfda("vhost-user: save features of multiqueues if chardev is closed"), this patch updates known issue to indicate the range of affeacted QEMU versions.Fixes b37e95507e1b ("doc: add vhost multi-queue reconnection issue")Signed-off-by Xuan Ding <[email protected]>---
v3:
* Updated affected QEMU versions.v2:
* Add fixes in commit title and log.--- doc/guides/rel_notes/known_issues.rst | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)doc/guides/rel_notes/known_issues.rst +0
-0@@ -885,14 +885,15 @@ Unsuitable IOVA mode may be picked as thedefault
**Driver/Module**:
ALL.
Quoted 9 lines
Quoted 5 lines
doc/guides/rel_notes/known_issues.rst +2
-2-Vhost multi-queue reconnection failed with QEMU version >= 4.2.0 ----------------------------------------------------------------- +Vhost multi-queue reconnection failed with QEMU version 4.2.0 to +5.1.0-rc3
So 5.1.0 fixes the problem or not? As 5.1.0 is later than 5.1.0-rc3 but you said from 5.2.0 it's fixed. And I think we should just mention formal release, not any rc, qemu users should not use any rc for formal usage.
Thanks for your catch. The tag here is wrong(actually 5.2.0-rc0). So the actual fixed version is in 5.2.0. I will fix it in next version.
Regards,
Xuan
Quoted 26 lines
Thanks,
ChenboQuoted 6 lines
+--------------------------------------------------------------------- +-----
**Description**
It's a QEMU regression bug (bad commit:c6beefd674ff). QEMU onlysaves
Quoted 15 lines
acked features for one vhost-net when vhost quits. When vhost
reconnects
to virtio-net/virtio-pmd in multi-queue situations, the features beendoc/guides/rel_notes/known_issues.rst +2
-1- set multiple times are not consistent. + set multiple times are not consistent. QEMU-5.2.0 fixes this issue + incommit
+f66337bdbfda("vhost-user: save features of multiqueues if chardev
+ is
closed").**Implication**
Vhost cannot reconnect back to virtio-net/virtio-pmd normally.
--
2.17.1
PATCH v4 1/1 doc: fix vhost multi-queue reconnection
In reply to [email protected]From: Xuan Ding <[email protected]>
Since QEMU 5.2.0 fixes the vhost split ring multi-queue reconnection issue in commit f66337bdbfda ("vhost-user: save features of multiqueues if chardev is closed"), this patch updates known issue to indicate the range of affeacted QEMU versions.
---
v4:
* Corrected the QEMU fix version.
v3:
* Updated affected QEMU versions.
v2:
* Added fixes in commit title and log.
--- doc/guides/rel_notes/known_issues.rst | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
doc/guides/rel_notes/known_issues.rst +4 -3
@@ -885,14 +885,15 @@ Unsuitable IOVA mode may be picked as the default **Driver/Module**: ALL. -Vhost multi-queue reconnection failed with QEMU version >= 4.2.0 ----------------------------------------------------------------- +Vhost multi-queue reconnection failed with QEMU version 4.2.0 to 5.1.0 +---------------------------------------------------------------------- **Description** It's a QEMU regression bug (bad commit: c6beefd674ff). QEMU only saves acked features for one vhost-net when vhost quits. When vhost reconnects to virtio-net/virtio-pmd in multi-queue situations, the features been - set multiple times are not consistent. + set multiple times are not consistent. QEMU-5.2.0 fixes this issue in commit + f66337bdbfda ("vhost-user: save features of multiqueues if chardev is closed"). **Implication** Vhost cannot reconnect back to virtio-net/virtio-pmd normally.
Signature · 1 line
2.17.1
RE: [PATCH v4] doc: fix vhost multi-queue reconnection
Quoted 57 lines
-----Original Message-----
From: Ding, Xuan <[email protected]>
Sent: Monday, May 9, 2022 12:12 PM
To: [email protected]; Xia, Chenbo <[email protected]>
Cc: [email protected]; Hu, Jiayu <[email protected]>; Ding, Xuan <[email protected]>; [email protected]
Subject: [PATCH v4] doc: fix vhost multi-queue reconnectionFrom: Xuan Ding <[email protected]>
Since QEMU 5.2.0 fixes the vhost split ring multi-queue reconnection issue in commit
f66337bdbfda("vhost-user: save features of multiqueues if chardev is closed"), this patch updates known issue to indicate the range of affeacted QEMU versions.Fixes b37e95507e1b ("doc: add vhost multi-queue reconnection issue")Signed-off-by Xuan Ding <[email protected]>---
v4:
* Corrected the QEMU fix version.v3:
* Updated affected QEMU versions.v2:
* Added fixes in commit title and log.--- doc/guides/rel_notes/known_issues.rst | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)doc/guides/rel_notes/known_issues.rst +2
-2@@ -885,14 +885,15 @@ Unsuitable IOVA mode may be picked as the default **Driver/Module**: ALL. -Vhost multi-queue reconnection failed with QEMU version >= 4.2.0 ----------------------------------------------------------------- +Vhost multi-queue reconnection failed with QEMU version 4.2.0 to 5.1.0 +---------------------------------------------------------------------- **Description** It's a QEMU regression bug (bad commit: c6beefd674ff). QEMU only saves acked features for one vhost-net when vhost quits. When vhostreconnects
to virtio-net/virtio-pmd in multi-queue situations, the features beendoc/guides/rel_notes/known_issues.rst +1
-1- set multiple times are not consistent. + set multiple times are not consistent. QEMU-5.2.0 fixes this issue incommit
+f66337bdbfda("vhost-user: save features of multiqueues if chardev is
closed").
Quoted 4 lines
**Implication**
Vhost cannot reconnect back to virtio-net/virtio-pmd normally.
--
2.17.1