Skip to contentSkip to conversation

Update AMDGPU glossary and MAINTAINERS

PATCH Applied Tales Lelo da Aparecida 5 participants 8 messages Apr 15, 2022 – Apr 19, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover Update AMDGPU glossary and MAINTAINERS

I was handling the request from [0] and then I noticed that some AMD developers were missing from get_maintainers output due to the lack of a reference to their documentation in the MAINTAINERS file.

[0] https://gitlab.freedesktop.org/drm/amd/-/issues/1939#note_1309737

Tales Lelo da Aparecida (2):
Documentation/gpu: Add entries to amdgpu glossary
MAINTAINERS: add docs entry to AMDGPU

 Documentation/gpu/amdgpu/amdgpu-glossary.rst | 13 +++++++++++++
 MAINTAINERS                                  |  1 +
 2 files changed, 14 insertions(+)
Signature · 1 line
2.35.1
#1 lore raw

PATCH 1/2 Documentation/gpu: Add entries to amdgpu glossary

Add missing acronyms to the amdgppu glossary.

---
 Documentation/gpu/amdgpu/amdgpu-glossary.rst | 13 +++++++++++++
 1 file changed, 13 insertions(+)
Documentation/gpu/amdgpu/amdgpu-glossary.rst +13 -0
index 859dcec6c6f9..48829d097f40 100644
@@ -8,12 +8,19 @@ we have a dedicated glossary for Display Core at
 
 .. glossary::
 
+    active_cu_number
+      The number of CUs that are active on the system.  The number of active
+      CUs may be less than SE * SH * CU depending on the board configuration.
+
     CP
       Command Processor
 
     CPLIB
       Content Protection Library
 
+    CU
+      Compute unit
+
     DFS
       Digital Frequency Synthesizer
 
@@ -74,6 +81,12 @@ we have a dedicated glossary for Display Core at
     SDMA
       System DMA
 
+    SE
+      Shader Engine
+
+    SH
+      SHader array
+
     SMU
       System Management Unit
 
Signature · 1 line
2.35.1
#2 lore raw

Re: [PATCH 1/2] Documentation/gpu: Add entries to amdgpu glossary

Dear Tales,

Thank you for your patch.

Am 15.04.22 um 21:50 schrieb Tales Lelo da Aparecida:

Quoted 18 lines

Add missing acronyms to the amdgppu glossary.

---
  Documentation/gpu/amdgpu/amdgpu-glossary.rst | 13 +++++++++++++
  1 file changed, 13 insertions(+)
Documentation/gpu/amdgpu/amdgpu-glossary.rst +2 -0
index 859dcec6c6f9..48829d097f40 100644
@@ -8,12 +8,19 @@ we have a dedicated glossary for Display Core at
 
  .. glossary::
 
+    active_cu_number
+      The number of CUs that are active on the system.  The number of active

Documentation/gpu/amdgpu/amdgpu-glossary.rst we have a dedicated glossary for Display Core at · line 22

Quoted 10 lines
Documentation/gpu/amdgpu/amdgpu-glossary.rst +4 -0
+      CUs may be less than SE * SH * CU depending on the board configuration.
+
      CP
        Command Processor
 
      CPLIB
        Content Protection Library
 
+    CU
+      Compute unit

Capitalize the U in *unit* as seems to be done in the rest of the files?

Documentation/gpu/amdgpu/amdgpu-glossary.rst we have a dedicated glossary for Display Core at · line 88

Quoted 13 lines
Documentation/gpu/amdgpu/amdgpu-glossary.rst +6 -0
+
      DFS
        Digital Frequency Synthesizer
 
@@ -74,6 +81,12 @@ we have a dedicated glossary for Display Core at
      SDMA
        System DMA
 
+    SE
+      Shader Engine
+
+    SH
+      SHader array

No idea if the H should be capitalized.

Documentation/gpu/amdgpu/amdgpu-glossary.rst we have a dedicated glossary for Display Core at · line 92

Quoted 4 lines
Documentation/gpu/amdgpu/amdgpu-glossary.rst +1 -0
+
      SMU
        System Management Unit
 

Kind regards,

Paul

Applied
#3 lore raw

Re: [PATCH 1/2] Documentation/gpu: Add entries to amdgpu glossary

In reply to Tales Lelo da Aparecida

Applied the series with minor fix to capitalize the U in Compute Unit. Thanks!

Alex

Quoted 49 lines · Tales Lelo da Aparecida

Add missing acronyms to the amdgppu glossary.

---
 Documentation/gpu/amdgpu/amdgpu-glossary.rst | 13 +++++++++++++
 1 file changed, 13 insertions(+)
Documentation/gpu/amdgpu/amdgpu-glossary.rst +13 -1
index 859dcec6c6f9..48829d097f40 100644
@@ -8,12 +8,19 @@ we have a dedicated glossary for Display Core at
 
 .. glossary::
 
+    active_cu_number
+      The number of CUs that are active on the system.  The number of active
+      CUs may be less than SE * SH * CU depending on the board configuration.
+
     CP
       Command Processor
 
     CPLIB
       Content Protection Library
 
+    CU
+      Compute unit
+
     DFS
       Digital Frequency Synthesizer
 
@@ -74,6 +81,12 @@ we have a dedicated glossary for Display Core at
     SDMA
       System DMA
 
+    SE
+      Shader Engine
+
+    SH
+      SHader array
+
     SMU
       System Management Unit
 
--

2.35.1

#4 lore raw

PATCH 2/2 MAINTAINERS: add docs entry to AMDGPU

In reply to Tales Lelo da Aparecida

To make sure maintainers of amdgpu drivers are aware of any changes
in their documentation, add its entry to MAINTAINERS.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index d54b9f15ffce..b3594b2a09de 100644
@@ -16449,6 +16449,7 @@ S:	Supported
 T:	git https://gitlab.freedesktop.org/agd5f/linux.git
 B:	https://gitlab.freedesktop.org/drm/amd/-/issues
 C:	irc://irc.oftc.net/radeon
+F:	Documentation/gpu/amdgpu/
 F:	drivers/gpu/drm/amd/
 F:	drivers/gpu/drm/radeon/
 F:	include/uapi/drm/amdgpu_drm.h
Signature · 1 line
2.35.1
#5 lore raw

Re: [PATCH 2/2] MAINTAINERS: add docs entry to AMDGPU

Quoted 3 lines · Tales Lelo da Aparecida

To make sure maintainers of amdgpu drivers are aware of any changes
in their documentation, add its entry to MAINTAINERS.

Did you mean the Documentation/gpu/amdgpu/ is maintained by dri-devel?

Signature · 1 line
An old man doll... just what I always wanted! - Clara
author
#6 lore raw

Re: [PATCH 2/2] MAINTAINERS: add docs entry to AMDGPU

Hi Bagas Sanjaya,

Em sáb., 16 de abr. de 2022 às 02:47, Bagas Sanjaya <[email protected]> escreveu:

Quoted 6 lines · Tales Lelo da Aparecida
Quoted 3 lines

To make sure maintainers of amdgpu drivers are aware of any changes
in their documentation, add its entry to MAINTAINERS.

Did you mean the Documentation/gpu/amdgpu/ is maintained by dri-devel?

Documentation/gpu/amdgpu/ should be maintained by "RADEON and AMDGPU DRM DRIVERS" developers, which are part of the dri-devel community.

Kind regards

Acked-by on the v1 series
#7 lore raw
In reply to Tales Lelo da Aparecida

Am 15.04.22 um 21:50 schrieb Tales Lelo da Aparecida:

Quoted 3 lines

I was handling the request from [0] and then I noticed that some AMD developers were missing from get_maintainers output due to the lack of a reference to their documentation in the MAINTAINERS file.

Quoted 11 lines

[0] https://gitlab.freedesktop.org/drm/amd/-/issues/1939#note_1309737

Tales Lelo da Aparecida (2):
Documentation/gpu: Add entries to amdgpu glossary
MAINTAINERS: add docs entry to AMDGPU

  Documentation/gpu/amdgpu/amdgpu-glossary.rst | 13 +++++++++++++
  MAINTAINERS                                  |  1 +
  2 files changed, 14 insertions(+)