Skip to contentSkip to conversation

clk: actions: remove redundant assignment after a mask operation

PATCH Applied Colin Ian King 2 participants 2 messages Apr 18, 2022 – Apr 23, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: actions: remove redundant assignment after a mask operation

The assignment operation after a & mask operation is redundant, the &= operator can be replaced with just the & operator.

Cleans up a clang-scan warning:
drivers/clk/actions/owl-pll.c:28:9: warning: Although the value stored to 'mul' is used in the enclosing expression, the value is never actually read from 'mul' [deadcode.DeadStores]

---
 drivers/clk/actions/owl-pll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/actions/owl-pll.c +1 -1
index 02437bdedf4d..155f313986b4 100644
@@ -25,7 +25,7 @@ static u32 owl_pll_calculate_mul(struct owl_pll_hw *pll_hw, unsigned long rate)
 	else if (mul > pll_hw->max_mul)
 		mul = pll_hw->max_mul;
 
-	return mul &= mul_mask(pll_hw);
+	return mul & mul_mask(pll_hw);
 }
 
 static unsigned long _get_table_rate(const struct clk_pll_table *table,
Signature · 1 line
2.35.1
maintainer Applied
#1 lore raw

Quoting Colin Ian King (2022-04-18 07:15:37)

Quoted 10 lines

The assignment operation after a & mask operation is redundant, the &= operator can be replaced with just the & operator.

Cleans up a clang-scan warning:
drivers/clk/actions/owl-pll.c:28:9: warning: Although the value stored to 'mul' is used in the enclosing expression, the value is never actually read from 'mul' [deadcode.DeadStores]

---

Applied to clk-next