myri10ge: remove redundant assignment to variable status
PATCH 1/1 myri10ge: remove redundant assignment to variable status
Variable status is being assigned a value that is never read, it is being re-assigned again later on. The assignment is redundant and can be removed.
Cleans up clang scan build warning:drivers/net/ethernet/myricom/myri10ge/myri10ge.c:582:7: warning: Although the value stored to 'status' is used in the enclosing expression, the value is never actually read from 'status' [deadcode.DeadStores]
--- drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/myricom/myri10ge/myri10ge.c +1 -1
@@ -579,7 +579,7 @@ static int myri10ge_load_hotplug_firmware(struct myri10ge_priv *mgp, u32 * size)int status;unsigned i; -if ((status =request_firmware (&fw, mgp->fw_name, dev)) <0 ) { +if (request_firmware (&fw, mgp->fw_name, dev) <0 ) {dev_err (dev,"Unable to load %s firmware image via hotplug\n" , mgp->fw_name); status = -EINVAL ;
Signature · 1 line
2.35.1
This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:
Quoted 10 lines · On Mon, 18 Apr 2022 15:37:59 +0100 you wrote:
Variable status is being assigned a value that is never read, it is being re-assigned again later on. The assignment is redundant and can be removed.
Cleans up clang scan build warning:
drivers/net/ethernet/myricom/myri10ge/myri10ge.c:582:7: warning: Although the value stored to 'status' is used in the enclosing expression, the value is never actually read from 'status' [deadcode.DeadStores][...]
Here is the summary with links:
- myri10ge: remove redundant assignment to variable status
https://git.kernel.org/netdev/net-next/c/1c604f91b773
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html