Skip to contentSkip to conversation

staging: vt6655f: rxtx: Fix Lines should not end with a '('

PATCH In review Aliya Rahmani 2 participants 2 messages Apr 18, 2022 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/1 staging: vt6655f: rxtx: Fix Lines should not end with a '('

Put the first parameter immediately after the '(' and align the other parameters underneath it. Put static and void on a single and function type together. Code style warnings reported by checkpatch.

---
v1->v2 changes: Put static and void on a single line.

v2->v3->v4 changes: Rework commit description.

v4->v5 changes: Put storage class and function type on a single line.
Rework commit description and subject.

---
 drivers/staging/vt6655/rxtx.c | 24 ++++++++++--------------
 1 file changed, 10 insertions(+), 14 deletions(-)
drivers/staging/vt6655/rxtx.c +10 -14
index 53506e242a96..8127807070a7 100644
@@ -567,19 +567,15 @@ s_uFillDataHead(
 	return buf->duration;
 }
 
-static
-void
-s_vFillRTSHead(
-	struct vnt_private *pDevice,
-	unsigned char byPktType,
-	void *pvRTS,
-	unsigned int cbFrameLength,
-	bool bNeedAck,
-	bool bDisCRC,
-	struct ieee80211_hdr *hdr,
-	unsigned short wCurrentRate,
-	unsigned char byFBOption
-)
+static void s_vFillRTSHead(struct vnt_private *pDevice,
+			   unsigned char byPktType,
+			   void *pvRTS,
+	                   unsigned int cbFrameLength,
+                          bool bNeedAck,
+	                   bool bDisCRC,
+	                   struct ieee80211_hdr *hdr,
+	                   unsigned short wCurrentRate,
+	                   unsigned char byFBOption)
 {
 	unsigned int uRTSFrameLen = 20;
 
@@ -601,7 +597,7 @@ s_vFillRTSHead(
 		if (byFBOption == AUTO_FB_NONE) {
 			struct vnt_rts_g *buf = pvRTS;
 			/* Get SignalField, ServiceField & Length */
-			vnt_get_phy_field(pDevice, uRTSFrameLen,
+			vnt_get_phy_field(pDevice, uRTSFrameLen
 					  pDevice->byTopCCKBasicRate,
 					  PK_TYPE_11B, &buf->b);
 
Signature · 1 line
2.25.1
#1 lore raw

Hi Aliya,

Quoted 11 lines · Aliya Rahmani
drivers/staging/vt6655/rxtx.c +0 -11
-void
-s_vFillRTSHead(
-	struct vnt_private *pDevice,
-	unsigned char byPktType,
-	void *pvRTS,
-	unsigned int cbFrameLength,
-	bool bNeedAck,
-	bool bDisCRC,
-	struct ieee80211_hdr *hdr,
-	unsigned short wCurrentRate,
-	unsigned char byFBOption

drivers/staging/vt6655/rxtx.c s_uFillDataHead( · line 578

Quoted 10 lines
drivers/staging/vt6655/rxtx.c +9 -1
-)
+static void s_vFillRTSHead(struct vnt_private *pDevice,
+			   unsigned char byPktType,
+			   void *pvRTS,
+	                   unsigned int cbFrameLength,
+                          bool bNeedAck,
+	                   bool bDisCRC,
+	                   struct ieee80211_hdr *hdr,
+	                   unsigned short wCurrentRate,
+	                   unsigned char byFBOption)

Indenting is wrong here. It should be consistent: 8 spaces should be converted to tabs

drivers/staging/vt6655/rxtx.c s_vFillRTSHead( · line 601

Quoted 10 lines
  {
  	unsigned int uRTSFrameLen = 20;
drivers/staging/vt6655/rxtx.c +1 -1
@@ -601,7 +597,7 @@ s_vFillRTSHead(
  		if (byFBOption == AUTO_FB_NONE) {
  			struct vnt_rts_g *buf = pvRTS;
  			/* Get SignalField, ServiceField & Length */
-			vnt_get_phy_field(pDevice, uRTSFrameLen,
+			vnt_get_phy_field(pDevice, uRTSFrameLen
  					  pDevice->byTopCCKBasicRate,

This won't compile. Please, always build-check your patches before sending out.

With regards,
Pavel Skripkin