Skip to contentSkip to conversation

drm/amd/display: add virtual_setup_stream_attribute decl to header

PATCH Applied Tom Rix 2 participants 2 messages Apr 18, 2022 – Apr 19, 2022

Subsystems (3)
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 drm/amd/display: add virtual_setup_stream_attribute decl to header

Smatch reports this issue virtual_link_hwss.c:32:6: warning: symbol
'virtual_setup_stream_attribute' was not declared. Should it be static?

virtual_setup_stream_attribute is only used in virtual_link_hwss.c, but the other functions in the file are declared in the header file and used elsewhere. For consistency, add the virtual_setup_stream_attribute decl to virtual_link_hwss.h.

---
 drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h +1 -0
index e6bcb4bb0f3a..fbcbc5afb47d 100644
@@ -28,6 +28,7 @@
 #include "core_types.h"
 
 void virtual_setup_stream_encoder(struct pipe_ctx *pipe_ctx);
+void virtual_setup_stream_attribute(struct pipe_ctx *pipe_ctx);
 void virtual_reset_stream_encoder(struct pipe_ctx *pipe_ctx);
 const struct link_hwss *get_virtual_link_hwss(void);
 
Signature · 1 line
2.27.0
Applied
#1 lore raw

Applied. Thanks!

Quoted 32 lines · Tom Rix

Smatch reports this issue virtual_link_hwss.c:32:6: warning: symbol
'virtual_setup_stream_attribute' was not declared. Should it be static?

virtual_setup_stream_attribute is only used in virtual_link_hwss.c, but the other functions in the file are declared in the header file and used elsewhere. For consistency, add the virtual_setup_stream_attribute decl to virtual_link_hwss.h.

---
 drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h +1 -1
index e6bcb4bb0f3a..fbcbc5afb47d 100644
@@ -28,6 +28,7 @@
 #include "core_types.h"
 
 void virtual_setup_stream_encoder(struct pipe_ctx *pipe_ctx);
+void virtual_setup_stream_attribute(struct pipe_ctx *pipe_ctx);
 void virtual_reset_stream_encoder(struct pipe_ctx *pipe_ctx);
 const struct link_hwss *get_virtual_link_hwss(void);
 
--

2.27.0