Skip to contentSkip to conversation

ti-graphics: Add j7-hs-evm as a compatible machine.

PATCH In review Ryan Eatmon 3 participants 3 messages Apr 19, 2022 – Apr 21, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ti-graphics: Add j7-hs-evm as a compatible machine.

The recent change to explicitly list the compatible machines is missing the j7-hs-evm.

---
 .../powervr-drivers/ti-img-rogue-driver_1.15.6133109.bb       | 4 +++-
 recipes-graphics/libgles/ti-img-rogue-umlibs_1.15.6133109.bb  | 3 ++-
 2 files changed, 5 insertions(+), 2 deletions(-)
recipes-bsp/powervr-drivers/ti-img-rogue-driver_1.15.6133109.bb +3 -1
index fbff6c51..6d2d68cd 100644
@@ -11,7 +11,7 @@ MACHINE_KERNEL_PR_append = "a"
 PR = "${MACHINE_KERNEL_PR}"
 
 PACKAGE_ARCH = "${MACHINE_ARCH}"
-COMPATIBLE_MACHINE = "j7-evm|j721s2-evm|am62xx"
+COMPATIBLE_MACHINE = "j7-evm|j7-hs-evm|j721s2-evm|am62xx"
 
 DEPENDS = "virtual/kernel"
 
@@ -29,9 +29,11 @@ S = "${WORKDIR}/git"
 SRCREV = "ee0674adccac16f5b2f7cb8d5d05948706080cb5"
 
 TARGET_PRODUCT_j7-evm = "j721e_linux"
+TARGET_PRODUCT_j7-hs-evm = "j721e_linux"
 TARGET_PRODUCT_j721s2-evm = "j721s2_linux"
 TARGET_PRODUCT_am62xx = "am62_linux"
 TARGET_BVNC_j7-evm = "22.104.208.318"
+TARGET_BVNC_j7-hs-evm = "22.104.208.318"
 TARGET_BVNC_j721s2-evm = "36.53.104.796"
 TARGET_BVNC_am62xx = "33.15.11.3"
 PVR_BUILD = "release"
recipes-graphics/libgles/ti-img-rogue-umlibs_1.15.6133109.bb +2 -1
index e00dce99..0f3f9192 100644
@@ -8,7 +8,7 @@ inherit features_check
 REQUIRED_MACHINE_FEATURES = "gpu"
 
 PACKAGE_ARCH = "${MACHINE_ARCH}"
-COMPATIBLE_MACHINE = "j7-evm|j721s2-evm|am62xx"
+COMPATIBLE_MACHINE = "j7-evm|j7-hs-evm|j721s2-evm|am62xx"
 
 PR = "r1"
 
@@ -18,6 +18,7 @@ SRC_URI = "git://git.ti.com/graphics/ti-img-rogue-umlibs.git;branch=${BRANCH}"
 SRCREV = "47c3ffc44f2881397d45c8a2b5dfa7d6c58b79fb"
 
 TARGET_PRODUCT_j7-evm = "j721e_linux"
+TARGET_PRODUCT_j7-hs-evm = "j721e_linux"
 TARGET_PRODUCT_j721s2-evm = "j721s2_linux"
 TARGET_PRODUCT_am62xx = "am62_linux"
 PVR_BUILD ?= "release"
Signature · 1 line
2.17.1
#1 lore raw
Quoted 13 lines · Ryan Eatmon via lists.yoctoproject.org

The recent change to explicitly list the compatible machines is missing the j7-hs-evm.

---
  .../powervr-drivers/ti-img-rogue-driver_1.15.6133109.bb       | 4 +++-
  recipes-graphics/libgles/ti-img-rogue-umlibs_1.15.6133109.bb  | 3 ++-
  2 files changed, 5 insertions(+), 2 deletions(-)
recipes-bsp/powervr-drivers/ti-img-rogue-driver_1.15.6133109.bb +0 -0
index fbff6c51..6d2d68cd 100644

recipes-bsp/powervr-drivers/ti-img-rogue-driver_1.15.6133109.bb MACHINE_KERNEL_PR_append = "a" · line 14

Quoted 5 lines
recipes-bsp/powervr-drivers/ti-img-rogue-driver_1.15.6133109.bb +1 -1
@@ -11,7 +11,7 @@ MACHINE_KERNEL_PR_append = "a"
  PR = "${MACHINE_KERNEL_PR}"
 
  PACKAGE_ARCH = "${MACHINE_ARCH}"
-COMPATIBLE_MACHINE = "j7-evm|j721s2-evm|am62xx"
+COMPATIBLE_MACHINE = "j7-evm|j7-hs-evm|j721s2-evm|am62xx"

Doesn't seem right, we haven't needed to specify the HS version before..

Seems we are mixing SoC and board, the GPU driver depends on the SoC not the board, we match correctly for am62xx on SoC, but J7 on specific board name. Suggest

+COMPATIBLE_MACHINE = "j7|j721s2|am62xx"

Andrew

Quoted 47 lines
recipes-bsp/powervr-drivers/ti-img-rogue-driver_1.15.6133109.bb +2 -0
  DEPENDS = "virtual/kernel"
 
@@ -29,9 +29,11 @@ S = "${WORKDIR}/git"
  SRCREV = "ee0674adccac16f5b2f7cb8d5d05948706080cb5"
 
  TARGET_PRODUCT_j7-evm = "j721e_linux"
+TARGET_PRODUCT_j7-hs-evm = "j721e_linux"
  TARGET_PRODUCT_j721s2-evm = "j721s2_linux"
  TARGET_PRODUCT_am62xx = "am62_linux"
  TARGET_BVNC_j7-evm = "22.104.208.318"
+TARGET_BVNC_j7-hs-evm = "22.104.208.318"
  TARGET_BVNC_j721s2-evm = "36.53.104.796"
  TARGET_BVNC_am62xx = "33.15.11.3"
  PVR_BUILD = "release"
recipes-graphics/libgles/ti-img-rogue-umlibs_1.15.6133109.bb +2 -2
index e00dce99..0f3f9192 100644
@@ -8,7 +8,7 @@ inherit features_check
  REQUIRED_MACHINE_FEATURES = "gpu"
 
  PACKAGE_ARCH = "${MACHINE_ARCH}"
-COMPATIBLE_MACHINE = "j7-evm|j721s2-evm|am62xx"
+COMPATIBLE_MACHINE = "j7-evm|j7-hs-evm|j721s2-evm|am62xx"
 
  PR = "r1"
 
@@ -18,6 +18,7 @@ SRC_URI = "git://git.ti.com/graphics/ti-img-rogue-umlibs.git;branch=${BRANCH}"
  SRCREV = "47c3ffc44f2881397d45c8a2b5dfa7d6c58b79fb"
 
  TARGET_PRODUCT_j7-evm = "j721e_linux"
+TARGET_PRODUCT_j7-hs-evm = "j721e_linux"
  TARGET_PRODUCT_j721s2-evm = "j721s2_linux"
  TARGET_PRODUCT_am62xx = "am62_linux"
  PVR_BUILD ?= "release"
 
 
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.
View/Reply Online (#14603): https://lists.yoctoproject.org/g/meta-ti/message/14603
Mute This Topic: https://lists.yoctoproject.org/mt/90550375/3619733
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw
Quoted 9 lines · Andrew F. Davis via lists.yoctoproject.org
Quoted 8 lines · Ryan Eatmon via lists.yoctoproject.org

The recent change to explicitly list the compatible machines is missing the j7-hs-evm.

---
 .../powervr-drivers/ti-img-rogue-driver_1.15.6133109.bb       | 4 +++-
 recipes-graphics/libgles/ti-img-rogue-umlibs_1.15.6133109.bb  | 3 ++-
 2 files changed, 5 insertions(+), 2 deletions(-)
Quoted 12 lines

recipes-bsp/powervr-drivers/ti-img-rogue-driver_1.15.6133109.bb MACHINE_KERNEL_PR_append = "a" · line 13

Quoted 9 lines
recipes-bsp/powervr-drivers/ti-img-rogue-driver_1.15.6133109.bb +1 -1
index fbff6c51..6d2d68cd 100644
@@ -11,7 +11,7 @@ MACHINE_KERNEL_PR_append = "a"
 PR = "${MACHINE_KERNEL_PR}"
 PACKAGE_ARCH = "${MACHINE_ARCH}"
-COMPATIBLE_MACHINE = "j7-evm|j721s2-evm|am62xx"
+COMPATIBLE_MACHINE = "j7-evm|j7-hs-evm|j721s2-evm|am62xx"

Doesn't seem right, we haven't needed to specify the HS version before..

https://git.yoctoproject.org/meta-ti/commit/?h=dunfell&id=ed94c75b436f2f8c5c3a8a6ebed45d7276cc35e4

Quoted 5 lines

Seems we are mixing SoC and board, the GPU driver depends on the SoC not the board, we match correctly for am62xx on SoC, but J7 on specific board name. Suggest

+COMPATIBLE_MACHINE = "j7|j721s2|am62xx"

There's no j721s2 SoC family in Dunfell.

I'm guessing "j7-evm|j7-hs-evm|j721s2-evm" was done because j7 SoC family in Dunfell is too broad and also covers headless j7200, which lacks "gpu" machine feature... Could be just "j7|am62xx" in Dunfell and more specific SoC families in master/kirkstone.

Signature · 1 line
Denys
Quoted 29 lines
Quoted 29 lines
recipes-bsp/powervr-drivers/ti-img-rogue-driver_1.15.6133109.bb +2 -0
 DEPENDS = "virtual/kernel"
@@ -29,9 +29,11 @@ S = "${WORKDIR}/git"
 SRCREV = "ee0674adccac16f5b2f7cb8d5d05948706080cb5"
 TARGET_PRODUCT_j7-evm = "j721e_linux"
+TARGET_PRODUCT_j7-hs-evm = "j721e_linux"
 TARGET_PRODUCT_j721s2-evm = "j721s2_linux"
 TARGET_PRODUCT_am62xx = "am62_linux"
 TARGET_BVNC_j7-evm = "22.104.208.318"
+TARGET_BVNC_j7-hs-evm = "22.104.208.318"
 TARGET_BVNC_j721s2-evm = "36.53.104.796"
 TARGET_BVNC_am62xx = "33.15.11.3"
 PVR_BUILD = "release"
recipes-graphics/libgles/ti-img-rogue-umlibs_1.15.6133109.bb +2 -1
index e00dce99..0f3f9192 100644
@@ -8,7 +8,7 @@ inherit features_check
 REQUIRED_MACHINE_FEATURES = "gpu"
 PACKAGE_ARCH = "${MACHINE_ARCH}"
-COMPATIBLE_MACHINE = "j7-evm|j721s2-evm|am62xx"
+COMPATIBLE_MACHINE = "j7-evm|j7-hs-evm|j721s2-evm|am62xx"
 PR = "r1"
@@ -18,6 +18,7 @@ SRC_URI = "git://git.ti.com/graphics/ti-img-rogue-umlibs.git;branch=${BRANCH}"
 SRCREV = "47c3ffc44f2881397d45c8a2b5dfa7d6c58b79fb"
 TARGET_PRODUCT_j7-evm = "j721e_linux"
+TARGET_PRODUCT_j7-hs-evm = "j721e_linux"
 TARGET_PRODUCT_j721s2-evm = "j721s2_linux"
 TARGET_PRODUCT_am62xx = "am62_linux"
 PVR_BUILD ?= "release"