nvme: mark internal passthru request RQF_QUIET
PATCH 1/1 nvme: mark internal passthru request RQF_QUIET
Most of the internal passthru commands use __nvme_submit_sync_cmd() interface. There are few places we open code the request submission :-
1. nvme_keep_alive_work(struct work_struct *work)
2. nvme_timeout(struct request *req, bool reserved)
3. nvme_delete_queue(struct nvme_queue *nvmeq, u8 opcode)
Mark the internal passthru request quiet so that we can skip the verbose error message from nvme_log_error() in nvme_end_req() completion path, this will be consistent with what we have in __nvme_submit_sync_cmd().
--- drivers/nvme/host/core.c | 1 + drivers/nvme/host/pci.c | 2 ++ 2 files changed, 3 insertions(+)
drivers/nvme/host/core.c +1 -0
@@ -1207,6 +1207,7 @@ static void nvme_keep_alive_work(struct work_struct *work) rq->timeout = ctrl->kato *HZ ; rq->end_io_data = ctrl; + rq->rq_flags |=RQF_QUIET ;blk_execute_rq_nowait (rq, false, nvme_keep_alive_end_io); }
drivers/nvme/host/pci.c +2 -0
@@ -1439,6 +1439,7 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req, bool reserved)nvme_init_request (abort_req, &cmd); abort_req->end_io_data =NULL ; + abort_req->rq_flags |=RQF_QUIET ;blk_execute_rq_nowait (abort_req, false, abort_endio);/*
@@ -2486,6 +2487,7 @@ static int nvme_delete_queue(struct nvme_queue *nvmeq, u8 opcode) req->end_io_data = nvmeq;init_completion (&nvmeq->delete_done); + req->rq_flags |=RQF_QUIET ;blk_execute_rq_nowait (req, false, opcode == nvme_admin_delete_cq ? nvme_del_cq_end : nvme_del_queue_end);return 0 ;
Signature · 1 line
2.29.0
Quoted 55 lines · Chaitanya Kulkarni
Most of the internal passthru commands use
__nvme_submit_sync_cmd()interface. There are few places we open code the request submission :-1.
nvme_keep_alive_work(struct work_struct *work)
2.nvme_timeout(struct request *req, bool reserved)
3.nvme_delete_queue(struct nvme_queue *nvmeq, u8 opcode)Mark the internal passthru request quiet so that we can skip the verbose error message from
nvme_log_error()innvme_end_req()completion path, this will be consistent with what we have in__nvme_submit_sync_cmd().Signed-off-by Chaitanya Kulkarni <[email protected]>---
drivers/nvme/host/core.c| 1 +drivers/nvme/host/pci.c| 2 ++2 files changed, 3 insertions(+)drivers/nvme/host/core.c +1
-0@@ -1207,6 +1207,7 @@ static void nvme_keep_alive_work(struct work_struct *work) rq->timeout = ctrl->kato *HZ ; rq->end_io_data = ctrl; + rq->rq_flags |=RQF_QUIET ;blk_execute_rq_nowait (rq, false, nvme_keep_alive_end_io); }drivers/nvme/host/pci.c +2
-0@@ -1439,6 +1439,7 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req, bool reserved)nvme_init_request (abort_req, &cmd); abort_req->end_io_data =NULL ; + abort_req->rq_flags |=RQF_QUIET ;blk_execute_rq_nowait (abort_req, false, abort_endio);/* @@ -2486,6 +2487,7 @@ static int nvme_delete_queue(struct nvme_queue *nvmeq, u8 opcode) req->end_io_data = nvmeq;init_completion (&nvmeq->delete_done); + req->rq_flags |=RQF_QUIET ;blk_execute_rq_nowait (req, false, opcode == nvme_admin_delete_cq ? nvme_del_cq_end : nvme_del_queue_end);return 0 ;Signature · 1 line
2.29.0
Thanks,
applied to nvme-5.19.