dlt-daemon: Fix build on rv32/rv64
PATCH 1/2 dlt-daemon: Fix build on rv32/rv64
This is seen with gcc particularly
Signed-off-by Khem Raj <[email protected]>
--- ...ake-Link-with-libatomic-on-rv32-rv64.patch | 45 +++++++++++++++++++ .../dlt-daemon/dlt-daemon_2.18.8.bb | 3 ++ 2 files changed, 48 insertions(+) create mode 100644 meta-oe/recipes-extended/dlt-daemon/dlt-daemon/0001-cmake-Link-with-libatomic-on-rv32-rv64.patch
meta-oe/recipes-extended/dlt-daemon/dlt-daemon/0001-cmake-Link-with-libatomic-on-rv32-rv64.patch new file +45 -0
@@ -0,0 +1,45 @@ +From dd2d42a7f877d292f86e421dd9651f4b7c2abf18 Mon Sep 17 00:00:00 2001 +From: Khem Raj <[email protected]> +Date: Tue, 19 Apr 2022 14:57:58 -0700 +Subject: [PATCH] cmake: Link with libatomic on rv32/rv64 + +Use of <atomic> needs to link in libatomic on riscv +Fixes + +undefined reference to `__atomic_exchange_1' + +Upstream-Status: Pending +Signed-off-by: Khem Raj <[email protected]> +--- + src/lib/CMakeLists.txt | 8 +++++++- + 1 file changed, 7 insertions(+), 1 deletion(-) + +diff --git a/src/lib/CMakeLists.txt b/src/lib/CMakeLists.txt +index 3293376..65018be 100644 +--- a/src/lib/CMakeLists.txt ++++ b/src/lib/CMakeLists.txt +@@ -37,6 +37,12 @@ else() + set(SOCKET_LIBRARY socket) + endif() + ++if(CMAKE_SYSTEM_PROCESSOR STREQUAL "riscv64" OR CMAKE_SYSTEM_PROCESSOR STREQUAL "riscv32") ++ set(ATOMIC_LIBRARY atomic) ++else() ++ set(ATOMIC_LIBRARY "") ++endif() ++ + if(HAVE_FUNC_PTHREAD_SETNAME_NP) + add_definitions(-DDLT_USE_PTHREAD_SETNAME_NP) + message(STATUS "Using pthread_setname_np API to set thread name") +@@ -44,7 +50,7 @@ else() + message(STATUS "pthread_setname_np API not available on this platform") + endif() + +-target_link_libraries(dlt ${RT_LIBRARY} ${SOCKET_LIBRARY} Threads::Threads) ++target_link_libraries(dlt ${RT_LIBRARY} ${SOCKET_LIBRARY} ${ATOMIC_LIBRARY} Threads::Threads) + + target_include_directories(dlt + PUBLIC +-- +2.36.0 +
meta-oe/recipes-extended/dlt-daemon/dlt-daemon_2.18.8.bb +3 -0
@@ -17,6 +17,7 @@ DEPENDS = "zlib gzip-native json-c" SRC_URI = "git://github.com/GENIVI/${BPN}.git;protocol=https;branch=master \ file://0002-Don-t-execute-processes-as-a-specific-user.patch \ file://0004-Modify-systemd-config-directory.patch \ + file://0001-cmake-Link-with-libatomic-on-rv32-rv64.patch \ " SRCREV = "0138c00811c86eab4ff6bff3c6528163885ade19"
@@ -24,6 +25,8 @@ PV .= "+2.18.9git${SRCPV}" S = "${WORKDIR}/git" +LDFLAGS:append:riscv64 = " -latomic" + PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', ' systemd systemd-watchdog systemd-journal dlt-examples dlt-adaptor dlt-console ', '', d)} \ udp-connection dlt-system dlt-filetransfer " # dlt-dbus
Signature · 1 line
2.36.0
PATCH 2/2 grpc: Fix build with rv32/rv64
Signed-off-by Khem Raj <[email protected]>
--- ...ake-Link-with-libatomic-on-rv32-rv64.patch | 32 +++++++++++++++++++ meta-oe/recipes-devtools/grpc/grpc_1.45.2.bb | 1 + 2 files changed, 33 insertions(+) create mode 100644 meta-oe/recipes-devtools/grpc/grpc/0001-cmake-Link-with-libatomic-on-rv32-rv64.patch
meta-oe/recipes-devtools/grpc/grpc/0001-cmake-Link-with-libatomic-on-rv32-rv64.patch new file +32 -0
@@ -0,0 +1,32 @@ +From 592a4aaba20818bcff9a1448c34b09aff9e0d2e9 Mon Sep 17 00:00:00 2001 +From: Khem Raj <[email protected]> +Date: Tue, 19 Apr 2022 16:07:19 -0700 +Subject: [PATCH] cmake: Link with libatomic on rv32/rv64 + +Fixes +riscv64-yoe-linux-musl/12.0.1/ld: libgrpc.so.23.0.0: undefined reference to `__atomic_exchange_1' +| collect2: error: ld returned 1 exit status + +Upstream-Status: Pending +Signed-off-by: Khem Raj <[email protected]> +--- + CMakeLists.txt | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/CMakeLists.txt b/CMakeLists.txt +index a8fd3bf37b3..9f5b242683d 100644 +--- a/CMakeLists.txt ++++ b/CMakeLists.txt +@@ -303,6 +303,9 @@ if(UNIX) + if(_gRPC_PLATFORM_LINUX OR _gRPC_PLATFORM_POSIX) + set(_gRPC_ALLTARGETS_LIBRARIES ${_gRPC_ALLTARGETS_LIBRARIES} rt) + endif() ++ if(CMAKE_SYSTEM_PROCESSOR STREQUAL "riscv64" OR CMAKE_SYSTEM_PROCESSOR STREQUAL "riscv32") ++ set(_gRPC_ALLTARGETS_LIBRARIES ${_gRPC_ALLTARGETS_LIBRARIES} atomic) ++ endif() + endif() + + # configure ccache if requested +-- +2.36.0 +
meta-oe/recipes-devtools/grpc/grpc_1.45.2.bb +1 -0
@@ -25,6 +25,7 @@ BRANCH = "v1.45.x" SRC_URI = "git://github.com/grpc/grpc.git;protocol=https;name=grpc;branch=${BRANCH} \ file://0001-Revert-Changed-GRPCPP_ABSEIL_SYNC-to-GPR_ABSEIL_SYNC.patch \ file://0001-cmake-add-separate-export-for-plugin-targets.patch \ + file://0001-cmake-Link-with-libatomic-on-rv32-rv64.patch \ " # Fixes build with older compilers 4.8 especially on ubuntu 14.04 CXXFLAGS:append:class-native = " -Wl,--no-as-needed"
Signature · 1 line
2.36.0