Skip to contentSkip to conversation

ARM: configs: at91: Remove MTD_BLOCK and use MTD_UBI_BLOCK for read only block FS

PATCH In review Tudor Ambarus 2 participants 5 messages Apr 20, 2022 – May 5, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 ARM: configs: at91: Remove MTD_BLOCK and use MTD_UBI_BLOCK for read only block FS

Using mtdblock on raw flashes is generally a bad idea as it lacks wear-leveling, bad block handling or power-cut management. What happens when you use mtdblock and you change any sector of your mtdblockX device, is that it reads the whole corresponding eraseblock into the memory, erases the eraseblock, changes the sector in RAM, and writes the whole eraseblock back. If you have a power failure when the eraseblock is being erased, you lose all the block device sectors in it. The flash will likely decay soon because the eraseblocks will wear out.

Remove this archaic tool as its use case should rather be only for debug purposes. This means that write-capable block file systems like ext2, ext3, FAT, etc. will no longer be addressed with at91 defconfigs. For read only block filesystems like SquashFS, use MTD_UBI_BLOCK instead and benefit of UBI's bit-flip handling and wear-levelling.

---
 arch/arm/configs/at91_dt_defconfig | 2 +-
 arch/arm/configs/sama5_defconfig   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/configs/at91_dt_defconfig +1 -1
index 549d01be0b47..cf79510631ea 100644
@@ -50,13 +50,13 @@ CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_MTD=y
 CONFIG_MTD_TESTS=m
 CONFIG_MTD_CMDLINE_PARTS=y
-CONFIG_MTD_BLOCK=y
 CONFIG_MTD_DATAFLASH=y
 CONFIG_MTD_RAW_NAND=y
 CONFIG_MTD_NAND_ATMEL=y
 CONFIG_MTD_SPI_NOR=y
 CONFIG_MTD_UBI=y
 CONFIG_MTD_UBI_FASTMAP=y
+CONFIG_MTD_UBI_BLOCK=y
 CONFIG_BLK_DEV_LOOP=y
 CONFIG_BLK_DEV_RAM=y
 CONFIG_BLK_DEV_RAM_COUNT=4
arch/arm/configs/sama5_defconfig +1 -1
index 03dd80c2a19e..1c4c5a035518 100644
@@ -57,13 +57,13 @@ CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_MTD=y
 CONFIG_MTD_TESTS=m
 CONFIG_MTD_CMDLINE_PARTS=y
-CONFIG_MTD_BLOCK=y
 CONFIG_MTD_CFI=y
 CONFIG_MTD_RAW_NAND=y
 CONFIG_MTD_NAND_ATMEL=y
 CONFIG_MTD_SPI_NOR=y
 CONFIG_MTD_UBI=y
 CONFIG_MTD_UBI_FASTMAP=y
+CONFIG_MTD_UBI_BLOCK=y
 CONFIG_BLK_DEV_LOOP=y
 CONFIG_BLK_DEV_RAM=y
 CONFIG_BLK_DEV_RAM_COUNT=4
Signature · 1 line
2.25.1
#1 lore raw

PATCH 2/3 ARM: configs: at91: sama7: Enable MTD_UBI_FASTMAP

Use fastmap to accelerate the attach procedure.

---
 arch/arm/configs/sama7_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/configs/sama7_defconfig +2 -1
index 07b0494ef743..03652454274f 100644
@@ -94,6 +94,7 @@ CONFIG_MTD_NAND_ATMEL=y
 # CONFIG_MTD_NAND_ECC_SW_HAMMING is not set
 CONFIG_MTD_SPI_NOR=y
 CONFIG_MTD_UBI=y
+CONFIG_MTD_UBI_FASTMAP=y
 CONFIG_BLK_DEV_LOOP=y
 CONFIG_BLK_DEV_RAM=y
 CONFIG_BLK_DEV_RAM_COUNT=1
@@ -221,9 +222,9 @@ CONFIG_CRC_ITU_T=y
 CONFIG_DMA_CMA=y
 CONFIG_CMA_SIZE_MBYTES=32
 CONFIG_CMA_ALIGNMENT=9
+# CONFIG_DEBUG_MISC is not set
 # CONFIG_SECTION_MISMATCH_WARN_ONLY is not set
 CONFIG_DEBUG_FS=y
-# CONFIG_DEBUG_MISC is not set
 # CONFIG_SCHED_DEBUG is not set
 CONFIG_STACKTRACE=y
 # CONFIG_FTRACE is not set
Signature · 1 line
2.25.1
maintainer
#2 lore raw

Re: [PATCH 2/3] ARM: configs: at91: sama7: Enable MTD_UBI_FASTMAP

Quoted 20 lines · Tudor Ambarus

Use fastmap to accelerate the attach procedure.

---
  arch/arm/configs/sama7_defconfig | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/configs/sama7_defconfig +1 -0
index 07b0494ef743..03652454274f 100644
@@ -94,6 +94,7 @@ CONFIG_MTD_NAND_ATMEL=y
  # CONFIG_MTD_NAND_ECC_SW_HAMMING is not set
  CONFIG_MTD_SPI_NOR=y
  CONFIG_MTD_UBI=y
+CONFIG_MTD_UBI_FASTMAP=y
  CONFIG_BLK_DEV_LOOP=y
  CONFIG_BLK_DEV_RAM=y
  CONFIG_BLK_DEV_RAM_COUNT=1

arch/arm/configs/sama7_defconfig CONFIG_CRC_ITU_T=y · line 230

Quoted 10 lines
arch/arm/configs/sama7_defconfig +1 -1
@@ -221,9 +222,9 @@ CONFIG_CRC_ITU_T=y
  CONFIG_DMA_CMA=y
  CONFIG_CMA_SIZE_MBYTES=32
  CONFIG_CMA_ALIGNMENT=9
+# CONFIG_DEBUG_MISC is not set
  # CONFIG_SECTION_MISMATCH_WARN_ONLY is not set
  CONFIG_DEBUG_FS=y
-# CONFIG_DEBUG_MISC is not set
  # CONFIG_SCHED_DEBUG is not set
  CONFIG_STACKTRACE=y
  # CONFIG_FTRACE is not set

I understand the rationale of this change, but it should probably go into another patch or it's even sometimes done by arm-soc maintainers, so I removed it. No need to resend, I'll remove while applying.

Best regards,
Nicolas

Signature · 1 line
Nicolas Ferre
#3 lore raw

PATCH 3/3 ARM: configs: at91: sama7: Enable MTD_UBI_BLOCK

In reply to Tudor Ambarus

Address read only block filesystems like SquashFS, and use MTD_UBI_BLOCK to benefit of UBI's bit-flip handling and wear-levelling.

---
 arch/arm/configs/sama7_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/sama7_defconfig +1 -0
index 03652454274f..b267a49ddac5 100644
@@ -95,6 +95,7 @@ CONFIG_MTD_NAND_ATMEL=y
 CONFIG_MTD_SPI_NOR=y
 CONFIG_MTD_UBI=y
 CONFIG_MTD_UBI_FASTMAP=y
+CONFIG_MTD_UBI_BLOCK=y
 CONFIG_BLK_DEV_LOOP=y
 CONFIG_BLK_DEV_RAM=y
 CONFIG_BLK_DEV_RAM_COUNT=1
Signature · 1 line
2.25.1
maintainer Acked-by on v1 1/3
#4 lore raw
In reply to Tudor Ambarus
Quoted 9 lines · Tudor Ambarus

Using mtdblock on raw flashes is generally a bad idea as it lacks wear-leveling, bad block handling or power-cut management. What happens when you use mtdblock and you change any sector of your mtdblockX device, is that it reads the whole corresponding eraseblock into the memory, erases the eraseblock, changes the sector in RAM, and writes the whole eraseblock back. If you have a power failure when the eraseblock is being erased, you lose all the block device sectors in it. The flash will likely decay soon because the eraseblocks will wear out.

Quoted 7 lines

Remove this archaic tool as its use case should rather be only for debug purposes. This means that write-capable block file systems like ext2, ext3, FAT, etc. will no longer be addressed with at91 defconfigs. For read only block filesystems like SquashFS, use MTD_UBI_BLOCK instead and benefit of UBI's bit-flip handling and wear-levelling.

For the whole series:

and queued in at91-defconfig for 5.19.

Best regards,
Nicolas

Quoted 43 lines
---
  arch/arm/configs/at91_dt_defconfig | 2 +-
  arch/arm/configs/sama5_defconfig   | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/configs/at91_dt_defconfig +1 -1
index 549d01be0b47..cf79510631ea 100644
@@ -50,13 +50,13 @@ CONFIG_DEVTMPFS_MOUNT=y
  CONFIG_MTD=y
  CONFIG_MTD_TESTS=m
  CONFIG_MTD_CMDLINE_PARTS=y
-CONFIG_MTD_BLOCK=y
  CONFIG_MTD_DATAFLASH=y
  CONFIG_MTD_RAW_NAND=y
  CONFIG_MTD_NAND_ATMEL=y
  CONFIG_MTD_SPI_NOR=y
  CONFIG_MTD_UBI=y
  CONFIG_MTD_UBI_FASTMAP=y
+CONFIG_MTD_UBI_BLOCK=y
  CONFIG_BLK_DEV_LOOP=y
  CONFIG_BLK_DEV_RAM=y
  CONFIG_BLK_DEV_RAM_COUNT=4
arch/arm/configs/sama5_defconfig +1 -1
index 03dd80c2a19e..1c4c5a035518 100644
@@ -57,13 +57,13 @@ CONFIG_DEVTMPFS_MOUNT=y
  CONFIG_MTD=y
  CONFIG_MTD_TESTS=m
  CONFIG_MTD_CMDLINE_PARTS=y
-CONFIG_MTD_BLOCK=y
  CONFIG_MTD_CFI=y
  CONFIG_MTD_RAW_NAND=y
  CONFIG_MTD_NAND_ATMEL=y
  CONFIG_MTD_SPI_NOR=y
  CONFIG_MTD_UBI=y
  CONFIG_MTD_UBI_FASTMAP=y
+CONFIG_MTD_UBI_BLOCK=y
  CONFIG_BLK_DEV_LOOP=y
  CONFIG_BLK_DEV_RAM=y
  CONFIG_BLK_DEV_RAM_COUNT=4
Signature · 6 lines
Nicolas Ferre

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel