Skip to contentSkip to conversation

arch/x86/syscall: Remove TODO comment

PATCH Applied Ammar Faizi 2 participants 2 messages Apr 21, 2022 io_uring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arch/x86/syscall: Remove TODO comment

From: Ammar Faizi <[email protected]>

nolibc support for x86 32-bit has been added in commit b7d8dd8bbf5b855 ("arch/x86/syscall: Add x86 32-bit native syscall support"). But I forgot to remove the comment that says "We can't use CONFIG_NOLIBC for x86 (32-bit)".

Remove it.

---

Hi Jens,

Hopefully, this is the last x86 changes before v2.2 release.

 src/arch/x86/syscall.h | 6 ------
 1 file changed, 6 deletions(-)
src/arch/x86/syscall.h +0 -6
index 8cd24dd..43c576b 100644
@@ -144,12 +144,6 @@
 
 #else /* #if defined(__x86_64__) */
 
-/*
- * For x86 (32-bit), fallback to libc wrapper.
- * We can't use CONFIG_NOLIBC for x86 (32-bit) at the moment.
- *
- * TODO: Add x86 (32-bit) nolibc support.
- */
 #ifdef CONFIG_NOLIBC
 /**
  * Note for syscall registers usage (x86, 32-bit):
Signature · 1 line
Ammar Faizi
maintainer Applied
#1 lore raw
Quoted 8 lines · Ammar Faizi

From: Ammar Faizi <[email protected]>

nolibc support for x86 32-bit has been added in commit b7d8dd8bbf5b855 ("arch/x86/syscall: Add x86 32-bit native syscall support"). But I forgot to remove the comment that says "We can't use CONFIG_NOLIBC for x86 (32-bit)".

[...]

Applied, thanks!

[1/1] arch/x86/syscall: Remove TODO comment

      commit: 4ad972d6d1b16e4fb069fc2f006265942cf33103

Best regards,

Signature · 1 line
Jens Axboe