Skip to contentSkip to conversation

polarfire soc kconfig/maintainers updates

PATCH Superseded Conor Dooley 2 participants 7 messages Apr 21, 2022 – Apr 22, 2022 RISC-V

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v2 cover polarfire soc kconfig/maintainers updates

Hey Palmer,

As discussed, Kconfig.socs updated with the recently upstreamed drivers. I took the liberty of also adding them to the maintainers entry. The hwrng isnt in your tree, but was accepted today.
As you suggested, I added the vitesse phy driver in the kconfig.socs entry - lmk if you don't like what I did with the comment.

In v2 I have replaced Lewis as a maintainer with Daire, since he is the original author of the clock and pci drivers & a co-author on a bunch of other (upcoming) drivers.

Thanks,
Conor.

Conor Dooley (4):
riscv: select peripheral drivers for polarfire soc
riscv: config: enable the mailbox framework
riscv: select vitesse phy driver for polarfire soc
MAINTAINERS: add polarfire rng, pci and clock drivers

 MAINTAINERS                  | 5 ++++-
 arch/riscv/Kconfig.socs      | 5 +++++
 arch/riscv/configs/defconfig | 1 +
 3 files changed, 10 insertions(+), 1 deletion(-)
Signature · 7 lines
2.35.2


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
#1 lore raw

PATCH v2 1/4 riscv: select peripheral drivers for polarfire soc

Update the SOC_MICROCHIP_POLARFIRE kconfig entry to select, where applicable, the supported drivers for the SoC.

---
 arch/riscv/Kconfig.socs | 4 ++++
 1 file changed, 4 insertions(+)
arch/riscv/Kconfig.socs +4 -0
index 34592d00dde8..7f93c729d51c 100644
@@ -3,6 +3,10 @@ menu "SoC selection"
 config SOC_MICROCHIP_POLARFIRE
 	bool "Microchip PolarFire SoCs"
 	select MCHP_CLK_MPFS
+	select POLARFIRE_SOC_MAILBOX if MAILBOX
+	select POLARFIRE_SOC_SYS_CTRL if MAILBOX
+	select HW_RANDOM_POLARFIRE_SOC if POLARFIRE_SOC_SYS_CTRL
+	select PCIE_MICROCHIP_HOST if PCI_MSI && OF
 	select SIFIVE_PLIC
 	help
 	  This enables support for Microchip PolarFire SoC platforms.
Signature · 7 lines
2.35.2


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
#2 lore raw

PATCH v2 2/4 riscv: config: enable the mailbox framework

In reply to Conor Dooley

Add the mailbox framework so that the system controller drivers get compiled for PolarFire SoC.

---
 arch/riscv/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/riscv/configs/defconfig +1 -0
index 30e3017f22bc..e8472ffbb4dc 100644
@@ -100,6 +100,7 @@ CONFIG_VIRTIO_PCI=y
 CONFIG_VIRTIO_BALLOON=y
 CONFIG_VIRTIO_INPUT=y
 CONFIG_VIRTIO_MMIO=y
+CONFIG_MAILBOX=y
 CONFIG_RPMSG_CHAR=y
 CONFIG_RPMSG_VIRTIO=y
 CONFIG_EXT4_FS=y
Signature · 7 lines
2.35.2


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
#3 lore raw

PATCH v2 3/4 riscv: select vitesse phy driver for polarfire soc

In reply to Conor Dooley

There is a Vitesse VSC8662 on the Icicle Kit, until a better option exists, select it in Kconfig.socs for SOC_MICROCHIP_POLARFIRE.

---
Palmer: You said to put in a comment, but I have no idea how Kconfig expects a mid line comment to look. kbuild didn't seem to complain about what I did, but lmk if that's not what you meant.

---
 arch/riscv/Kconfig.socs | 1 +
 1 file changed, 1 insertion(+)
arch/riscv/Kconfig.socs +1 -0
index 7f93c729d51c..ff2b8b90db19 100644
@@ -8,6 +8,7 @@ config SOC_MICROCHIP_POLARFIRE
 	select HW_RANDOM_POLARFIRE_SOC if POLARFIRE_SOC_SYS_CTRL
 	select PCIE_MICROCHIP_HOST if PCI_MSI && OF
 	select SIFIVE_PLIC
+	select VITESSE_PHY # present on icicle kit
 	help
 	  This enables support for Microchip PolarFire SoC platforms.
 
Signature · 7 lines
2.35.2


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
#4 lore raw

Re: [PATCH v2 3/4] riscv: select vitesse phy driver for polarfire soc

I love your patch! Yet something to improve:

Hi Conor,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.18-rc3 next-20220421]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Conor-Dooley/polarfire-soc-kconfig-maintainers-updates/20220421-172138
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b253435746d9a4a701b5f09211b9c14d3370d0da
config: riscv-randconfig-r002-20220420 (https://download.01.org/0day-ci/archive/20220422/[email protected]/config)
compiler: riscv64-linux-gcc (GCC) 11.2.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/dc055eafe9cad74b3b01bed537c6f1496cddabe4
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Conor-Dooley/polarfire-soc-kconfig-maintainers-updates/20220421-172138 git checkout dc055eafe9cad74b3b01bed537c6f1496cddabe4
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>):

riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc8221_config_init':

>> vitesse.c:(.text+0x10): undefined reference to `mdiobus_write'
   riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc73xx_config_init':
   vitesse.c:(.text+0x30): undefined reference to `mdiobus_write'
>> riscv64-linux-ld: vitesse.c:(.text+0x44): undefined reference to `phy_modify'
>> riscv64-linux-ld: vitesse.c:(.text+0x58): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x74): undefined reference to `phy_modify'
   riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc739x_config_init':
   vitesse.c:(.text+0x96): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0xaa): undefined reference to `phy_modify'
   riscv64-linux-ld: vitesse.c:(.text+0xc2): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0xda): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0xee): undefined reference to `phy_modify'
   riscv64-linux-ld: vitesse.c:(.text+0x102): undefined reference to `phy_modify'
   riscv64-linux-ld: vitesse.c:(.text+0x11a): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x130): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x142): undefined reference to `phy_modify'
   riscv64-linux-ld: vitesse.c:(.text+0x156): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x16a): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x180): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x196): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x1ac): undefined reference to `phy_modify'
   riscv64-linux-ld: vitesse.c:(.text+0x1bc): undefined reference to `phy_modify'
   riscv64-linux-ld: vitesse.c:(.text+0x1d0): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x1e0): undefined reference to `phy_modify'
   riscv64-linux-ld: vitesse.c:(.text+0x1f4): undefined reference to `mdiobus_write'
   riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc73xx_write_page':
>> vitesse.c:(.text+0x226): undefined reference to `__mdiobus_write'
   riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc73xx_read_page':
>> vitesse.c:(.text+0x238): undefined reference to `__mdiobus_read'
   riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc738x_config_init':
   vitesse.c:(.text+0x260): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x274): undefined reference to `phy_modify'
   riscv64-linux-ld: vitesse.c:(.text+0x28c): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x2a4): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x2b8): undefined reference to `phy_modify'
   riscv64-linux-ld: vitesse.c:(.text+0x2cc): undefined reference to `phy_modify'
   riscv64-linux-ld: vitesse.c:(.text+0x2e4): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x2fa): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x30c): undefined reference to `phy_modify'
   riscv64-linux-ld: vitesse.c:(.text+0x320): undefined reference to `mdiobus_write'
>> riscv64-linux-ld: vitesse.c:(.text+0x332): undefined reference to `mdiobus_read'
   riscv64-linux-ld: vitesse.c:(.text+0x34e): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x362): undefined reference to `phy_modify'
   riscv64-linux-ld: vitesse.c:(.text+0x378): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x38c): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x3a2): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x3b8): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x3ce): undefined reference to `mdiobus_write'
   riscv64-linux-ld: drivers/net/phy/vitesse.o:vitesse.c:(.text+0x3e2): more undefined references to `mdiobus_write' follow
   riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc738x_config_init':
>> vitesse.c:(.text+0x438): undefined reference to `phy_modify'
   riscv64-linux-ld: vitesse.c:(.text+0x44e): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x462): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x476): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x48c): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x4a2): undefined reference to `mdiobus_write'
   riscv64-linux-ld: drivers/net/phy/vitesse.o:vitesse.c:(.text+0x4ba): more undefined references to `mdiobus_write' follow
   riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc738x_config_init':
   vitesse.c:(.text+0x53a): undefined reference to `phy_modify'
   riscv64-linux-ld: vitesse.c:(.text+0x54a): undefined reference to `phy_modify'
   riscv64-linux-ld: vitesse.c:(.text+0x55e): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x56e): undefined reference to `phy_modify'
   riscv64-linux-ld: vitesse.c:(.text+0x582): undefined reference to `mdiobus_write'
   riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc8601_config_init':
>> vitesse.c:(.text+0x5c4): undefined reference to `mdiobus_read'
   riscv64-linux-ld: vitesse.c:(.text+0x5e4): undefined reference to `mdiobus_write'
   riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc82xx_config_intr':
   vitesse.c:(.text+0x66c): undefined reference to `mdiobus_read'
   riscv64-linux-ld: vitesse.c:(.text+0x68a): undefined reference to `mdiobus_write'
   riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc824x_config_init':
   vitesse.c:(.text+0x6b8): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x6d8): undefined reference to `mdiobus_read'
   riscv64-linux-ld: vitesse.c:(.text+0x70c): undefined reference to `mdiobus_write'
   riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `.L39':
   vitesse.c:(.text+0x766): undefined reference to `mdiobus_read'
>> riscv64-linux-ld: vitesse.c:(.text+0x774): undefined reference to `phy_error'
   riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `.L40':
>> vitesse.c:(.text+0x788): undefined reference to `phy_trigger_machine'
   riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc82x4_config_aneg':
>> vitesse.c:(.text+0x7ca): undefined reference to `genphy_setup_forced'
   riscv64-linux-ld: vitesse.c:(.text+0x7fa): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x814): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x832): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x850): undefined reference to `mdiobus_write'
   riscv64-linux-ld: vitesse.c:(.text+0x876): undefined reference to `mdiobus_write'
   riscv64-linux-ld: drivers/net/phy/vitesse.o:vitesse.c:(.text+0x88a): more undefined references to `mdiobus_write' follow
   riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc82x4_config_aneg':
>> vitesse.c:(.text+0x8a4): undefined reference to `__genphy_config_aneg'
   riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `.L0 ':
>> vitesse.c:(.init.text+0xc): undefined reference to `phy_drivers_register'
>> riscv64-linux-ld: vitesse.c:(.exit.text+0xa): undefined reference to `phy_drivers_unregister'

Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for VITESSE_PHY Depends on NETDEVICES && PHYLIB
Selected by
- SOC_MICROCHIP_POLARFIRE

Signature · 2 lines
0-DAY CI Kernel Test Service
https://01.org/lkp
#5 lore raw

Re: [PATCH v2 3/4] riscv: select vitesse phy driver for polarfire soc

In reply to Conor Dooley
I love your patch! Yet something to improve:

Hi Conor,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.18-rc3 next-20220421]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Conor-Dooley/polarfire-soc-kconfig-maintainers-updates/20220421-172138
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b253435746d9a4a701b5f09211b9c14d3370d0da
config: riscv-randconfig-r005-20220420 (https://download.01.org/0day-ci/archive/20220422/[email protected]/config)
compiler: riscv64-linux-gcc (GCC) 11.2.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/dc055eafe9cad74b3b01bed537c6f1496cddabe4
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Conor-Dooley/polarfire-soc-kconfig-maintainers-updates/20220421-172138 git checkout dc055eafe9cad74b3b01bed537c6f1496cddabe4
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>):

init/main.o: in function `initcall_blacklisted':
main.c:(.text+0x4): relocation truncated to fit: R_RISCV_HI20 against `.LANCHOR0'
init/main.o: in function `set_reset_devices':
main.c:(.init.text+0x0): relocation truncated to fit: R_RISCV_HI20 against symbol reset_devices' defined in .sbss section in init/main.o init/main.o: in function run_init_process':
main.c:(.text.unlikely+0x4): relocation truncated to fit: R_RISCV_HI20 against `.LANCHOR0'
init/main.o: in function `rest_init':
(.ref.text+0x10): relocation truncated to fit: R_RISCV_HI20 against `kernel_init'
init/do_mounts.o: in function `rootfs_init_fs_context':
do_mounts.c:(.text+0x4): relocation truncated to fit: R_RISCV_HI20 against `.LC1'
init/do_mounts.o: in function `.L6':
do_mounts.c:(.init.text+0x48): relocation truncated to fit: R_RISCV_HI20 against `root_wait'
init/do_mounts_initrd.o: in function `no_initrd':
do_mounts_initrd.c:(.init.text+0x0): relocation truncated to fit: R_RISCV_HI20 against `.LANCHOR0'
init/initramfs.o: in function `wait_for_initramfs':
(.text+0x0): relocation truncated to fit: R_RISCV_HI20 against `initramfs_cookie'
init/initramfs.o: in function `error':
initramfs.c:(.init.text+0x0): relocation truncated to fit: R_RISCV_HI20 against `.LANCHOR0'
init/calibrate.o: in function `read_current_timer.isra.0':
calibrate.c:(.text+0x0): relocation truncated to fit: R_RISCV_HI20 against symbol clint_time_val' defined in .sbss section in drivers/clocksource/timer-clint.o init/calibrate.o: in function lpj_setup':
calibrate.c:(.init.text+0x12): additional relocation overflows omitted from the output
riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `phy_write':
vitesse.c:(.text+0x10): undefined reference to `mdiobus_write'
riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc73xx_config_init':
vitesse.c:(.text+0x3e): undefined reference to `phy_modify'
riscv64-linux-ld: vitesse.c:(.text+0x64): undefined reference to `phy_modify'
riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc739x_config_init':
vitesse.c:(.text+0x8e): undefined reference to `phy_modify'
riscv64-linux-ld: vitesse.c:(.text+0xbe): undefined reference to `phy_modify'
riscv64-linux-ld: vitesse.c:(.text+0xd2): undefined reference to `phy_modify'
riscv64-linux-ld: drivers/net/phy/vitesse.o:vitesse.c:(.text+0xfe): more undefined references to `phy_modify' follow
riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc739x_config_init':
vitesse.c:(.text+0x19e): undefined reference to `mdiobus_read'
riscv64-linux-ld: vitesse.c:(.text+0x1d0): undefined reference to `phy_modify'
riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc738x_config_init':
vitesse.c:(.text+0x200): undefined reference to `phy_modify'
riscv64-linux-ld: vitesse.c:(.text+0x214): undefined reference to `phy_modify'
riscv64-linux-ld: vitesse.c:(.text+0x240): undefined reference to `phy_modify'
riscv64-linux-ld: vitesse.c:(.text+0x278): undefined reference to `phy_modify'
riscv64-linux-ld: drivers/net/phy/vitesse.o:vitesse.c:(.text+0x2f4): more undefined references to `phy_modify' follow
riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc738x_config_init':

>> vitesse.c:(.text+0x46a): undefined reference to `phy_error'
   riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc824x_config_init':
   vitesse.c:(.text+0x48e): undefined reference to `phy_trigger_machine'
   riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc8601_config_init':
   vitesse.c:(.text+0x584): undefined reference to `genphy_setup_forced'
   riscv64-linux-ld: drivers/net/phy/vitesse.o: in function `vsc82x4_config_aneg':
   vitesse.c:(.text+0x636): undefined reference to `__genphy_config_aneg'
>> riscv64-linux-ld: vitesse.c:(.text+0x652): undefined reference to `__mdiobus_write'
>> riscv64-linux-ld: vitesse.c:(.text+0x664): undefined reference to `__mdiobus_read'

Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for VITESSE_PHY Depends on NETDEVICES && PHYLIB
Selected by
- SOC_MICROCHIP_POLARFIRE

Signature · 2 lines
0-DAY CI Kernel Test Service
https://01.org/lkp
#6 lore raw

PATCH v2 4/4 MAINTAINERS: add polarfire rng, pci and clock drivers

In reply to Conor Dooley

Hardware random, PCI and clock drivers for the PolarFire SoC have been upstreamed but are not covered by the MAINTAINERS entry, so add them. Daire is the author of the clock & PCI drivers, so add him as a maintainer in place of Lewis.

---
 MAINTAINERS | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
MAINTAINERS +4 -1
index fd768d43e048..d7602658b0a5 100644
@@ -16939,12 +16939,15 @@ N:	riscv
 K:	riscv
 
 RISC-V/MICROCHIP POLARFIRE SOC SUPPORT
-M:	Lewis Hanly <[email protected]>
 M:	Conor Dooley <[email protected]>
+M:	Daire McNamara <[email protected]>
 L:	[email protected]
 S:	Supported
 F:	arch/riscv/boot/dts/microchip/
+F:	drivers/char/hw_random/mpfs-rng.c
+F:	drivers/clk/microchip/clk-mpfs.c
 F:	drivers/mailbox/mailbox-mpfs.c
+F:	drivers/pci/controller/pcie-microchip-host.c
 F:	drivers/soc/microchip/
 F:	include/soc/microchip/mpfs.h
 
Signature · 7 lines
2.35.2


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv