Skip to contentSkip to conversation

dt-bindings: arm: Add bosch acc board

PATCH In review Philip Oberfichtner 2 participants 4 messages Apr 21, 2022 – Apr 27, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 dt-bindings: arm: Add bosch acc board

Add device tree binding for the Bosch ACC board, based on i.MX6 Dual.

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
index 08bdd30e511c..9deb568761c1 100644
@@ -192,6 +192,7 @@ properties:
         items:
           - enum:
               - auvidea,h100              # Auvidea H100
+              - bosch,imx6q-acc           # Bosch ACC i.MX6 Dual
               - boundary,imx6q-nitrogen6_max
               - boundary,imx6q-nitrogen6_som2
               - boundary,imx6q-nitrogen6x
Signature · 1 line
2.34.1
#1 lore raw

PATCH v2 2/2 ARM: dts: Add bosch acc board

Add device tree for the Bosch ACC board, based on i.MX6 Dual.

---

Changes in v2:
- fix style errors in node naming
- place regulators under root node
- remove superfluous status properties
- remove undocumented nodes and properties
- use color instead of label for leds
- fix other minor style issues

---
 arch/arm/boot/dts/Makefile            |   1 +
 arch/arm/boot/dts/imx6q-bosch-acc.dts | 978 ++++++++++++++++++++++++++
 2 files changed, 979 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx6q-bosch-acc.dts
arch/arm/boot/dts/Makefile +1 -0
index 7c16f8a2b738..a6eff45bfee3 100644
@@ -547,6 +547,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
 	imx6q-b450v3.dtb \
 	imx6q-b650v3.dtb \
 	imx6q-b850v3.dtb \
+	imx6q-bosch-acc.dtb \
 	imx6q-cm-fx6.dtb \
 	imx6q-cubox-i.dtb \
 	imx6q-cubox-i-emmc-som-v15.dtb \
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +978 -0

978 lines not on this page · raw message

Signature · 1 line
2.34.1
reviewer
#2 lore raw

Re: [PATCH v2 2/2] ARM: dts: Add bosch acc board

Hi Philip,

Quoted 5 lines · Philip Oberfichtner
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +4 -0
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>

arch/arm/boot/dts/imx6q-bosch-acc.dts line 25

Quoted 10 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +10 -0
+#include "imx6q.dtsi"
+
+/ {
+       model = "Bosch ACC";
+       compatible = "bosch,imx6q-acc", "fsl,imx6q";
+
+       aliases {
+               serial0 = &uart2;
+               serial1 = &uart1;
+

Unneeded blank line. Please remove it.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 29

Quoted 4 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +4 -0
+               i2c0 = &i2c1;
+               i2c1 = &i2c2;
+               i2c2 = &i2c3;
+               /* eMMC is connected to USDHC interface 4, but shall get the name 0 */

Unneeded comment. Please remove it.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 31

Quoted 2 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +2 -0
+               mmc0 = &usdhc4;
+               /* SC-Cards is connected to USDHC interface 2, but shall get the name 1 */

Ditto.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 39

Quoted 8 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +8 -0
+               mmc1 = &usdhc2;
+       };
+
+       backlight {
+               compatible = "pwm-backlight";
+               /* The last value is the PWM period in nano-seconds!
+                * -> 5 kHz = 200 µS = 200.000 ns
+                */

This is not the correct style for multi-line comments.

It should be:

/*
* bla bla
* bla bla
*/

Actually, I think you could just remove these comments.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 50

Quoted 11 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +11 -0
+               pwms = <&pwm1 0 200000>;
+               brightness-levels = <0 61 499 1706 4079 8022 13938 22237 33328 47623 65535>;
+               num-interpolated-steps = <10>;
+               default-brightness-level = <60>;
+               power-supply = <&reg_lcd0_pwr>;
+       };
+
+       refclk: refclk {
+               compatible = "fixed-factor-clock";
+               #clock-cells = <0>;
+

Unnecessary blank line.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 54

Quoted 4 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +4 -0
+               clocks = <&clks IMX6QDL_CLK_CKO2>;
+               clock-div = <1>;
+               clock-mult = <1>;
+               clock-output-names = "12mhz_refclk";

Ditto.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 132

Quoted 9 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +9 -0
+
+       gpio-leds {
+               compatible = "gpio-leds";
+               pinctrl-names = "default";
+               pinctrl-0 = <&pinctrl_reset_gpio_led>;
+
+               led-2 {
+                       color = <LED_COLOR_ID_RED>;
+                       gpios = <&gpio5 18 0>;

Better use GPIO label:

gpios = <&gpio5 18 GPIO_ACTIVE_HIGH>;

arch/arm/boot/dts/imx6q-bosch-acc.dts line 140

Quoted 4 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +4 -0
+       memory@10000000 {
+               device_type = "memory";
+               reg = <0x10000000 0x40000000>;
+       };

Please put the memory node below the alias.

Review

Quoted 2 lines
(quoted diff) +2 -0
+
+       supply_5P0: regulator-0 {

Please check arch/arm/boot/dts/imx6qdl-sabresd.dtsi for a reference on how to name the regulators.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 230

Quoted 2 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +2 -0
+       soc {
+               aips1: bus@2000000 {};

Why is this needed?

arch/arm/boot/dts/imx6q-bosch-acc.dts line 257

Quoted 4 lines

+&audmux {

arch/arm/boot/dts/imx6q-bosch-acc.dts new file +3 -0
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_audmux>;
+       status = "okay";

Is this needed? I don't see audio support present on this board.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 263

Quoted 4 lines

+&fec {

arch/arm/boot/dts/imx6q-bosch-acc.dts new file +3 -0
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_enet>;
+       status = "okay";

Please move the status property as the last one.

No need for blank lines.

Quoted 17 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +17 -0
+
+       clocks = <&clks IMX6QDL_CLK_ENET>,
+               <&clks IMX6QDL_CLK_ENET>,
+               <&clks IMX6QDL_CLK_ENET>,
+               <&clks IMX6QDL_CLK_ENET_REF>;
+       clock-names = "ipg", "ahb", "ptp", "enet_out";
+       phy-mode = "rmii";
+       phy-supply = <&supply_sw4_3V3>;
+       phy-handle = <&ethphy>;
+
+       mdio {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               ethphy: ethernet-phy@0 {
+                       compatible = "ethernet-phy-ieee802.3-c22";
+                       reg = <0>;
+                       interrupt-parent = <&gpio1>;

arch/arm/boot/dts/imx6q-bosch-acc.dts line 310

Quoted 10 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +9 -0
+                       interrupts = <23 IRQ_TYPE_EDGE_FALLING>;
+                       smsc,disable-energy-detect;
+               };
+       };
+};
 
+       lm75: sensor@49 {
+               pinctrl-names = "default";
+               pinctrl-0 = <&pinctrl_lm75>;
+

Uneeded blank line.

Quoted 13 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +13 -0
+       pmic: pmic@8 {
+               compatible = "fsl,pfuze100";
+               reg = <0x08>;
+
+               regulators {
+                       /*
+                        * VDD_CORE is connected to SW1 ABC
+                        * We need to define sw1ab and sw1c, but later it is controlled solely with
+                        * sw1c and therefore only this is named "VDD_SOC".
+                        * See PMIC datasheet Rev. 18, chapter 6.4.4.3.1: "The feedback and all
+                        * other controls are accomplished by use of pin SW1CFB and SW1C control
+                        * registers, respectively."
+                        * Setting min and max according to SOC datasheet

arch/arm/boot/dts/imx6q-bosch-acc.dts line 337

Quoted 10 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +10 -0
+                        */
+                       pmic_sw1abc: sw1c {
+                               regulator-name = "VDD_SOC (sw1abc)";
+                               regulator-min-microvolt = <1275000>;
+                               regulator-max-microvolt = <1500000>;
+                               regulator-boot-on;
+                               regulator-always-on;
+                               regulator-ramp-delay = <6250>;
+
+                               default-voltage = <1300000>;

This is not a valid property.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 347

Quoted 9 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +9 -0
+
+                       pmic_sw2: sw2 {
+                               regulator-name = "VDD_ARM (sw2)";
+                               regulator-min-microvolt = <1050000>;
+                               regulator-max-microvolt = <1500000>;
+                               regulator-boot-on;
+                               regulator-always-on;
+                               regulator-ramp-delay = <6250>;
+

Unneeded blank line.

Quoted 1 line

+ default-voltage = <1300000>;

Invalid property.

Quoted 8 lines

+&i2c3 {

arch/arm/boot/dts/imx6q-bosch-acc.dts new file +7 -0
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_i2c3>;
+       clock-frequency = <400000>;
+       status = "okay";
+
+       exc3000: touchscreen@2a {
+               compatible = "eeti,exc3000";

arch/arm/boot/dts/imx6q-bosch-acc.dts line 494

Quoted 10 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +10 -0
+               reg = <0x2a>;
+
+               pinctrl-names = "default";
+               pinctrl-0 = <&pinctrl_ctouch>;
+
+               interrupt-parent = <&gpio4>;
+               interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
+
+               touchscreen-size-x = <4096>;
+               touchscreen-size-y = <4096>;

Remove all the blank lines.

Quoted 1 line

+&iomuxc {

We usually put the iomuxc node as the last one.

Quoted 1 line

+ pinctrl_gpio_export_gpio_fixed_in: pinctrl-gpio-export-gpio-fixed-in-grp {

Not referenced anywhere.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 557

Quoted 10 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +10 -0
+               fsl,pins = <
+                       MX6QDL_PAD_KEY_COL2__GPIO4_IO10         0x80000000      /* CLEAR ALL */
+                       MX6QDL_PAD_CSI0_DAT4__GPIO5_IO22        0x80000000      /* DIG_IN_1 */
+                       MX6QDL_PAD_CSI0_DAT5__GPIO5_IO23        0x80000000      /* DIG_IN_2 */
+                       MX6QDL_PAD_SD3_CMD__GPIO7_IO02          0x80000000      /* PoE */
+                       MX6QDL_PAD_SD3_CLK__GPIO7_IO03          0x80000000      /* PoE T2P */
+               >;
+       };
+
+       pinctrl_reset_gpio_led: pinctrl-reset-gpio-led-pin {

pinctrl_reset_gpio_led: pinctrl-reset-gpio-led-grp

Review

Quoted 2 lines
(quoted diff) +2 -0
+               fsl,pins = <
+                       MX6QDL_PAD_CSI0_PIXCLK__GPIO5_IO18              0x80000000

Please avoid 0x80000000. Use the real pad setting instead.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 563

Quoted 4 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +4 -0
+               >;
+       };
+
+       pinctrl_gpio_export_gpio_fixed_out: pinctrl-gpio-export-gpio-fixed-out-grp {

This is not called anywhere. Please check globally.

Review

Quoted 2 lines
(quoted diff) +2 -0
+               fsl,pins = <
+                       MX6QDL_PAD_CSI0_DAT6__GPIO5_IO24        0x0001B0B0      /*  DIG_OUT_1 */

0x1b0b0 for consistency. Please check globally.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 617

Quoted 5 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +5 -0
+       pinctrl_i2c2: i2c2grp {
+               fsl,pins = <
+                       MX6QDL_PAD_KEY_COL3__I2C2_SCL 0x4001b810
+                       MX6QDL_PAD_KEY_ROW3__I2C2_SDA 0x4001b810
+                       /* NO SRE | 130 Ohm | SPEED LOW | Open Drain | PKE | PUE | 100k PU | HYS  */

No need for comment.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 623

Quoted 3 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +3 -0
+       pinctrl_i2c2_gpio: i2c2-gpiogrp {
+               fsl,pins = <
+                       MX6QDL_PAD_KEY_COL3__GPIO4_IO12 0x80000000

Avoid 0x80000000. Please check globally.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 830

Quoted 8 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +8 -0
+       lvds0: lvds-channel@0 {
+               fsl,data-mapping = "spwg";
+               fsl,data-width = <24>;
+
+               display-timings {
+                       native-mode = <&lvds0_timing0>;
+                       lvds0_timing0: timing0 {
+                               clock-frequency = <79479000>;

Please add this panel support in drivers/gpu/drm/panel/panel-simple.c and then reference its compatible here.

Quoted 2 lines

+&sdma {
+ fsl,sdma-ram-script-name = "imx/sdma/sdma-imx6q.bin";

Why is this needed?

Quoted 1 line

+ iram = <&ocram>;

Not a valid property for sdma.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 891

Quoted 6 lines

+&uart1 {

arch/arm/boot/dts/imx6q-bosch-acc.dts new file +5 -0
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_uart1>;
+       status = "okay";
+
+       rts-gpios = <&gpio7 8 0>;

Use GPIO label.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 899

Quoted 8 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +8 -0
+       linux,rs485-enabled-at-boot-time;
+       rs485-rx-during-tx;
+};
+
+&uart2 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_uart2>;
+       fsl,uart-has-rtscts;

s/ fsl,uart-has-rtscts/uart-has-rtscts;

arch/arm/boot/dts/imx6q-bosch-acc.dts line 915

Quoted 8 lines

+&usbh2 {

arch/arm/boot/dts/imx6q-bosch-acc.dts new file +7 -0
+       pinctrl-names = "idle", "active";
+       pinctrl-0 = <&pinctrl_usbh2_idle>;
+       pinctrl-1 = <&pinctrl_usbh2_active>;
+       status = "okay";
+
+       vbus-supply = <&reg_usb_h2_vbus>;
+       osc-clkgate-delay = <0x3>;

Not a valid property.

Quoted 1 line

+ pad-supply = <&vgen2_reg>;

Not a valid property.

#3 lore raw

Re: [PATCH v2 2/2] ARM: dts: Add bosch acc board

Hi Fabio,

thank you for the review. All comments will be incorporated in v3.

Quoted 341 lines · Fabio Estevam

Hi Philip,

Quoted 5 lines · Philip Oberfichtner
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +4 -0
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>

arch/arm/boot/dts/imx6q-bosch-acc.dts line 25

Quoted 10 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +10 -0
+#include "imx6q.dtsi"
+
+/ {
+       model = "Bosch ACC";
+       compatible = "bosch,imx6q-acc", "fsl,imx6q";
+
+       aliases {
+               serial0 = &uart2;
+               serial1 = &uart1;
+

Unneeded blank line. Please remove it.

Quoted 5 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +4 -0
+               i2c0 = &i2c1;
+               i2c1 = &i2c2;
+               i2c2 = &i2c3;
+               /* eMMC is connected to USDHC interface 4, but shall 

get the name 0 */

Unneeded comment. Please remove it.

Quoted 3 lines
(quoted diff) +2 -0
+               mmc0 = &usdhc4;
+               /* SC-Cards is connected to USDHC interface 2, but 

shall get the name 1 */

Ditto.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 39

Quoted 8 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +8 -0
+               mmc1 = &usdhc2;
+       };
+
+       backlight {
+               compatible = "pwm-backlight";
+               /* The last value is the PWM period in nano-seconds!
+                * -> 5 kHz = 200 µS = 200.000 ns
+                */

This is not the correct style for multi-line comments.

It should be:

/*
* bla bla
* bla bla
*/

Actually, I think you could just remove these comments.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 50

Quoted 12 lines
(quoted diff) +2 -0
+               pwms = <&pwm1 0 200000>;
+               brightness-levels = <0 61 499 1706 4079 8022 13938 

22237 33328 47623 65535>;

arch/arm/boot/dts/imx6q-bosch-acc.dts new file +9 -0
+               num-interpolated-steps = <10>;
+               default-brightness-level = <60>;
+               power-supply = <&reg_lcd0_pwr>;
+       };
+
+       refclk: refclk {
+               compatible = "fixed-factor-clock";
+               #clock-cells = <0>;
+

Unnecessary blank line.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 54

Quoted 4 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +4 -0
+               clocks = <&clks IMX6QDL_CLK_CKO2>;
+               clock-div = <1>;
+               clock-mult = <1>;
+               clock-output-names = "12mhz_refclk";

Ditto.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 132

Quoted 9 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +9 -0
+
+       gpio-leds {
+               compatible = "gpio-leds";
+               pinctrl-names = "default";
+               pinctrl-0 = <&pinctrl_reset_gpio_led>;
+
+               led-2 {
+                       color = <LED_COLOR_ID_RED>;
+                       gpios = <&gpio5 18 0>;

Better use GPIO label:

gpios = <&gpio5 18 GPIO_ACTIVE_HIGH>;

arch/arm/boot/dts/imx6q-bosch-acc.dts line 140

Quoted 4 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +4 -0
+       memory@10000000 {
+               device_type = "memory";
+               reg = <0x10000000 0x40000000>;
+       };

Please put the memory node below the alias.

Review

Quoted 2 lines
(quoted diff) +2 -0
+
+       supply_5P0: regulator-0 {

Please check arch/arm/boot/dts/imx6qdl-sabresd.dtsi for a reference on how to name the regulators.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 230

Quoted 2 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +2 -0
+       soc {
+               aips1: bus@2000000 {};

Why is this needed?

arch/arm/boot/dts/imx6q-bosch-acc.dts line 257

Quoted 4 lines

+&audmux {

arch/arm/boot/dts/imx6q-bosch-acc.dts new file +3 -0
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_audmux>;
+       status = "okay";

Is this needed? I don't see audio support present on this board.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 263

Quoted 4 lines

+&fec {

arch/arm/boot/dts/imx6q-bosch-acc.dts new file +3 -0
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_enet>;
+       status = "okay";

Please move the status property as the last one.

No need for blank lines.

Quoted 17 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +17 -0
+
+       clocks = <&clks IMX6QDL_CLK_ENET>,
+               <&clks IMX6QDL_CLK_ENET>,
+               <&clks IMX6QDL_CLK_ENET>,
+               <&clks IMX6QDL_CLK_ENET_REF>;
+       clock-names = "ipg", "ahb", "ptp", "enet_out";
+       phy-mode = "rmii";
+       phy-supply = <&supply_sw4_3V3>;
+       phy-handle = <&ethphy>;
+
+       mdio {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               ethphy: ethernet-phy@0 {
+                       compatible = "ethernet-phy-ieee802.3-c22";
+                       reg = <0>;
+                       interrupt-parent = <&gpio1>;

arch/arm/boot/dts/imx6q-bosch-acc.dts line 310

Quoted 10 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +9 -0
+                       interrupts = <23 IRQ_TYPE_EDGE_FALLING>;
+                       smsc,disable-energy-detect;
+               };
+       };
+};
 
+       lm75: sensor@49 {
+               pinctrl-names = "default";
+               pinctrl-0 = <&pinctrl_lm75>;
+

Uneeded blank line.

Quoted 18 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +8 -0
+       pmic: pmic@8 {
+               compatible = "fsl,pfuze100";
+               reg = <0x08>;
+
+               regulators {
+                       /*
+                        * VDD_CORE is connected to SW1 ABC
+                        * We need to define sw1ab and sw1c, but later 

it is controlled solely with
+ * sw1c and therefore only this is named
"VDD_SOC".
+ * See PMIC datasheet Rev. 18, chapter
6.4.4.3.1: "The feedback and all
+ * other controls are accomplished by use of
pin SW1CFB and SW1C control

(quoted diff) +2 -0
+                        * registers, respectively."
+                        * Setting min and max according to SOC 

datasheet

arch/arm/boot/dts/imx6q-bosch-acc.dts line 337

Quoted 10 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +10 -0
+                        */
+                       pmic_sw1abc: sw1c {
+                               regulator-name = "VDD_SOC (sw1abc)";
+                               regulator-min-microvolt = <1275000>;
+                               regulator-max-microvolt = <1500000>;
+                               regulator-boot-on;
+                               regulator-always-on;
+                               regulator-ramp-delay = <6250>;
+
+                               default-voltage = <1300000>;

This is not a valid property.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 347

Quoted 9 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +9 -0
+
+                       pmic_sw2: sw2 {
+                               regulator-name = "VDD_ARM (sw2)";
+                               regulator-min-microvolt = <1050000>;
+                               regulator-max-microvolt = <1500000>;
+                               regulator-boot-on;
+                               regulator-always-on;
+                               regulator-ramp-delay = <6250>;
+

Unneeded blank line.

Quoted 1 line

+ default-voltage = <1300000>;

Invalid property.

Quoted 8 lines

+&i2c3 {

arch/arm/boot/dts/imx6q-bosch-acc.dts new file +7 -0
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_i2c3>;
+       clock-frequency = <400000>;
+       status = "okay";
+
+       exc3000: touchscreen@2a {
+               compatible = "eeti,exc3000";

arch/arm/boot/dts/imx6q-bosch-acc.dts line 494

Quoted 10 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +10 -0
+               reg = <0x2a>;
+
+               pinctrl-names = "default";
+               pinctrl-0 = <&pinctrl_ctouch>;
+
+               interrupt-parent = <&gpio4>;
+               interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
+
+               touchscreen-size-x = <4096>;
+               touchscreen-size-y = <4096>;

Remove all the blank lines.

Quoted 1 line

+&iomuxc {

We usually put the iomuxc node as the last one.

Quoted 2 lines

+ pinctrl_gpio_export_gpio_fixed_in:
pinctrl-gpio-export-gpio-fixed-in-grp {

Not referenced anywhere.

Quoted 11 lines
(quoted diff) +2 -0
+               fsl,pins = <
+                       MX6QDL_PAD_KEY_COL2__GPIO4_IO10         

0x80000000 /* CLEAR ALL */
+ MX6QDL_PAD_CSI0_DAT4__GPIO5_IO22
0x80000000 /* DIG_IN_1 */
+ MX6QDL_PAD_CSI0_DAT5__GPIO5_IO23
0x80000000 /* DIG_IN_2 */
+ MX6QDL_PAD_SD3_CMD__GPIO7_IO02
0x80000000 /* PoE */
+ MX6QDL_PAD_SD3_CLK__GPIO7_IO03
0x80000000 /* PoE T2P */

arch/arm/boot/dts/imx6q-bosch-acc.dts line 557

Quoted 4 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +4 -0
+               >;
+       };
+
+       pinctrl_reset_gpio_led: pinctrl-reset-gpio-led-pin {

pinctrl_reset_gpio_led: pinctrl-reset-gpio-led-grp

Review

Quoted 3 lines
(quoted diff) +2 -0
+               fsl,pins = <
+                       MX6QDL_PAD_CSI0_PIXCLK__GPIO5_IO18             
 0x80000000

Please avoid 0x80000000. Use the real pad setting instead.

Quoted 5 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +4 -0
+               >;
+       };
+
+       pinctrl_gpio_export_gpio_fixed_out: 

pinctrl-gpio-export-gpio-fixed-out-grp {

This is not called anywhere. Please check globally.

Quoted 3 lines
(quoted diff) +2 -0
+               fsl,pins = <
+                       MX6QDL_PAD_CSI0_DAT6__GPIO5_IO24        

0x0001B0B0 /* DIG_OUT_1 */

0x1b0b0 for consistency. Please check globally.

Quoted 6 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +5 -0
+       pinctrl_i2c2: i2c2grp {
+               fsl,pins = <
+                       MX6QDL_PAD_KEY_COL3__I2C2_SCL 0x4001b810
+                       MX6QDL_PAD_KEY_ROW3__I2C2_SDA 0x4001b810
+                       /* NO SRE | 130 Ohm | SPEED LOW | Open Drain | 

PKE | PUE | 100k PU | HYS */

No need for comment.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 623

Quoted 3 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +3 -0
+       pinctrl_i2c2_gpio: i2c2-gpiogrp {
+               fsl,pins = <
+                       MX6QDL_PAD_KEY_COL3__GPIO4_IO12 0x80000000

Avoid 0x80000000. Please check globally.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 830

Quoted 8 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +8 -0
+       lvds0: lvds-channel@0 {
+               fsl,data-mapping = "spwg";
+               fsl,data-width = <24>;
+
+               display-timings {
+                       native-mode = <&lvds0_timing0>;
+                       lvds0_timing0: timing0 {
+                               clock-frequency = <79479000>;

Please add this panel support in drivers/gpu/drm/panel/panel-simple.c and then reference its compatible here.

Quoted 2 lines

+&sdma {
+ fsl,sdma-ram-script-name = "imx/sdma/sdma-imx6q.bin";

Why is this needed?

Quoted 1 line

+ iram = <&ocram>;

Not a valid property for sdma.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 891

Quoted 6 lines

+&uart1 {

arch/arm/boot/dts/imx6q-bosch-acc.dts new file +5 -0
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_uart1>;
+       status = "okay";
+
+       rts-gpios = <&gpio7 8 0>;

Use GPIO label.

arch/arm/boot/dts/imx6q-bosch-acc.dts line 899

Quoted 8 lines
arch/arm/boot/dts/imx6q-bosch-acc.dts new file +8 -0
+       linux,rs485-enabled-at-boot-time;
+       rs485-rx-during-tx;
+};
+
+&uart2 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_uart2>;
+       fsl,uart-has-rtscts;

s/ fsl,uart-has-rtscts/uart-has-rtscts;

arch/arm/boot/dts/imx6q-bosch-acc.dts line 915

Quoted 8 lines

+&usbh2 {

arch/arm/boot/dts/imx6q-bosch-acc.dts new file +7 -0
+       pinctrl-names = "idle", "active";
+       pinctrl-0 = <&pinctrl_usbh2_idle>;
+       pinctrl-1 = <&pinctrl_usbh2_active>;
+       status = "okay";
+
+       vbus-supply = <&reg_usb_h2_vbus>;
+       osc-clkgate-delay = <0x3>;

Not a valid property.

Quoted 1 line

+ pad-supply = <&vgen2_reg>;

Not a valid property.

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-22 Fax: +49-8142-66989-80    Email: [email protected]
=====================================================================