board: gateworks: venice: enable DM_SERIAL
PATCH v2 1/1 board: gateworks: venice: enable DM_SERIAL
Enable DM_SERIAL.
---
v2: rebase on imx/master
--- configs/imx8mm_venice_defconfig | 2 ++ configs/imx8mn_venice_defconfig | 2 ++ 2 files changed, 4 insertions(+)
configs/imx8mm_venice_defconfig +2 -0
@@ -110,6 +110,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y CONFIG_DM_REGULATOR=y CONFIG_DM_REGULATOR_FIXED=y CONFIG_DM_REGULATOR_GPIO=y +CONFIG_DM_SERIAL=y +# CONFIG_SPL_DM_SERIAL is not set CONFIG_MXC_UART=y CONFIG_SYSRESET=y CONFIG_SPL_SYSRESET=y
configs/imx8mn_venice_defconfig +2 -0
@@ -108,6 +108,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y CONFIG_DM_REGULATOR=y CONFIG_DM_REGULATOR_FIXED=y CONFIG_DM_REGULATOR_GPIO=y +CONFIG_DM_SERIAL=y +# CONFIG_SPL_DM_SERIAL is not set CONFIG_MXC_UART=y CONFIG_SYSRESET=y CONFIG_SPL_SYSRESET=y
Signature · 1 line
2.17.1
Hi Tim
Quoted 38 lines · Tim Harvey
Enable
DM_SERIAL.Signed-off-by Tim Harvey <[email protected]>---
v2: rebase on imx/master--- configs/imx8mm_venice_defconfig | 2 ++ configs/imx8mn_venice_defconfig | 2 ++ 2 files changed, 4 insertions(+)configs/imx8mm_venice_defconfig +2
-0@@ -110,6 +110,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y CONFIG_DM_REGULATOR=y CONFIG_DM_REGULATOR_FIXED=y CONFIG_DM_REGULATOR_GPIO=y +CONFIG_DM_SERIAL=y +# CONFIG_SPL_DM_SERIAL is not set CONFIG_MXC_UART=y CONFIG_SYSRESET=y CONFIG_SPL_SYSRESET=yconfigs/imx8mn_venice_defconfig +2
-1@@ -108,6 +108,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y CONFIG_DM_REGULATOR=y CONFIG_DM_REGULATOR_FIXED=y CONFIG_DM_REGULATOR_GPIO=y +CONFIG_DM_SERIAL=y +# CONFIG_SPL_DM_SERIAL is not set CONFIG_MXC_UART=y CONFIG_SYSRESET=y CONFIG_SPL_SYSRESET=y --
Quoted 2 lines
2.17.1
Should not select in your board kconfig?
Michael
Signature · 11 lines
Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 [email protected] __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 [email protected] www.amarulasolutions.com
Quoted 38 lines · Michael Nazzareno Trimarchi
Hi Tim
Quoted 34 lines · Tim Harvey
Enable
DM_SERIAL.Signed-off-by Tim Harvey <[email protected]>---
v2: rebase on imx/master--- configs/imx8mm_venice_defconfig | 2 ++ configs/imx8mn_venice_defconfig | 2 ++ 2 files changed, 4 insertions(+)configs/imx8mm_venice_defconfig +2
-0@@ -110,6 +110,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y CONFIG_DM_REGULATOR=y CONFIG_DM_REGULATOR_FIXED=y CONFIG_DM_REGULATOR_GPIO=y +CONFIG_DM_SERIAL=y +# CONFIG_SPL_DM_SERIAL is not set CONFIG_MXC_UART=y CONFIG_SYSRESET=y CONFIG_SPL_SYSRESET=yconfigs/imx8mn_venice_defconfig +2
-0@@ -108,6 +108,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y CONFIG_DM_REGULATOR=y CONFIG_DM_REGULATOR_FIXED=y CONFIG_DM_REGULATOR_GPIO=y +CONFIG_DM_SERIAL=y +# CONFIG_SPL_DM_SERIAL is not set
Quoted 9 lines
Quoted 6 lines
configs/imx8mn_venice_defconfig +0
-1CONFIG_MXC_UART=y CONFIG_SYSRESET=y CONFIG_SPL_SYSRESET=y --2.17.1
Should not select in your board kconfig?
Michael,
I don't think it really matters. The other conversions to DM_SERIAL are going in defconfigs as well.
Best Regards,
Tim
Hi
Quoted 51 lines · Tim Harvey
Quoted 38 lines · Michael Nazzareno Trimarchi
Hi Tim
Quoted 34 lines · Tim Harvey
Enable
DM_SERIAL.Signed-off-by Tim Harvey <[email protected]>---
v2: rebase on imx/master--- configs/imx8mm_venice_defconfig | 2 ++ configs/imx8mn_venice_defconfig | 2 ++ 2 files changed, 4 insertions(+)configs/imx8mm_venice_defconfig +2
-0@@ -110,6 +110,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y CONFIG_DM_REGULATOR=y CONFIG_DM_REGULATOR_FIXED=y CONFIG_DM_REGULATOR_GPIO=y +CONFIG_DM_SERIAL=y +# CONFIG_SPL_DM_SERIAL is not set CONFIG_MXC_UART=y CONFIG_SYSRESET=y CONFIG_SPL_SYSRESET=yconfigs/imx8mn_venice_defconfig +2
-0@@ -108,6 +108,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y CONFIG_DM_REGULATOR=y CONFIG_DM_REGULATOR_FIXED=y CONFIG_DM_REGULATOR_GPIO=y +CONFIG_DM_SERIAL=y +# CONFIG_SPL_DM_SERIAL is not setQuoted 9 lines
Quoted 6 lines
configs/imx8mn_venice_defconfig +0
-1CONFIG_MXC_UART=y CONFIG_SYSRESET=y CONFIG_SPL_SYSRESET=y --2.17.1
Should not select in your board kconfig?
Quoted 4 lines
Michael,
I don't think it really matters. The other conversions to
DM_SERIALare going in defconfigs as well.
Do we know why without # CONFIG_SPL_DM_SERIAL is not set
board hang?
Michael
Quoted 4 lines
Best Regards,
Tim
Signature · 11 lines
Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 [email protected] __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 [email protected] www.amarulasolutions.com
Quoted 55 lines · Michael Nazzareno Trimarchi
Hi
Quoted 51 lines · Tim Harvey
Quoted 47 lines · Michael Nazzareno Trimarchi
Hi Tim
Quoted 38 lines · Tim Harvey
Enable
DM_SERIAL.Signed-off-by Tim Harvey <[email protected]>---
v2: rebase on imx/master--- configs/imx8mm_venice_defconfig | 2 ++ configs/imx8mn_venice_defconfig | 2 ++ 2 files changed, 4 insertions(+)configs/imx8mm_venice_defconfig +2
-0@@ -110,6 +110,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y CONFIG_DM_REGULATOR=y CONFIG_DM_REGULATOR_FIXED=y CONFIG_DM_REGULATOR_GPIO=y +CONFIG_DM_SERIAL=y +# CONFIG_SPL_DM_SERIAL is not set CONFIG_MXC_UART=y CONFIG_SYSRESET=y CONFIG_SPL_SYSRESET=yconfigs/imx8mn_venice_defconfig +2
-1@@ -108,6 +108,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y CONFIG_DM_REGULATOR=y CONFIG_DM_REGULATOR_FIXED=y CONFIG_DM_REGULATOR_GPIO=y +CONFIG_DM_SERIAL=y +# CONFIG_SPL_DM_SERIAL is not set CONFIG_MXC_UART=y CONFIG_SYSRESET=y CONFIG_SPL_SYSRESET=y --Quoted 2 lines
2.17.1
Should not select in your board kconfig?
Quoted 9 lines
Quoted 4 lines
Michael,
I don't think it really matters. The other conversions to
DM_SERIALare going in defconfigs as well.Do we know why without #
CONFIG_SPL_DM_SERIALis not setboard hang?
Michael,
yes, if I also enable CONFIG_SPL_DM_SERIAL I get no serial output and the board hangs even if I add 'u-boot,dm-pre-proper' to uart2/pinctrl_uart2 nodes.
The requirement is to use DM_SERIAL in U-Boot, not in the SPL. I'm doing the same as was done for imx8mn-evk in ff1c7961d813 ("ARM: imx:
imx8mn-evk: enable DM_SERIAL").
Thus far, no ARCH_IMX8M boards have enabled CONFIG_SPL_DM_SERIAL so I suppose others have run into this as well but again the requirement is to enable CONFIG_DM_SERIAL not necessarily the SPL.
Best Regards,
Tim
Quoted 65 lines · Tim Harvey
Quoted 62 lines · Michael Nazzareno Trimarchi
Hi
Quoted 51 lines · Tim Harvey
Quoted 38 lines · Michael Nazzareno Trimarchi
Hi Tim
Quoted 34 lines · Tim Harvey
Enable
DM_SERIAL.Signed-off-by Tim Harvey <[email protected]>---
v2: rebase on imx/master--- configs/imx8mm_venice_defconfig | 2 ++ configs/imx8mn_venice_defconfig | 2 ++ 2 files changed, 4 insertions(+)configs/imx8mm_venice_defconfig +2
-0@@ -110,6 +110,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y CONFIG_DM_REGULATOR=y CONFIG_DM_REGULATOR_FIXED=y CONFIG_DM_REGULATOR_GPIO=y +CONFIG_DM_SERIAL=y +# CONFIG_SPL_DM_SERIAL is not set CONFIG_MXC_UART=y CONFIG_SYSRESET=y CONFIG_SPL_SYSRESET=yconfigs/imx8mn_venice_defconfig +2
-0@@ -108,6 +108,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y CONFIG_DM_REGULATOR=y CONFIG_DM_REGULATOR_FIXED=y CONFIG_DM_REGULATOR_GPIO=y +CONFIG_DM_SERIAL=y +# CONFIG_SPL_DM_SERIAL is not setQuoted 9 lines
Quoted 6 lines
configs/imx8mn_venice_defconfig +0
-1CONFIG_MXC_UART=y CONFIG_SYSRESET=y CONFIG_SPL_SYSRESET=y --2.17.1
Should not select in your board kconfig?
Quoted 4 lines
Michael,
I don't think it really matters. The other conversions to
DM_SERIALare going in defconfigs as well.Do we know why without #
CONFIG_SPL_DM_SERIALis not set
Quoted 8 lines
Quoted 2 lines
board hang?
Michael,
yes, if I also enable
CONFIG_SPL_DM_SERIALI get no serial output and the board hangs even if I add 'u-boot,dm-pre-proper' to uart2/pinctrl_uart2 nodes.
I see that Peng has a series [1] that moves imx8mn_evk, imx8mm_evk, imx8mp_evk to DM_SERIAL and has figured out the hang.
I will re-submit the patch also enabling DM_SERIAL for SPL.
Best Regards,
Tim
[1] https://patchwork.ozlabs.org/project/uboot/list/?series=294869
Quoted 12 lines
The requirement is to use
DM_SERIALin U-Boot, not in the SPL. I'm doing the same as was done for imx8mn-evk inff1c7961d813("ARM: imx:
imx8mn-evk: enableDM_SERIAL").Thus far, no
ARCH_IMX8Mboards have enabledCONFIG_SPL_DM_SERIALso I suppose others have run into this as well but again the requirement is to enableCONFIG_DM_SERIALnot necessarily the SPL.Best Regards,
Tim
PATCH v2 1/1 board: gateworks: venice: enable DM_SERIAL
In reply to Tim HarveyQuoted 2 lines
Enable
DM_SERIAL.Signed-off-by Tim Harvey <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================