Skip to contentSkip to conversation

mm/damon/reclaim: Fix the timer always stays active

PATCH Superseded Hailong Tu 3 participants 3 messages Apr 21, 2022

Subsystems (2)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Hailong Tu

author
#0 lore raw

PATCH v4 1/1 mm/damon/reclaim: Fix the timer always stays active

The timer stays active even if the reclaim mechanism is never enabled.
It is unnecessary overhead can be completely avoided by using module_param_cb() for enabled flag.

---
 mm/damon/reclaim.c | 26 ++++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)
mm/damon/reclaim.c +24 -2
index e34c4d0c4d93..e573e3f50064 100644
@@ -28,7 +28,6 @@
  * this.
  */
 static bool enabled __read_mostly;
-module_param(enabled, bool, 0600);
 
 /*
  * Time threshold for cold memory regions identification in microseconds.
@@ -358,11 +357,34 @@ static void damon_reclaim_timer_fn(struct work_struct *work)
 			enabled = last_enabled;
 	}
 
-	schedule_delayed_work(&damon_reclaim_timer,
+	if (enabled)
+		schedule_delayed_work(&damon_reclaim_timer,
 			msecs_to_jiffies(ENABLE_CHECK_INTERVAL_MS));
 }
 static DECLARE_DELAYED_WORK(damon_reclaim_timer, damon_reclaim_timer_fn);
 
+static int enabled_store(const char *val,
+		const struct kernel_param *kp)
+{
+	int rc = param_set_bool(val, kp);
+
+	if (rc < 0)
+		return rc;
+
+	if (enabled)
+		schedule_delayed_work(&damon_reclaim_timer, 0);
+
+	return 0;
+}
+
+static const struct kernel_param_ops enabled_param_ops = {
+	.set = enabled_store,
+	.get = param_get_bool,
+};
+
+module_param_cb(enabled, &enabled_param_ops, &enabled, 0600);
+MODULE_PARM_DESC(enabled, "Enable or disable DAMON_RECLAIM (default: disabled)");
+
 static int damon_reclaim_after_aggregation(struct damon_ctx *c)
 {
 	struct damos *s;
Signature · 1 line
2.25.1
maintainer
#1 lore raw

Hi Hailong,

Quoted 2 lines · On Thu, 21 Apr 2022 18:05:24 +0800 Hailong Tu <[email protected]> wrote:

The timer stays active even if the reclaim mechanism is never enabled.
It is unnecessary overhead can be completely avoided by using module_param_cb() for enabled flag.

As commented to the previous version[1], let's wrap the line at 75 columns. checkpatch.pl is also complaining.

[1] https://lore.kernel.org/linux-mm/[email protected]/

Quoted 40 lines
---
 mm/damon/reclaim.c | 26 ++++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)
mm/damon/reclaim.c +13 -2
index e34c4d0c4d93..e573e3f50064 100644
@@ -28,7 +28,6 @@
  * this.
  */
 static bool enabled __read_mostly;
-module_param(enabled, bool, 0600);
 
 /*
  * Time threshold for cold memory regions identification in microseconds.
@@ -358,11 +357,34 @@ static void damon_reclaim_timer_fn(struct work_struct *work)
 			enabled = last_enabled;
 	}
 
-	schedule_delayed_work(&damon_reclaim_timer,
+	if (enabled)
+		schedule_delayed_work(&damon_reclaim_timer,
 			msecs_to_jiffies(ENABLE_CHECK_INTERVAL_MS));
 }
 static DECLARE_DELAYED_WORK(damon_reclaim_timer, damon_reclaim_timer_fn);
 
+static int enabled_store(const char *val,
+		const struct kernel_param *kp)
+{
+	int rc = param_set_bool(val, kp);
+
+	if (rc < 0)
+		return rc;
+
+	if (enabled)
+		schedule_delayed_work(&damon_reclaim_timer, 0);
+

mm/damon/reclaim.c static void damon_reclaim_timer_fn(struct work_struct *work) · line 386

Quoted 10 lines
mm/damon/reclaim.c +10 -0
+	return 0;
+}
+
+static const struct kernel_param_ops enabled_param_ops = {
+	.set = enabled_store,
+	.get = param_get_bool,
+};
+
+module_param_cb(enabled, &enabled_param_ops, &enabled, 0600);
+MODULE_PARM_DESC(enabled, "Enable or disable DAMON_RECLAIM (default: disabled)");

I'd prefer 80 columns limit. Could you please put the string in the next line, like below?

    MODULE_PARM_DESC(enabled,
    		 "Enable or disable DAMON_RECLAIM (default: disabled)");

Thanks,
SJ

Quoted 7 lines
mm/damon/reclaim.c +1 -0
+
 static int damon_reclaim_after_aggregation(struct damon_ctx *c)
 {
 	struct damos *s;
Signature · 1 line
2.25.1
#2 lore raw

Hi, SJ
OK, I will modify it according to your comments

But I did checkpatch, there was no obvious style problem.
./scripts/checkpatch.pl --no-tree -f mm/damon/reclaim.c
total: 0 errors, 0 warnings, 425 lines checked
mm/damon/reclaim.c has no obvious style problems and is ready for submission.

Yours sincerely
Hailong

-----邮件原件-----
发件人: SeongJae Park <[email protected]>
发送时间: 2022年4月21日 20:41
收件人: Hailong Tu <[email protected]>
抄送: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; 涂海龙(Hailong) <[email protected]>; 李春鹏(punk li) <[email protected]>; 邱长平(Aaron Qiu) <[email protected]>; 范国泽(Gordon) <[email protected]>; 王德锁(DeSuo) <[email protected]>; 李志华(Terry) <[email protected]> 主题: Re: [PATCH V4] mm/damon/reclaim: Fix the timer always stays active

Hi Hailong,

Quoted 2 lines · On Thu, 21 Apr 2022 18:05:24 +0800 Hailong Tu <[email protected]> wrote:

The timer stays active even if the reclaim mechanism is never enabled.
It is unnecessary overhead can be completely avoided by using module_param_cb() for enabled flag.

As commented to the previous version[1], let's wrap the line at 75 columns. checkpatch.pl is also complaining.

[1] https://lore.kernel.org/linux-mm/[email protected]/

Quoted 42 lines
---
 mm/damon/reclaim.c | 26 ++++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)
mm/damon/reclaim.c index renamed from mm/damon/reclaim.c +0 -0

e34c4d0c4d93..e573e3f50064 100644

mm/damon/reclaim.c +14 -2
@@ -28,7 +28,6 @@
  * this.
  */
 static bool enabled __read_mostly;
-module_param(enabled, bool, 0600);
 
 /*
  * Time threshold for cold memory regions identification in microseconds.
@@ -358,11 +357,34 @@ static void damon_reclaim_timer_fn(struct work_struct *work)
                      enabled = last_enabled;
      }
 
-     schedule_delayed_work(&damon_reclaim_timer,
+     if (enabled)
+             schedule_delayed_work(&damon_reclaim_timer,
                      msecs_to_jiffies(ENABLE_CHECK_INTERVAL_MS));
 }
 static DECLARE_DELAYED_WORK(damon_reclaim_timer,
 damon_reclaim_timer_fn);
 
+static int enabled_store(const char *val,
+             const struct kernel_param *kp)
+{
+     int rc = param_set_bool(val, kp);
+
+     if (rc < 0)
+             return rc;
+
+     if (enabled)
+             schedule_delayed_work(&damon_reclaim_timer, 0);
+
+     return 0;

mm/damon/reclaim.c static void damon_reclaim_timer_fn(struct work_struct *work) · line 388

Quoted 10 lines
mm/damon/reclaim.c +10 -0
+}
+
+static const struct kernel_param_ops enabled_param_ops = {
+     .set = enabled_store,
+     .get = param_get_bool,
+};
+
+module_param_cb(enabled, &enabled_param_ops, &enabled, 0600);
+MODULE_PARM_DESC(enabled, "Enable or disable DAMON_RECLAIM (default:
+disabled)");

I'd prefer 80 columns limit. Could you please put the string in the next line, like below?

    MODULE_PARM_DESC(enabled,
                 "Enable or disable DAMON_RECLAIM (default: disabled)");

Thanks,
SJ

Quoted 6 lines
mm/damon/reclaim.c +1 -1
+
 static int damon_reclaim_after_aggregation(struct damon_ctx *c)  {
      struct damos *s;
--

2.25.1

________________________________
OPPO

本电子邮件及其附件含有OPPO公司的保密信息,仅限于邮件指明的收件人使用(包含个人及群组)。禁止任何人在未经授权的情况下以任何形式使用。如果您错收了本邮件,请立即以电子邮件通知发件人并删除本邮件及其附件。

This e-mail and its attachments contain confidential information from OPPO, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!