Skip to contentSkip to conversation

arm64: dts: qcom: db845c: Add support for MCP2517FD

PATCH Applied Vinod Koul 4 participants 4 messages Apr 21, 2022 – Apr 23, 2022

Subsystems (3)
lore
Share & tools
lore

Vinod Koul

author
#0 lore raw

PATCH v3 1/1 arm64: dts: qcom: db845c: Add support for MCP2517FD

Add support for onboard MCP2517FD SPI CAN transceiver attached to SPI0 of RB3.

---
Change in v3:
- change underscore(_) to dash (-) in can-clock node name
- remove superfluous status = okay in can node

Changes in v2:
- add cs and pinctrl config
- remove misleading comment

 arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 32 ++++++++++++++++++++++
 1 file changed, 32 insertions(+)
arch/arm64/boot/dts/qcom/sdm845-db845c.dts +32 -0
index 28fe45c5d516..d2ade684703d 100644
@@ -28,6 +28,13 @@ chosen {
 		stdout-path = "serial0:115200n8";
 	};
 
+	/* Fixed crystal oscillator dedicated to MCP2517FD */
+	clk40M: can-clock {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <40000000>;
+	};
+
 	dc12v: dc12v-regulator {
 		compatible = "regulator-fixed";
 		regulator-name = "DC12V";
@@ -746,6 +753,23 @@ codec {
 	};
 };
 
+&spi0 {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&qup_spi0_default>;
+	cs-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>;
+
+	can@0 {
+		compatible = "microchip,mcp2517fd";
+		reg = <0>;
+		clocks = <&clk40M>;
+		interrupts-extended = <&tlmm 104 IRQ_TYPE_LEVEL_LOW>;
+		spi-max-frequency = <10000000>;
+		vdd-supply = <&vdc_5v>;
+		xceiver-supply = <&vdc_5v>;
+	};
+};
+
 &spi2 {
 	/* On Low speed expansion */
 	label = "LS-SPI0";
@@ -1219,3 +1243,11 @@ ov7251_ep: endpoint {
 		};
 	};
 };
+
+/* PINCTRL - additions to nodes defined in sdm845.dtsi */
+&qup_spi0_default {
+	config {
+		drive-strength = <6>;
+		bias-disable;
+	};
+};
Signature · 1 line
2.34.1
Reviewed-by on v3 1/1
#2 lore raw
In reply to Vinod Koul
Quoted 4 lines · Vinod Koul

Add support for onboard MCP2517FD SPI CAN transceiver attached to SPI0 of RB3.

One comment below but irrespective of that,

Thanks,
Mani

Quoted 17 lines

---
Change in v3:
- change underscore(_) to dash (-) in can-clock node name
- remove superfluous status = okay in can node

Changes in v2:
- add cs and pinctrl config
- remove misleading comment

 arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 32 ++++++++++++++++++++++
 1 file changed, 32 insertions(+)
arch/arm64/boot/dts/qcom/sdm845-db845c.dts +0 -0
index 28fe45c5d516..d2ade684703d 100644

arch/arm64/boot/dts/qcom/sdm845-db845c.dts chosen { · line 32

Quoted 5 lines
arch/arm64/boot/dts/qcom/sdm845-db845c.dts +2 -0
@@ -28,6 +28,13 @@ chosen {
 		stdout-path = "serial0:115200n8";
 	};
 
+	/* Fixed crystal oscillator dedicated to MCP2517FD */
+	clk40M: can-clock {

clock@?

Quoted 47 lines
arch/arm64/boot/dts/qcom/sdm845-db845c.dts +30 -0
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <40000000>;
+	};
+
 	dc12v: dc12v-regulator {
 		compatible = "regulator-fixed";
 		regulator-name = "DC12V";
@@ -746,6 +753,23 @@ codec {
 	};
 };
 
+&spi0 {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&qup_spi0_default>;
+	cs-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>;
+
+	can@0 {
+		compatible = "microchip,mcp2517fd";
+		reg = <0>;
+		clocks = <&clk40M>;
+		interrupts-extended = <&tlmm 104 IRQ_TYPE_LEVEL_LOW>;
+		spi-max-frequency = <10000000>;
+		vdd-supply = <&vdc_5v>;
+		xceiver-supply = <&vdc_5v>;
+	};
+};
+
 &spi2 {
 	/* On Low speed expansion */
 	label = "LS-SPI0";
@@ -1219,3 +1243,11 @@ ov7251_ep: endpoint {
 		};
 	};
 };
+
+/* PINCTRL - additions to nodes defined in sdm845.dtsi */
+&qup_spi0_default {
+	config {
+		drive-strength = <6>;
+		bias-disable;
+	};
+};
Signature · 1 line
2.34.1
#3 lore raw

Re: (subset) [PATCH v3] arm64: dts: qcom: db845c: Add support for MCP2517FD

In reply to Vinod Koul
Quoted 4 lines · Vinod Koul

Add support for onboard MCP2517FD SPI CAN transceiver attached to SPI0 of RB3.

Applied, thanks!

[1/1] arm64: dts: qcom: db845c: Add support for MCP2517FD

      commit: cb29e7106d4ee7bc3860fc65d28b6d7d0b71c0f8

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>