Skip to contentSkip to conversation

spl_imx_romapi: Remove extraneous character

PATCH In review Fabio Estevam 4 participants 4 messages Apr 21, 2022 – Jul 12, 2022

Subsystems (3)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 spl_imx_romapi: Remove extraneous character

From: Fabio Estevam <[email protected]>

Currently the following output is shown:
...
Trying to boot from BOOTROM
Find img info 0x&48020a00, size 872
...

Remove the extraneous "&" character, so that the correct output can be seen.

---
 arch/arm/mach-imx/spl_imx_romapi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/spl_imx_romapi.c +1 -1
index c47f5a6bdb44..2996d2761690 100644
@@ -306,7 +306,7 @@ static int spl_romapi_load_image_stream(struct spl_image_info *spl_image,
 	}
 
 	imagesize = img_info_size(phdr);
-	printf("Find img info 0x&%p, size %d\n", phdr, imagesize);
+	printf("Find img info 0x%p, size %d\n", phdr, imagesize);
 
 	if (p - phdr < imagesize) {
 		imagesize -= p - phdr;
Signature · 1 line
2.25.1
Acked-by Peng Fan on v1 1/1
#2 lore raw
In reply to Fabio Estevam
Quoted 8 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Currently the following output is shown:
...
Trying to boot from BOOTROM
Find img info 0x&48020a00, size 872
...

Quoted 4 lines

Remove the extraneous "&" character, so that the correct output can be seen.

Quoted 18 lines
---
  arch/arm/mach-imx/spl_imx_romapi.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/spl_imx_romapi.c +1 -1
index c47f5a6bdb44..2996d2761690 100644
@@ -306,7 +306,7 @@ static int spl_romapi_load_image_stream(struct spl_image_info *spl_image,
  	}
 
  	imagesize = img_info_size(phdr);
-	printf("Find img info 0x&%p, size %d\n", phdr, imagesize);
+	printf("Find img info 0x%p, size %d\n", phdr, imagesize);
 
  	if (p - phdr < imagesize) {
  		imagesize -= p - phdr;
#3 lore raw
Quoted 30 lines · Peng Fan (OSS)
Quoted 8 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Currently the following output is shown:
...
Trying to boot from BOOTROM
Find img info 0x&48020a00, size 872
...

Quoted 4 lines

Remove the extraneous "&" character, so that the correct output can be seen.

Quoted 11 lines
---
  arch/arm/mach-imx/spl_imx_romapi.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/spl_imx_romapi.c +0 -0
index c47f5a6bdb44..2996d2761690 100644
@@ -306,7 +306,7 @@ static int spl_romapi_load_image_stream(struct spl_image_info *spl_image,
      }
 
Quoted 7 lines

arch/arm/mach-imx/spl_imx_romapi.c static int spl_romapi_load_image_stream(struct spl_image_info *spl_image, · line 312

Quoted 7 lines
arch/arm/mach-imx/spl_imx_romapi.c +1 -1
      imagesize = img_info_size(phdr);
-     printf("Find img info 0x&%p, size %d\n", phdr, imagesize);
+     printf("Find img info 0x%p, size %d\n", phdr, imagesize);
 
      if (p - phdr < imagesize) {
              imagesize -= p - phdr;

Stefano and Fabio,

This patch was ack'd but never seemed to make it into the imx tree and I don't see it in Peng's queue on patchwork any more.

Now that the merge window is open, when are you planning on working through the current imx patch queue? I believe there are several patches that will need to be rebased due to collisions.

Best Regards,

Tim