iotests/108: Fix when missing user_allow_other
PATCH 1/1 iotests/108: Fix when missing user_allow_other
FUSE exports' allow-other option defaults to "auto", which means that it will try passing allow_other as a mount option, and fall back to not using it when an error occurs. We make no effort to hide fusermount's error message (because it would be difficult, and because users might want to know about the fallback occurring), and so when allow_other does not work (primarily when /etc/fuse.conf does not contain user_allow_other), this error message will appear and break the reference output.
We do not need allow_other here, though, so we can just pass allow-other=off to fix that.
--- tests/qemu-iotests/108 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/qemu-iotests/108 +1 -1
@@ -326,7 +326,7 @@ else $QSD \ --blockdev file,node-name=export-node,filename="$TEST_IMG" \ - --export fuse,id=fuse-export,node-name=export-node,mountpoint="$export_mp",writable=on,growable=off \ + --export fuse,id=fuse-export,node-name=export-node,mountpoint="$export_mp",writable=on,growable=off,allow-other=off \ --pidfile "$TEST_DIR/qsd.pid" \ --daemonize fi
Signature · 1 line
2.35.1
Quoted 9 lines · Hanna Reitz
FUSE exports' allow-other option defaults to "auto", which means that it will try passing
allow_otheras a mount option, and fall back to not using it when an error occurs. We make no effort to hide fusermount's error message (because it would be difficult, and because users might want to know about the fallback occurring), and so whenallow_otherdoes not work (primarily when/etc/fuse.confdoes not containuser_allow_other), this error message will appear and break the reference output.
Quoted 5 lines
We do not need
allow_otherhere, though, so we can just pass allow-other=off to fix that.Reported-by Markus Armbruster <[email protected]>Signed-off-by Hanna Reitz <[email protected]>
Thanks!
Quoted 9 lines · Hanna Reitz
FUSE exports' allow-other option defaults to "auto", which means that it will try passing
allow_otheras a mount option, and fall back to not using it when an error occurs. We make no effort to hide fusermount's error message (because it would be difficult, and because users might want to know about the fallback occurring), and so whenallow_otherdoes not work (primarily when/etc/fuse.confdoes not containuser_allow_other), this error message will appear and break the reference output.
Quoted 8 lines
We do not need
allow_otherhere, though, so we can just pass allow-other=off to fix that.Reported-by Markus Armbruster <[email protected]>Signed-off-by Hanna Reitz <[email protected]>--- tests/qemu-iotests/108 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
I hit this today as well, and your fix works.
Signature · 3 lines
Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org