Skip to contentSkip to conversation

drm/rockchip: cdn-dp: change rk3399_cdn_dp from global to static

PATCH Applied Tom Rix 2 participants 2 messages Apr 21, 2022 – May 2, 2022

Subsystems (4)
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 drm/rockchip: cdn-dp: change rk3399_cdn_dp from global to static

Smatch reports this issue
cdn-dp-core.c:51:20: warning: symbol 'rk3399_cdn_dp' was not declared. Should it be static?

rk3399_cdn_dp is only used in cdn-dp-core.c so change its storge-class specifier to static.

---
 drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/rockchip/cdn-dp-core.c +1 -1
index d3e6c93739bf..ce67c9daa2b1 100644
@@ -48,7 +48,7 @@ struct cdn_dp_data {
 	u8 max_phy;
 };
 
-struct cdn_dp_data rk3399_cdn_dp = {
+static struct cdn_dp_data rk3399_cdn_dp = {
 	.max_phy = 2,
 };
 
Signature · 1 line
2.27.0
maintainer Applied
#1 lore raw
Quoted 5 lines · Tom Rix

Smatch reports this issue
cdn-dp-core.c:51:20: warning: symbol 'rk3399_cdn_dp' was not declared. Should it be static?

rk3399_cdn_dp is only used in cdn-dp-core.c so change its storge-class specifier to static.

Applied, thanks!

[1/1] drm/rockchip: cdn-dp: change rk3399_cdn_dp from global to static

      commit: 7494b1ed1df414e43dc8429f0c016b2054b1b5da

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>