Skip to contentSkip to conversation

clk: at91: generated: consider range when calculating best rate

PATCH Applied Codrin Ciubotariu 3 participants 7 messages Apr 13, 2022 – May 17, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: at91: generated: consider range when calculating best rate

clk_generated_best_diff() helps in finding the parent and the divisor to compute a rate closest to the required one. However, it doesn't take into account the request's range for the new rate. Make sure the new rate is within the required range.

Fixes 8a8f4bf0c480 ("clk: at91: clk-generated: create function to find best_diff")
---
 drivers/clk/at91/clk-generated.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/clk/at91/clk-generated.c +4 -0
index 23cc8297ec4c..d429ba52a719 100644
@@ -117,6 +117,10 @@ static void clk_generated_best_diff(struct clk_rate_request *req,
 		tmp_rate = parent_rate;
 	else
 		tmp_rate = parent_rate / div;
+
+	if (tmp_rate < req->min_rate || tmp_rate > req->max_rate)
+		return;
+
 	tmp_diff = abs(req->rate - tmp_rate);
 
 	if (*best_diff < 0 || *best_diff >= tmp_diff) {
Signature · 1 line
2.32.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Codrin Ciubotariu

clk_generated_best_diff() helps in finding the parent and the divisor to compute a rate closest to the required one. However, it doesn't take into account the request's range for the new rate. Make sure the new rate is within the required range.

Fixes 8a8f4bf0c480 ("clk: at91: clk-generated: create function to find best_diff")
Quoted 22 lines
---
 drivers/clk/at91/clk-generated.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/clk/at91/clk-generated.c +4 -1
index 23cc8297ec4c..d429ba52a719 100644
@@ -117,6 +117,10 @@ static void clk_generated_best_diff(struct clk_rate_request *req,
                tmp_rate = parent_rate;
        else
                tmp_rate = parent_rate / div;
+
+       if (tmp_rate < req->min_rate || tmp_rate > req->max_rate)
+               return;
+
        tmp_diff = abs(req->rate - tmp_rate);
 
        if (*best_diff < 0 || *best_diff >= tmp_diff) {
--

2.32.0

maintainer
#2 lore raw
In reply to Codrin Ciubotariu

Quoting Codrin Ciubotariu (2022-04-13 00:13:18)

Quoted 8 lines

clk_generated_best_diff() helps in finding the parent and the divisor to compute a rate closest to the required one. However, it doesn't take into account the request's range for the new rate. Make sure the new rate is within the required range.

Fixes 8a8f4bf0c480 ("clk: at91: clk-generated: create function to find best_diff")

---

Is this fixing anything real or it's just a thing that you noticed and sent a patch to fix?

Quoted 18 lines
 drivers/clk/at91/clk-generated.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/clk/at91/clk-generated.c +4 -0
index 23cc8297ec4c..d429ba52a719 100644
@@ -117,6 +117,10 @@ static void clk_generated_best_diff(struct clk_rate_request *req,
                tmp_rate = parent_rate;
        else
                tmp_rate = parent_rate / div;
+
+       if (tmp_rate < req->min_rate || tmp_rate > req->max_rate)
+               return;
+
        tmp_diff = abs(req->rate - tmp_rate);
 
        if (*best_diff < 0 || *best_diff >= tmp_diff) {
#3 lore raw
Quoted 6 lines · Stephen Boyd

Quoting Codrin Ciubotariu (2022-04-13 00:13:18)

Quoted 5 lines

clk_generated_best_diff() helps in finding the parent and the divisor to compute a rate closest to the required one. However, it doesn't take into account the request's range for the new rate. Make sure the new rate is within the required range.

Quoted 6 lines
Quoted 3 lines
Fixes 8a8f4bf0c480 ("clk: at91: clk-generated: create function to find best_diff")

---

Is this fixing anything real or it's just a thing that you noticed and sent a patch to fix?

It fixes the clk_set_min/max_rate() calls to a generated clock. Do you want me to add this fact in the commit description?

Quoted 19 lines
Quoted 19 lines
  drivers/clk/at91/clk-generated.c | 4 ++++
  1 file changed, 4 insertions(+)
drivers/clk/at91/clk-generated.c +4 -0
index 23cc8297ec4c..d429ba52a719 100644
@@ -117,6 +117,10 @@ static void clk_generated_best_diff(struct clk_rate_request *req,
                 tmp_rate = parent_rate;
         else
                 tmp_rate = parent_rate / div;
+
+       if (tmp_rate < req->min_rate || tmp_rate > req->max_rate)
+               return;
+
         tmp_diff = abs(req->rate - tmp_rate);
 
         if (*best_diff < 0 || *best_diff >= tmp_diff) {
maintainer
#4 lore raw

Quoting [email protected] (2022-04-26 00:24:15)

Quoted 11 lines · Stephen Boyd
Quoted 10 lines

Quoting Codrin Ciubotariu (2022-04-13 00:13:18)

Quoted 8 lines

clk_generated_best_diff() helps in finding the parent and the divisor to compute a rate closest to the required one. However, it doesn't take into account the request's range for the new rate. Make sure the new rate is within the required range.

Fixes 8a8f4bf0c480 ("clk: at91: clk-generated: create function to find best_diff")

---

Quoted 6 lines
Quoted 2 lines

Is this fixing anything real or it's just a thing that you noticed and sent a patch to fix?

It fixes the clk_set_min/max_rate() calls to a generated clock. Do you want me to add this fact in the commit description?

I wanted to know if there are clk_set_min/max_rate() calls on this clk. Are there?

#5 lore raw
Quoted 17 lines · Stephen Boyd

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoting [email protected] (2022-04-26 00:24:15)

Quoted 14 lines · Stephen Boyd
Quoted 12 lines

Quoting Codrin Ciubotariu (2022-04-13 00:13:18)

Quoted 8 lines

clk_generated_best_diff() helps in finding the parent and the divisor to compute a rate closest to the required one. However, it doesn't take into account the request's range for the new rate. Make sure the new rate is within the required range.

Fixes 8a8f4bf0c480 ("clk: at91: clk-generated: create function to find best_diff")

---

Is this fixing anything real or it's just a thing that you noticed and sent a patch to fix?

Quoted 6 lines
Quoted 3 lines

It fixes the clk_set_min/max_rate() calls to a generated clock. Do you want me to add this fact in the commit description?

I wanted to know if there are clk_set_min/max_rate() calls on this clk. Are there?

Yes, there are:
https://elixir.bootlin.com/linux/latest/source/sound/soc/atmel/mchp-spdifrx.c#L450

Best regards,
Codrin

maintainer Applied
#6 lore raw
In reply to Codrin Ciubotariu

Quoting Codrin Ciubotariu (2022-04-13 00:13:18)

Quoted 8 lines

clk_generated_best_diff() helps in finding the parent and the divisor to compute a rate closest to the required one. However, it doesn't take into account the request's range for the new rate. Make sure the new rate is within the required range.

Fixes 8a8f4bf0c480 ("clk: at91: clk-generated: create function to find best_diff")

---

Applied to clk-fixes