Skip to contentSkip to conversation

ALSA: hda/realtek: Fix mute led issue on thinkpad with cs35l41 s-codec

PATCH Applied Hui Wang 2 participants 2 messages Apr 22, 2022 Sound

lore
Share & tools
lore

Hui Wang

author
#0 lore raw

PATCH 1/1 ALSA: hda/realtek: Fix mute led issue on thinkpad with cs35l41 s-codec

The quirk ALC287_FIXUP_CS35L41_I2C_2 needs to chain the quirk ALC269_FIXUP_THINKPAD_ACPI, otherwise the mute led will not work if a thinkpad machine applies that quirk.

And it will be safe if non-thinkpad machines apply that quirk since hda_fixup_thinkpad_acpi() will check and return in this case.

Fixes ae7abe36e352e ("ALSA: hda/realtek: Add CS35L41 support for Thinkpad laptops")
---
 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)
sound/pci/hda/patch_realtek.c +2 -0
index 4c0c593f3c0a..f9c3b2c9ca12 100644
@@ -8769,6 +8769,8 @@ static const struct hda_fixup alc269_fixups[] = {
 	[ALC287_FIXUP_CS35L41_I2C_2] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = cs35l41_fixup_i2c_two,
+		.chained = true,
+		.chain_id = ALC269_FIXUP_THINKPAD_ACPI,
 	},
 	[ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED] = {
 		.type = HDA_FIXUP_FUNC,
Signature · 1 line
2.25.1
Applied
#1 lore raw
Quoted 10 lines · Hui Wang

The quirk ALC287_FIXUP_CS35L41_I2C_2 needs to chain the quirk ALC269_FIXUP_THINKPAD_ACPI, otherwise the mute led will not work if a thinkpad machine applies that quirk.

And it will be safe if non-thinkpad machines apply that quirk since hda_fixup_thinkpad_acpi() will check and return in this case.

Fixes ae7abe36e352e ("ALSA: hda/realtek: Add CS35L41 support for Thinkpad laptops")

Thanks, applied.

Takashi