Skip to contentSkip to conversation

Subject: x86/vdso/vdso2c: Memory Leak fix, Fix leak of variable name in vdso2c.c

PATCH In review ashamedbit 2 participants 2 messages Apr 22, 2022

Subsystems (3)
lore
Share & tools
lore

ashamedbit

author
#0 lore raw

PATCH 1/1 Subject: x86/vdso/vdso2c: Memory Leak fix, Fix leak of variable name in vdso2c.c

The file vdso2c.c contains a memory leak of variable 'name'. This leak was detected by ASAN(AddressSanitizer) on local builds. A tool called AddressWatcher automatically attempts to fix memory leaks suggested by ASAN. The fix has been inserted to stop the memory leak in the file vdso2c.c.

---
 arch/x86/entry/vdso/vdso2c.c | 1 +
 1 file changed, 1 insertion(+)
arch/x86/entry/vdso/vdso2c.c +1 -0
index edfe9780f6d1..b3decd59c98e 100644
@@ -246,6 +246,7 @@ int main(int argc, char **argv)
 
 	go(raw_addr, raw_len, stripped_addr, stripped_len, outfile, name);
 
+	free(name);
 	munmap(raw_addr, raw_len);
 	munmap(stripped_addr, stripped_len);
 	fclose(outfile);
Signature · 1 line
2.25.1
#1 lore raw
Quoted 5 lines · ashamedbit

The file vdso2c.c contains a memory leak of variable 'name'. This leak was detected by ASAN(AddressSanitizer) on local builds. A tool called AddressWatcher automatically attempts to fix memory leaks suggested by ASAN. The fix has been inserted to stop the memory leak in the file vdso2c.c.

I think you need to fix your tool, this is 3 lines before the program terminates. Please explain how that is a leak?