Skip to contentSkip to conversation

libuuid: improve cache handling

PATCH In review Michael Trapp 2 participants 2 messages Apr 22, 2022 – Apr 29, 2022 Util-Linux package

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libuuid: improve cache handling

From: d032747 <[email protected]>

Short running applications with a few UUID request don't need a large cache. Therefore increment the cache size over runtime.

---
 libuuid/src/gen_uuid.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
libuuid/src/gen_uuid.c +10 -1
index 76d5371ea..805b40d90 100644
@@ -443,6 +443,7 @@ int __uuid_generate_time(uuid_t out, int *num)
 static int uuid_generate_time_generic(uuid_t out) {
 #ifdef HAVE_TLS
 	THREAD_LOCAL int		num = 0;
+	THREAD_LOCAL int		cache_size = 1;
 	THREAD_LOCAL struct uuid	uu;
 	THREAD_LOCAL time_t		last_time = 0;
 	time_t				now;
@@ -453,7 +454,15 @@ static int uuid_generate_time_generic(uuid_t out) {
 			num = 0;
 	}
 	if (num <= 0) {
-		num = 1000000;
+		/*
+		 * num + OP_BULK provides a local cache in each application.
+		 * Start with a small cache size to cover short running applications
+		 * and increment the cache size over the runntime.
+		 */
+		if (cache_size < 1000000)
+			cache_size *= 10;
+		num = cache_size;
+
 		if (get_uuid_via_daemon(UUIDD_OP_BULK_TIME_UUID,
 					out, &num) == 0) {
 			last_time = time(NULL);
Signature · 1 line
2.32.0 (Apple Git-132)
maintainer
#1 lore raw
Quoted 2 lines · Michael Trapp
 libuuid/src/gen_uuid.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

This is simple and elegant optimization :) Applied, thanks.

Karel

Signature · 2 lines
 Karel Zak  <[email protected]>
 http://karelzak.blogspot.com