crypto/fsl: add invalidate_dcache_range for hash output buffer
PATCH v2 1/1 crypto/fsl: add invalidate_dcache_range for hash output buffer
HW accelerated hash operations are giving incorrect hash output. so invalidate cache lines to avoid cache overwriting in DDR memory region.
caam_hash()
-moved address alignment check in the beginning of function. -added invalidate_dcache_range for pout buffer before running descriptor.
--- drivers/crypto/fsl/fsl_hash.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)
drivers/crypto/fsl/fsl_hash.c +8 -6
@@ -168,18 +168,18 @@ int caam_hash(const unsigned char *pbuf, unsigned int buf_len,uint32_t *desc;unsigned int size; - desc =malloc_cache_aligned (sizeof (int ) *MAX_CAAM_DESCSIZE ); -if (!desc) { -debug ("Not enough memory for descriptor allocation\n" ); -return -ENOMEM ; - } -if (!IS_ALIGNED ((uintptr_t )pbuf,ARCH_DMA_MINALIGN ) || !IS_ALIGNED ((uintptr_t )pout,ARCH_DMA_MINALIGN )) {puts ("Error: Address arguments are not aligned\n" );return -EINVAL ; } + desc =malloc_cache_aligned (sizeof (int ) *MAX_CAAM_DESCSIZE ); +if (!desc) { +debug ("Not enough memory for descriptor allocation\n" ); +return -ENOMEM ; + } + size =ALIGN (buf_len,ARCH_DMA_MINALIGN );flush_dcache_range ((unsigned long )pbuf, (unsigned long )pbuf + size);
@@ -190,6 +190,8 @@ int caam_hash(const unsigned char *pbuf, unsigned int buf_len, size =ALIGN (sizeof (int ) *MAX_CAAM_DESCSIZE ,ARCH_DMA_MINALIGN );flush_dcache_range ((unsigned long )desc, (unsigned long )desc + size); + size =ALIGN (driver_hash[algo].digestsize,ARCH_DMA_MINALIGN ); +invalidate_dcache_range ((unsigned long )pout, (unsigned long )pout + size); ret =run_descriptor_jr (desc);
Signature · 1 line
2.25.1
PATCH v2 1/1 crypto/fsl: add invalidate_dcache_range for hash output buffer
Quoted 8 lines
HW accelerated hash operations are giving incorrect hash output. so invalidate cache lines to avoid cache overwriting in DDR memory region.
caam_hash()
-moved address alignment check in the beginning of function. -addedinvalidate_dcache_rangefor pout buffer before running descriptor.Fixes d7af2baa49 (crypto/fsl: Fix HW accelerated hash commands)Signed-off-by Gaurav Jain <[email protected]>Reviewed-by Fabio Estevam <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================