Skip to contentSkip to conversation

ASoC: wm8524: remove constraint for FE-BE

PATCH In review Fabio Estevam 2 participants 3 messages Apr 22, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: wm8524: remove constraint for FE-BE

From: Shengjiu Wang <[email protected]>

The constraint is not needed for back end bistream since the sample rate is fixed by dts and the constraint is propagated to front end bistream as they share the same snd_soc_pcm_runtime.

Fixes 007b6a54c305 ("ASoC: codecs: add wm8524 codec driver")
---
 sound/soc/codecs/wm8524.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

(limited to 'sound/soc/codecs/wm8524.c')

sound/soc/codecs/wm8524.c +5 -3
index 81f858f..442a598 100644
@@ -61,6 +61,7 @@ static int wm8524_startup(struct snd_pcm_substream *substream,
 {
 	struct snd_soc_component *component = dai->component;
 	struct wm8524_priv *wm8524 = snd_soc_component_get_drvdata(component);
+	struct snd_soc_pcm_runtime *rtd = substream->private_data;
 
 	/* The set of sample rates that can be supported depends on the
 	 * MCLK supplied to the CODEC - enforce this.
@@ -71,9 +72,10 @@ static int wm8524_startup(struct snd_pcm_substream *substream,
 		return -EINVAL;
 	}
 
-	snd_pcm_hw_constraint_list(substream->runtime, 0,
-				   SNDRV_PCM_HW_PARAM_RATE,
-				   &wm8524->rate_constraint);
+	if (!rtd->dai_link->be_hw_params_fixup)
+		snd_pcm_hw_constraint_list(substream->runtime, 0,
+					   SNDRV_PCM_HW_PARAM_RATE,
+					   &wm8524->rate_constraint);
 
 	gpiod_set_value_cansleep(wm8524->mute, 1);
 
Signature · 1 line
cgit v1.1
#1 lore raw
Quoted 7 lines · Fabio Estevam

From: Shengjiu Wang <[email protected]>

The constraint is not needed for back end bistream since the sample rate is fixed by dts and the constraint is propagated to front end bistream as they share the same snd_soc_pcm_runtime.

Quoted 7 lines
Fixes 007b6a54c305 ("ASoC: codecs: add wm8524 codec driver")

---

There was some previous discussion of this patch here:

https://patchwork.kernel.org/project/alsa-devel/patch/[email protected]/

Thanks,
Charles