Skip to contentSkip to conversation

musl-locales: Add package

PATCH Superseded Khem Raj 2 participants 3 messages Apr 22, 2022

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH v2 1/1 musl-locales: Add package

This package will provide a limited set of localedata for musl based systems. It will fill in into images when IMAGE_LINGUAS variable is set however the choice is limited to the given 13 locales as of now.

e.g.
IMAGE_LINGUAS ?= "de-de fr-fr en-gb"

would work fine

Default locale can be set by exporting LANG=<locale> in /etc/profile or some such file e.g.

export LANG=de_DE.UTF-8

This will also help in ptest coverage with musl where some test packages expect locales e.g. pango to name one.

Do not empty out IMAGE_LINGUAS forcibly for musl anymore

---
v2:
- Fix typo in LICENSE for musl-locales output package
- Do not reset IMAGE_LINGUAS for musl

 meta/conf/distro/include/maintainers.inc   |  1 +
 meta/conf/distro/include/tclibc-musl.inc   |  3 +-
 meta/recipes-core/musl/musl-locales_git.bb | 73 ++++++++++++++++++++++
 3 files changed, 75 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-core/musl/musl-locales_git.bb
meta/conf/distro/include/maintainers.inc +1 -0
index 8bbcf071603..8efa27324f3 100644
@@ -519,6 +519,7 @@ RECIPE_MAINTAINER:pn-mtd-utils = "Denys Dmytriyenko <[email protected]>"
 RECIPE_MAINTAINER:pn-mtdev = "Anuj Mittal <[email protected]>"
 RECIPE_MAINTAINER:pn-mtools = "Anuj Mittal <[email protected]>"
 RECIPE_MAINTAINER:pn-musl = "Khem Raj <[email protected]>"
+RECIPE_MAINTAINER:pn-musl-locales = "Khem Raj <[email protected]>"
 RECIPE_MAINTAINER:pn-musl-obstack = "Khem Raj <[email protected]>"
 RECIPE_MAINTAINER:pn-musl-utils = "Khem Raj <[email protected]>"
 RECIPE_MAINTAINER:pn-nasm = "Richard Purdie <[email protected]>"
meta/conf/distro/include/tclibc-musl.inc +1 -2
index 8badbbb40a6..98d7a801ac8 100644
@@ -10,6 +10,7 @@ PREFERRED_PROVIDER_virtual/libc ?= "musl"
 PREFERRED_PROVIDER_virtual/libiconv ?= "musl"
 PREFERRED_PROVIDER_virtual/libintl ?= "musl"
 PREFERRED_PROVIDER_virtual/crypt ?= "musl"
+PREFERRED_PROVIDER_virtual/libc-locale ?= "musl-locales"
 PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-glibc"
 PREFERRED_PROVIDER_virtual/nativesdk-libiconv ?= "nativesdk-glibc"
 
@@ -19,8 +20,6 @@ DISTRO_FEATURES_BACKFILL_CONSIDERED += "ldconfig"
 
 CXXFLAGS += "-fvisibility-inlines-hidden"
 
-IMAGE_LINGUAS = ""
-
 LIBC_DEPENDENCIES = "\
     musl \
     musl-dbg \
meta/recipes-core/musl/musl-locales_git.bb new file +73 -0

73 lines not on this page · raw message

Signature · 1 line
2.36.0
#1 lore raw

Hi Khem,

Il giorno Thu, 21 Apr 2022 23:10:52 -0700
"Khem Raj" <[email protected]> ha scritto:

Quoted 12 lines

This package will provide a limited set of localedata for musl based systems. It will fill in into images when IMAGE_LINGUAS variable is set however the choice is limited to the given 13 locales as of now.

e.g.
IMAGE_LINGUAS ?= "de-de fr-fr en-gb"

would work fine

Default locale can be set by exporting LANG=<locale> in /etc/profile or some such file e.g.

Quoted 8 lines

export LANG=de_DE.UTF-8

This will also help in ptest coverage with musl where some test packages expect locales e.g. pango to name one.

Do not empty out IMAGE_LINGUAS forcibly for musl anymore

This patch is triggering build failures:

https://autobuilder.yoctoproject.org/typhoon/#/builders/23/builds/5401/steps/13/logs/stdio

Best regards.

Signature · 3 lines
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#2 lore raw
Quoted 23 lines · Luca Ceresoli

Hi Khem,

Il giorno Thu, 21 Apr 2022 23:10:52 -0700
"Khem Raj" <[email protected]> ha scritto:

Quoted 17 lines

This package will provide a limited set of localedata for musl based systems. It will fill in into images when IMAGE_LINGUAS variable is set however the choice is limited to the given 13 locales as of now.

e.g.
IMAGE_LINGUAS ?= "de-de fr-fr en-gb"

would work fine

Default locale can be set by exporting LANG=<locale> in /etc/profile or some such file e.g.

export LANG=de_DE.UTF-8

This will also help in ptest coverage with musl where some test packages expect locales e.g. pango to name one.

Quoted 8 lines
Quoted 3 lines

Do not empty out IMAGE_LINGUAS forcibly for musl anymore

This patch is triggering build failures:

https://autobuilder.yoctoproject.org/typhoon/#/builders/23/builds/5401/steps/13/logs/stdio

strange !. I even tried with your master-next branch poky-contrib/lucaceresoli/master-next
and cherry-picking this patch on top and doing build-appliance-image build. it does not show
this error. So something is amiss here.

This recipe has COMPATIBLE_HOST = ".*-musl.*"
which means glibc build should not even see it.

Quoted 5 lines

Best regards.
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com