Skip to contentSkip to conversation

media: platform: imx-mipi-csis: Remove unneeded 'default n'

PATCH In review Fabio Estevam 2 participants 4 messages Apr 22, 2022 – Apr 23, 2022 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 media: platform: imx-mipi-csis: Remove unneeded 'default n'

From: Fabio Estevam <[email protected]>

There is no need to pass 'default n' in Kconfig, as by default the CONFIG_VIDEO_IMX_MIPI_CSIS option is not selected.

---
 drivers/media/platform/nxp/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/media/platform/nxp/Kconfig +0 -1
index 5afa373e534f..a0810df751dc 100644
@@ -11,7 +11,6 @@ config VIDEO_IMX_MIPI_CSIS
 	select MEDIA_CONTROLLER
 	select V4L2_FWNODE
 	select VIDEO_V4L2_SUBDEV_API
-	default n
 	help
 	  Video4Linux2 sub-device driver for the MIPI CSI-2 CSIS receiver
 	  v3.3/v3.6.3 found on some i.MX7 and i.MX8 SoCs.
Signature · 1 line
2.25.1
#1 lore raw

PATCH 2/2 media: platform: video-viu: Do not select it by default

From: Fabio Estevam <[email protected]>

The video viu driver is not a vital one for booting purposes.

Remove the unneeded 'default y' option.

---
 drivers/media/platform/nxp/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/media/platform/nxp/Kconfig +0 -1
index a0810df751dc..1ac0a6e91111 100644
@@ -20,7 +20,6 @@ config VIDEO_VIU
 	depends on V4L_PLATFORM_DRIVERS
 	depends on VIDEO_DEV && (PPC_MPC512x || COMPILE_TEST) && I2C
 	select VIDEOBUF_DMA_CONTIG
-	default y
 	help
 	  Support for Freescale VIU video driver. This device captures
 	  video data, or overlays video on DIU frame buffer.
Signature · 1 line
2.25.1
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] media: platform: video-viu: Do not select it by default

Hi Fabio,

Thank you for the patch.

Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The video viu driver is not a vital one for booting purposes.

Remove the unneeded 'default y' option.

Quoted 16 lines
---
 drivers/media/platform/nxp/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/media/platform/nxp/Kconfig +0 -1
index a0810df751dc..1ac0a6e91111 100644
@@ -20,7 +20,6 @@ config VIDEO_VIU
 	depends on V4L_PLATFORM_DRIVERS
 	depends on VIDEO_DEV && (PPC_MPC512x || COMPILE_TEST) && I2C
 	select VIDEOBUF_DMA_CONTIG
-	default y
 	help
 	  Support for Freescale VIU video driver. This device captures
 	  video data, or overlays video on DIU frame buffer.
Signature · 3 lines
Regards,

Laurent Pinchart
Reviewed-by on v1 1/2
#3 lore raw
In reply to Fabio Estevam

Hi Fabio,

Thank you for the patch.

Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

There is no need to pass 'default n' in Kconfig, as by default the CONFIG_VIDEO_IMX_MIPI_CSIS option is not selected.

Quoted 16 lines
---
 drivers/media/platform/nxp/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/media/platform/nxp/Kconfig +0 -1
index 5afa373e534f..a0810df751dc 100644
@@ -11,7 +11,6 @@ config VIDEO_IMX_MIPI_CSIS
 	select MEDIA_CONTROLLER
 	select V4L2_FWNODE
 	select VIDEO_V4L2_SUBDEV_API
-	default n
 	help
 	  Video4Linux2 sub-device driver for the MIPI CSI-2 CSIS receiver
 	  v3.3/v3.6.3 found on some i.MX7 and i.MX8 SoCs.
Signature · 3 lines
Regards,

Laurent Pinchart