PCI: mediatek-gen3: Update entries to distinguish MediaTek PCIe controller
PATCH v2 1/1 PCI: mediatek-gen3: Update entries to distinguish MediaTek PCIe controller
Update driver entries in pcie-mediatek-gen3.c to distinguish the MediaTek PCIe controllers.
---
Changes in v2:
Remove the changes in Kconfig description and update the commit message.
--- drivers/pci/controller/pcie-mediatek-gen3.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/pci/controller/pcie-mediatek-gen3.c +6 -6
@@ -1011,21 +1011,21 @@ static const struct dev_pm_ops mtk_pcie_pm_ops = { mtk_pcie_resume_noirq) }; -static const struct of_device_id mtk_pcie_of_match[] = { +static const struct of_device_id mtk_pcie_gen3_of_match[] = { { .compatible ="mediatek,mt8192-pcie" }, {}, }; -MODULE_DEVICE_TABLE (of, mtk_pcie_of_match); +MODULE_DEVICE_TABLE (of, mtk_pcie_gen3_of_match); -static struct platform_driver mtk_pcie_driver = { +static struct platform_driver mtk_pcie_driver_gen3 = { .probe = mtk_pcie_probe, .remove = mtk_pcie_remove, .driver = { - .name ="mtk-pcie" , - .of_match_table = mtk_pcie_of_match, + .name ="mtk-pcie-gen3" , + .of_match_table = mtk_pcie_gen3_of_match, .pm = &mtk_pcie_pm_ops, }, }; -module_platform_driver (mtk_pcie_driver); +module_platform_driver (mtk_pcie_driver_gen3);MODULE_LICENSE ("GPL v2" );
Signature · 1 line
2.18.0
Il 22/04/22 09:09, Jianjun Wang ha scritto:
Quoted 4 lines
Update driver entries in
pcie-mediatek-gen3.cto distinguish the MediaTek PCIe controllers.Signed-off-by Jianjun Wang <[email protected]>
Quoted 7 lines · Jianjun Wang
Update driver entries in
pcie-mediatek-gen3.cto distinguish the MediaTek PCIe controllers.Signed-off-by Jianjun Wang <[email protected]>Reviewed-by AngeloGioacchino Del Regno <
Quoted 2 lines · Jianjun Wang
Update driver entries in
pcie-mediatek-gen3.cto distinguish the MediaTek PCIe controllers.
What's the reason for doing this? I *think* it has something to do with the fact that we currently have two "mtk_pcie_driver"
definitions: one in pcie-mediatek.c and the other in pcie-mediatek-gen3.c, and apparently we want to make them different.
I can buy that. But there are many other symbols with the same names in the two drivers, e.g., mtk_pcie_probe(), mtk_pcie_remove(). Why is mtk_pcie_driver special?
Maybe it's important that the of_device_id[] names be different?
This change is fine; I'd just like the commit log to have a little more explanation of *why* it is useful.
Nit: I don't think this distinguishes the *controllers*. It looks like it distinguishes the *drivers*.
Quoted 48 lines
Signed-off-by Jianjun Wang <[email protected]>---
Changes in v2:
Remove the changes inKconfigdescription and update the commit message.--- drivers/pci/controller/pcie-mediatek-gen3.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)drivers/pci/controller/pcie-mediatek-gen3.c +6
-6@@ -1011,21 +1011,21 @@ static const struct dev_pm_ops mtk_pcie_pm_ops = { mtk_pcie_resume_noirq) }; -static const struct of_device_id mtk_pcie_of_match[] = { +static const struct of_device_id mtk_pcie_gen3_of_match[] = { { .compatible ="mediatek,mt8192-pcie" }, {}, }; -MODULE_DEVICE_TABLE (of, mtk_pcie_of_match); +MODULE_DEVICE_TABLE (of, mtk_pcie_gen3_of_match); -static struct platform_driver mtk_pcie_driver = { +static struct platform_driver mtk_pcie_driver_gen3 = { .probe = mtk_pcie_probe, .remove = mtk_pcie_remove, .driver = { - .name ="mtk-pcie" , - .of_match_table = mtk_pcie_of_match, + .name ="mtk-pcie-gen3" , + .of_match_table = mtk_pcie_gen3_of_match, .pm = &mtk_pcie_pm_ops, }, }; -module_platform_driver (mtk_pcie_driver); +module_platform_driver (mtk_pcie_driver_gen3);MODULE_LICENSE ("GPL v2" );Signature · 7 lines
2.18.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel