Skip to contentSkip to conversation

dt-bindings: i3c: Convert cdns,i3c-master to DT schema

PATCH Applied Rob Herring 3 participants 3 messages Apr 22, 2022 – May 3, 2022

Subsystems (3)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: i3c: Convert cdns,i3c-master to DT schema

Convert the Cadence I3C master to DT schema format. This fixes a warning as it is used in the i3c.yaml example.

The "nintendo,nunchuk" is not documented by a schema, so change the example child device to something which is documented.

---
 .../bindings/i3c/cdns,i3c-master.txt          | 43 -------------
 .../bindings/i3c/cdns,i3c-master.yaml         | 60 +++++++++++++++++++
 2 files changed, 60 insertions(+), 43 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/i3c/cdns,i3c-master.txt
 create mode 100644 Documentation/devicetree/bindings/i3c/cdns,i3c-master.yaml
Documentation/devicetree/bindings/i3c/cdns,i3c-master.txt deleted +0 -43
deleted file mode 100644
index 3716589d6999..000000000000
@@ -1,43 +0,0 @@
-Bindings for cadence I3C master block
-=====================================
-
-Required properties:
---------------------
-- compatible: shall be "cdns,i3c-master"
-- clocks: shall reference the pclk and sysclk
-- clock-names: shall contain "pclk" and "sysclk"
-- interrupts: the interrupt line connected to this I3C master
-- reg: I3C master registers
-
-Mandatory properties defined by the generic binding (see
-Documentation/devicetree/bindings/i3c/i3c.yaml for more details):
-
-- #address-cells: shall be set to 1
-- #size-cells: shall be set to 0
-
-Optional properties defined by the generic binding (see
-Documentation/devicetree/bindings/i3c/i3c.yaml for more details):
-
-- i2c-scl-hz
-- i3c-scl-hz
-
-I3C device connected on the bus follow the generic description (see
-Documentation/devicetree/bindings/i3c/i3c.yaml for more details).
-
-Example:
-
-	i3c-master@0d040000 {
-		compatible = "cdns,i3c-master";
-		clocks = <&coreclock>, <&i3csysclock>;
-		clock-names = "pclk", "sysclk";
-		interrupts = <3 0>;
-		reg = <0x0d040000 0x1000>;
-		#address-cells = <1>;
-		#size-cells = <0>;
-		i2c-scl-hz = <100000>;
-
-		nunchuk: nunchuk@52 {
-			compatible = "nintendo,nunchuk";
-			reg = <0x52 0x0 0x10>;
-		};
-	};
Documentation/devicetree/bindings/i3c/cdns,i3c-master.yaml new file +60 -0

60 lines not on this page · raw message

Signature · 7 lines
2.32.0


-- 
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c
Reviewed-by on v1 1/1
#1 lore raw

On 22/04/2022 21:22, Rob Herring wrote:

(...)

Quoted 44 lines
Documentation/devicetree/bindings/i3c/cdns,i3c-master.yaml new file +38 -0
new file mode 100644
index 000000000000..cc40d25358ec
@@ -0,0 +1,60 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i3c/cdns,i3c-master.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Cadence I3C master block
+
+maintainers:
+  - Boris Brezillon <[email protected]>
+
+allOf:
+  - $ref: i3c.yaml#
+
+properties:
+  compatible:
+    const: cdns,i3c-master
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 2
+
+  clock-names:
+    items:
+      - const: pclk
+      - const: sysclk
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - interrupts

Documentation/devicetree/bindings/i3c/cdns,i3c-master.yaml line 48

Quoted 10 lines
Documentation/devicetree/bindings/i3c/cdns,i3c-master.yaml new file +10 -0
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    i3c-master@d040000 {
+        compatible = "cdns,i3c-master";
+        clocks = <&coreclock>, <&i3csysclock>;
+        clock-names = "pclk", "sysclk";
+        interrupts = <3 0>;

There is a chance this is IRQ_TYPE_NONE and should be something more reasonable, but without DTS example we might not know.

Best regards,
Krzysztof

maintainer Applied
#2 lore raw
In reply to Rob Herring

From: Alexandre Belloni <[email protected]>

Quoted 8 lines · Rob Herring

Convert the Cadence I3C master to DT schema format. This fixes a warning as it is used in the i3c.yaml example.

The "nintendo,nunchuk" is not documented by a schema, so change the example child device to something which is documented.

[...]

Applied, thanks!

[1/1] dt-bindings: i3c: Convert cdns,i3c-master to DT schema

      commit: 4bd69ecfa672e94334618ef9ec653b2a237cf2d9

Best regards,

Signature · 1 line
Alexandre Belloni <[email protected]>